github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix TestAgent_CheckCriticalTime and better error output

pull/5376/head
Alvin Huang 2019-02-15 13:10:02 -05:00
parent 6c9b516a29
commit c23eb91262
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
agent/local/state_test.go
View File

@ -1733,18 +1733,18 @@ func TestAgent_CheckCriticalTime(t *testing.T) {
if c, ok := l.CriticalCheckStates()[checkID]; !ok { if c, ok := l.CriticalCheckStates()[checkID]; !ok {
t.Fatalf("should have a critical check") t.Fatalf("should have a critical check")
} else if c.CriticalFor() > time.Millisecond { } else if c.CriticalFor() > time.Millisecond {
t.Fatalf("bad: %#v", c) t.Fatalf("bad: %#v, check was critical for %v", c, c.CriticalFor())
} }
// Wait a while, then fail it again and make sure the time keeps track // Wait a while, then fail it again and make sure the time keeps track
// of the initial failure, and doesn't reset here. // of the initial failure, and doesn't reset here. Since we are sleeping for
// 50ms the check should not be any less than that.
time.Sleep(50 * time.Millisecond) time.Sleep(50 * time.Millisecond)
l.UpdateCheck(chk.CheckID, api.HealthCritical, "") l.UpdateCheck(chk.CheckID, api.HealthCritical, "")
if c, ok := l.CriticalCheckStates()[checkID]; !ok { if c, ok := l.CriticalCheckStates()[checkID]; !ok {
t.Fatalf("should have a critical check") t.Fatalf("should have a critical check")
} else if c.CriticalFor() < 25*time.Millisecond || } else if c.CriticalFor() < 50*time.Millisecond {
c.CriticalFor() > 75*time.Millisecond { t.Fatalf("bad: %#v, check was critical for %v", c, c.CriticalFor())
t.Fatalf("bad: %#v", c)
} }
// Set it passing again. // Set it passing again.
@ -1759,7 +1759,7 @@ func TestAgent_CheckCriticalTime(t *testing.T) {
if c, ok := l.CriticalCheckStates()[checkID]; !ok { if c, ok := l.CriticalCheckStates()[checkID]; !ok {
t.Fatalf("should have a critical check") t.Fatalf("should have a critical check")
} else if c.CriticalFor() > time.Millisecond { } else if c.CriticalFor() > time.Millisecond {
t.Fatalf("bad: %#v", c) t.Fatalf("bad: %#v, check was critical for %v", c, c.CriticalFor())
} }
} }