mirror of https://github.com/hashicorp/consul
Browse Source
* add snapshot restore test * add logstore as test parameter * Use the correct image version * make sure we read the logs from a followers to test the follower snapshot install path. * update to raf-wal v0.3.0 * add changelog. * updating changelog for bug description and removed integration test. * setting up test container builder to only set logStore for 1.15 and higher --------- Co-authored-by: Paul Banks <pbanks@hashicorp.com> Co-authored-by: John Murret <john.murret@hashicorp.com>pull/15807/head
Dhia Ayachi
2 years ago
committed by
GitHub
7 changed files with 150 additions and 16 deletions
@ -0,0 +1,3 @@
|
||||
```release-note:bug |
||||
raft_logstore: Fixes a bug where restoring a snapshot when using the experimental WAL storage backend causes a panic. |
||||
``` |
||||
@ -0,0 +1,97 @@
|
||||
package snapshot |
||||
|
||||
import ( |
||||
"fmt" |
||||
"github.com/hashicorp/consul/api" |
||||
libcluster "github.com/hashicorp/consul/test/integration/consul-container/libs/cluster" |
||||
libtopology "github.com/hashicorp/consul/test/integration/consul-container/libs/topology" |
||||
"github.com/hashicorp/consul/test/integration/consul-container/libs/utils" |
||||
"github.com/stretchr/testify/require" |
||||
"io" |
||||
"testing" |
||||
) |
||||
|
||||
func TestSnapshotRestore(t *testing.T) { |
||||
|
||||
cases := []libcluster.LogStore{libcluster.LogStore_WAL, libcluster.LogStore_BoltDB} |
||||
|
||||
for _, c := range cases { |
||||
t.Run(fmt.Sprintf("test log store: %s", c), func(t *testing.T) { |
||||
testSnapShotRestoreForLogStore(t, c) |
||||
}) |
||||
} |
||||
} |
||||
|
||||
func testSnapShotRestoreForLogStore(t *testing.T, logStore libcluster.LogStore) { |
||||
|
||||
const ( |
||||
numServers = 3 |
||||
) |
||||
|
||||
// Create initial cluster
|
||||
cluster, _, _ := libtopology.NewCluster(t, &libtopology.ClusterConfig{ |
||||
NumServers: numServers, |
||||
NumClients: 0, |
||||
BuildOpts: &libcluster.BuildOptions{ |
||||
Datacenter: "dc1", |
||||
ConsulImageName: utils.TargetImageName, |
||||
ConsulVersion: utils.TargetVersion, |
||||
LogStore: logStore, |
||||
}, |
||||
ApplyDefaultProxySettings: true, |
||||
}) |
||||
|
||||
client := cluster.APIClient(0) |
||||
libcluster.WaitForLeader(t, cluster, client) |
||||
libcluster.WaitForMembers(t, client, 3) |
||||
|
||||
for i := 0; i < 100; i++ { |
||||
_, err := client.KV().Put(&api.KVPair{Key: fmt.Sprintf("key-%d", i), Value: []byte(fmt.Sprintf("value-%d", i))}, nil) |
||||
require.NoError(t, err) |
||||
} |
||||
|
||||
var snapshot io.ReadCloser |
||||
var err error |
||||
snapshot, _, err = client.Snapshot().Save(nil) |
||||
require.NoError(t, err) |
||||
|
||||
err = cluster.Terminate() |
||||
require.NoError(t, err) |
||||
// Create a fresh cluster from scratch
|
||||
cluster2, _, _ := libtopology.NewCluster(t, &libtopology.ClusterConfig{ |
||||
NumServers: numServers, |
||||
NumClients: 0, |
||||
BuildOpts: &libcluster.BuildOptions{ |
||||
Datacenter: "dc1", |
||||
ConsulImageName: utils.TargetImageName, |
||||
ConsulVersion: utils.TargetVersion, |
||||
LogStore: logStore, |
||||
}, |
||||
ApplyDefaultProxySettings: true, |
||||
}) |
||||
client2 := cluster2.APIClient(0) |
||||
|
||||
libcluster.WaitForLeader(t, cluster2, client2) |
||||
libcluster.WaitForMembers(t, client2, 3) |
||||
|
||||
// Restore the saved snapshot
|
||||
require.NoError(t, client2.Snapshot().Restore(nil, snapshot)) |
||||
|
||||
libcluster.WaitForLeader(t, cluster2, client2) |
||||
|
||||
followers, err := cluster2.Followers() |
||||
require.NoError(t, err) |
||||
require.Len(t, followers, 2) |
||||
|
||||
// use a follower api client and set `AllowStale` to true
|
||||
// to test the follower snapshot install code path as well.
|
||||
fc := followers[0].GetClient() |
||||
|
||||
for i := 0; i < 100; i++ { |
||||
kv, _, err := fc.KV().Get(fmt.Sprintf("key-%d", i), &api.QueryOptions{AllowStale: true}) |
||||
require.NoError(t, err) |
||||
require.Equal(t, kv.Key, fmt.Sprintf("key-%d", i)) |
||||
require.Equal(t, kv.Value, []byte(fmt.Sprintf("value-%d", i))) |
||||
} |
||||
|
||||
} |
||||
Loading…
Reference in new issue