github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #11812 from hashicorp/metrics-ui-acls 

oss: use wildcard partition in metrics proxy ui endpoint
pull/11335/head
Kyle Havlovitz 2021-12-10 16:24:47 -08:00 committed by GitHub
parent 9dcaf0539c 018693b6ee
commit b50ef696c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
agent/ui_endpoint.go
View File

@ -631,9 +631,10 @@ func (s *HTTPHandlers) UIMetricsProxy(resp http.ResponseWriter, req *http.Reques
// //
// In enterprise it requires this _in all namespaces_ too. // In enterprise it requires this _in all namespaces_ too.
// //
// TODO(partitions,acls): need to revisit this // In enterprise it requires this _in all namespaces and partitions_ too.
var authzContext acl.AuthorizerContext var authzContext acl.AuthorizerContext
entMeta.WithWildcardNamespace().FillAuthzContext(&authzContext) wildcardEntMeta := structs.WildcardEnterpriseMetaInPartition(structs.WildcardSpecifier)
wildcardEntMeta.FillAuthzContext(&authzContext)
if authz.NodeReadAll(&authzContext) != acl.Allow || authz.ServiceReadAll(&authzContext) != acl.Allow { if authz.NodeReadAll(&authzContext) != acl.Allow || authz.ServiceReadAll(&authzContext) != acl.Allow {
return nil, acl.ErrPermissionDenied return nil, acl.ErrPermissionDenied