From b4c5c58c9b0a9926cf5382a78a7334c58de908d9 Mon Sep 17 00:00:00 2001
From: freddygv <freddy@hashicorp.com>
Date: Wed, 30 Jun 2021 16:16:16 -0600
Subject: [PATCH] Add TODOs about partition handling

---
 agent/proxycfg/state_test.go | 3 ++-
 agent/proxycfg/upstreams.go  | 2 +-
 agent/xds/clusters.go        | 6 ++++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/agent/proxycfg/state_test.go b/agent/proxycfg/state_test.go
index 9cc21b1ab7..9bb4895fab 100644
--- a/agent/proxycfg/state_test.go
+++ b/agent/proxycfg/state_test.go
@@ -1870,7 +1870,8 @@ func TestState_WatchesAndUpdates(t *testing.T) {
 								SNI: connect.ServiceSNI("db", "", structs.IntentionDefaultNamespace, snap.Datacenter, snap.Roots.TrustDomain),
 								SpiffeID: connect.SpiffeIDService{
 									Host:       snap.Roots.TrustDomain,
-									Namespace:  structs.IntentionDefaultNamespace,
+									Namespace:  db.NamespaceOrDefault(),
+									Partition:  db.PartitionOrDefault(),
 									Datacenter: snap.Datacenter,
 									Service:    "db",
 								},
diff --git a/agent/proxycfg/upstreams.go b/agent/proxycfg/upstreams.go
index d3557e5274..f634cf0a7d 100644
--- a/agent/proxycfg/upstreams.go
+++ b/agent/proxycfg/upstreams.go
@@ -96,7 +96,7 @@ func (s *handlerUpstreams) handleUpdateUpstreams(ctx context.Context, u cache.Up
 
 				spiffeID := connect.SpiffeIDService{
 					Host:       snap.Roots.TrustDomain,
-					Partition:  "",
+					Partition:  svc.PartitionOrDefault(),
 					Namespace:  svc.NamespaceOrDefault(),
 					Datacenter: snap.Datacenter,
 					Service:    svc.Name,
diff --git a/agent/xds/clusters.go b/agent/xds/clusters.go
index fbd428d708..c07b275c00 100644
--- a/agent/xds/clusters.go
+++ b/agent/xds/clusters.go
@@ -540,6 +540,8 @@ func (s *ResourceGenerator) makeUpstreamClusterForPreparedQuery(upstream structs
 		Namespace:  upstream.DestinationNamespace,
 		Datacenter: dc,
 		Service:    upstream.DestinationName,
+
+		// TODO(partitions) Store partition
 	}
 
 	// Enable TLS upstream with the configured client certificate.
@@ -623,6 +625,8 @@ func (s *ResourceGenerator) makeUpstreamClustersForDiscoveryChain(
 			Namespace:  target.Namespace,
 			Datacenter: target.Datacenter,
 			Service:    target.Service,
+
+			// TODO(partitions) Store partition
 		}
 
 		if failoverThroughMeshGateway {
@@ -658,6 +662,8 @@ func (s *ResourceGenerator) makeUpstreamClustersForDiscoveryChain(
 					Namespace:  target.Namespace,
 					Datacenter: target.Datacenter,
 					Service:    target.Service,
+
+					// TODO(partitions) Store partition
 				}
 
 				// Failover targets might be subsets of the same service, so these are deduplicated.