Log the correlation ID when blocking queries fire (#10689)

Knowing that blocking queries are firing does not provide much
information on its own. If we know the correlation IDs we can
piece together which parts of the snapshot have been populated.

Some of these responses might be empty from the blocking
query timing out. But if they're returning quickly I think we
can reasonably assume they contain data.
pull/10698/head
Freddy 3 years ago committed by hc-github-team-consul-core
parent 3dde24d8c9
commit 9265d20859

@ -0,0 +1,3 @@
```release-note:improvement
proxycfg: log correlation IDs for the proxy configuration snapshot's blocking queries.
```

@ -638,7 +638,7 @@ func (s *state) run(snap *ConfigSnapshot) {
case <-s.ctx.Done(): case <-s.ctx.Done():
return return
case u := <-s.ch: case u := <-s.ch:
s.logger.Trace("A blocking query returned; handling snapshot update") s.logger.Trace("A blocking query returned; handling snapshot update", "correlationID", u.CorrelationID)
if err := s.handleUpdate(u, snap); err != nil { if err := s.handleUpdate(u, snap); err != nil {
s.logger.Error("Failed to handle update from watch", s.logger.Error("Failed to handle update from watch",

Loading…
Cancel
Save