From 904a4c38364acb83e30000bb740eba3973a958c3 Mon Sep 17 00:00:00 2001 From: hc-github-team-consul-core Date: Fri, 4 Nov 2022 11:19:44 -0400 Subject: [PATCH] Backport of Backport tests from ent. into release/1.14.x (#15262) This pull request was automerged via backport-assistant --- agent/agent_test.go | 12 ++++++++---- .../grpc-external/services/peerstream/stream_test.go | 5 ++++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/agent/agent_test.go b/agent/agent_test.go index 2c941e9058..015bb38438 100644 --- a/agent/agent_test.go +++ b/agent/agent_test.go @@ -326,7 +326,9 @@ func TestAgent_HTTPMaxHeaderBytes(t *testing.T) { }, Cache: cache.New(cache.Options{}), } - bd, err = initEnterpriseBaseDeps(bd, nil) + + cfg := config.RuntimeConfig{BuildDate: time.Date(2000, 1, 1, 0, 0, 1, 0, time.UTC)} + bd, err = initEnterpriseBaseDeps(bd, &cfg) require.NoError(t, err) a, err := New(bd) @@ -5418,7 +5420,8 @@ func TestAgent_ListenHTTP_MultipleAddresses(t *testing.T) { Cache: cache.New(cache.Options{}), } - bd, err = initEnterpriseBaseDeps(bd, nil) + cfg := config.RuntimeConfig{BuildDate: time.Date(2000, 1, 1, 0, 0, 1, 0, time.UTC)} + bd, err = initEnterpriseBaseDeps(bd, &cfg) require.NoError(t, err) agent, err := New(bd) @@ -6003,7 +6006,7 @@ func TestAgent_startListeners(t *testing.T) { Cache: cache.New(cache.Options{}), } - bd, err := initEnterpriseBaseDeps(bd, nil) + bd, err := initEnterpriseBaseDeps(bd, &config.RuntimeConfig{}) require.NoError(t, err) agent, err := New(bd) @@ -6134,7 +6137,8 @@ func TestAgent_startListeners_scada(t *testing.T) { Cache: cache.New(cache.Options{}), } - bd, err := initEnterpriseBaseDeps(bd, nil) + cfg := config.RuntimeConfig{BuildDate: time.Date(2000, 1, 1, 0, 0, 1, 0, time.UTC)} + bd, err := initEnterpriseBaseDeps(bd, &cfg) require.NoError(t, err) agent, err := New(bd) diff --git a/agent/grpc-external/services/peerstream/stream_test.go b/agent/grpc-external/services/peerstream/stream_test.go index 35a5c5a13d..57fd32706c 100644 --- a/agent/grpc-external/services/peerstream/stream_test.go +++ b/agent/grpc-external/services/peerstream/stream_test.go @@ -1159,7 +1159,7 @@ func TestStreamResources_Server_CARootUpdates(t *testing.T) { func TestStreamResources_Server_AckNackNonce(t *testing.T) { srv, store := newTestServer(t, func(c *Config) { - c.incomingHeartbeatTimeout = 50 * time.Millisecond + c.incomingHeartbeatTimeout = 10 * time.Millisecond }) p := writePeeringToBeDialed(t, store, 1, "my-peer") @@ -1204,6 +1204,9 @@ func TestStreamResources_Server_AckNackNonce(t *testing.T) { require.NoError(t, err) require.Equal(t, "5678", msg.GetRequest().ResponseNonce) }) + // Add in a sleep to prevent the test from flaking. + // The mock client expects certain calls to be made. + time.Sleep(50 * time.Millisecond) } // Test that when the client doesn't send a heartbeat in time, the stream is disconnected.