ui: Change the URL prefix of partitions from `-` to `_` (#11801)

.changelog/11801.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+ui: Change partition URL segment prefix from `-` to `_` 
+```

ui/packages/consul-ui/app/locations/fsm-with-optional.js

@@ -1,7 +1,7 @@
 import { env } from 'consul-ui/env';
 const OPTIONAL = {};
 if (env('CONSUL_PARTITIONS_ENABLED')) {
-  OPTIONAL.partition = /^-([a-zA-Z0-9]([a-zA-Z0-9-]{0,62}[a-zA-Z0-9])?)$/;
+  OPTIONAL.partition = /^_([a-zA-Z0-9]([a-zA-Z0-9-]{0,62}[a-zA-Z0-9])?)$/;
 }
 
 if (env('CONSUL_NSPACES_ENABLED')) {
@@ -194,7 +194,7 @@ export default class FSMWithOptionalLocation {
       hash.nspace = `~${hash.nspace}`;
     }
     if (typeof hash.partition !== 'undefined') {
-      hash.partition = `-${hash.partition}`;
+      hash.partition = `_${hash.partition}`;
     }
     if (typeof this.router === 'undefined') {
       this.router = this.container.lookup('router:main');

ui/packages/consul-ui/app/services/ui-config.js

@@ -18,7 +18,7 @@ export default class UiConfigService extends Service {
         case item.startsWith('~'):
           prev.nspace = item.substr(1);
           break;
-        case item.startsWith('-'):
+        case item.startsWith('_'):
           prev.partition = item.substr(1);
           break;
         case typeof prev.dc === 'undefined':