Browse Source

handle error scenario of empty local DC

pull/11541/head
freddygv 3 years ago
parent
commit
5c121d7a48
  1. 4
      agent/consul/config_endpoint.go
  2. 8
      agent/consul/config_endpoint_test.go

4
agent/consul/config_endpoint.go

@ -598,6 +598,10 @@ func gateWriteToSecondary(targetDC, localDC, primaryDC, kind string) error {
if kind != structs.PartitionExports {
return nil
}
if localDC == "" {
// This should not happen because the datacenter is defaulted in DefaultConfig.
return fmt.Errorf("unknown local datacenter")
}
if primaryDC == "" {
primaryDC = localDC

8
agent/consul/config_endpoint_test.go

@ -2151,6 +2151,14 @@ func Test_gateWriteToSecondary(t *testing.T) {
},
wantErr: "must target the primary datacenter explicitly",
},
{
name: "empty local DC",
args: args{
localDC: "",
kind: structs.PartitionExports,
},
wantErr: "unknown local datacenter",
},
}
for _, tc := range tt {
t.Run(tc.name, func(t *testing.T) {

Loading…
Cancel
Save