Move destroy handler registration in with-copyable

pull/19210/head
wenincode 1 year ago
parent e78cf7b719
commit 5a66bde6d4

@ -13,7 +13,7 @@ const typeAssertion = (type, value, withDefault) => {
};
function cleanup(instance) {
if (instance?.source && instance?.hash) {
if (instance && instance?.source && instance?.hash) {
instance.source?.off('success', instance.hash.success)?.off('error', instance.hash.error);
instance.source?.destroy();
@ -50,11 +50,15 @@ export default class WithCopyableModifier extends Modifier {
this.hash = hash;
}
constructor() {
super(...arguments);
registerDestructor(this, cleanup);
}
modify(element, [value], namedArgs) {
this.element = element;
this.disconnect();
this.connect(value, namedArgs);
registerDestructor(this, cleanup);
}
disconnect() {

Loading…
Cancel
Save