consul: ensure connections are properly closed

pull/179/head
Armon Dadgar 11 years ago
parent d1ebf83e39
commit 57cef6e9b1

@ -266,8 +266,11 @@ func (p *ConnPool) getNewConn(addr net.Addr, version int) (*Conn, error) {
func (p *ConnPool) clearConn(addr net.Addr) {
p.Lock()
defer p.Unlock()
if conn, ok := p.pool[addr.String()]; ok {
conn.Close()
delete(p.pool, addr.String())
}
}
// releaseConn is invoked when we are done with a conn to reduce the ref count
func (p *ConnPool) releaseConn(conn *Conn) {
@ -315,10 +318,8 @@ func (p *ConnPool) RPC(addr net.Addr, version int, method string, args interface
return nil
}
// If its a network error, nuke the connection
if _, ok := err.(net.Error); ok {
// Do-not re-use as a pre-caution
p.clearConn(addr)
}
return fmt.Errorf("rpc error: %v", err)
}

Loading…
Cancel
Save