github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

catalog: add failover mode enum validation (#18545)

pull/18448/head
R.B. Boyer 2023-08-22 11:09:37 -05:00 committed by GitHub
parent c4b3234bbc
commit 570c84d032
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/catalog/internal/types/failover_policy.go
View File

@ -139,6 +139,18 @@ func validateFailoverConfig(config *pbcatalog.FailoverConfig, ported bool) []err
}
}
switch config.Mode {
case pbcatalog.FailoverMode_FAILOVER_MODE_UNSPECIFIED:
// means pbcatalog.FailoverMode_FAILOVER_MODE_SEQUENTIAL
case pbcatalog.FailoverMode_FAILOVER_MODE_SEQUENTIAL:
case pbcatalog.FailoverMode_FAILOVER_MODE_ORDER_BY_LOCALITY:
default:
errs = append(errs, resource.ErrInvalidField{
Name: "mode",
Wrapped: fmt.Errorf("not a supported enum value: %v", config.Mode),
})
}
// TODO: validate sameness group requirements
return errs

9
internal/catalog/internal/types/failover_policy_test.go
View File

@ -200,6 +200,15 @@ func TestValidateFailoverPolicy(t *testing.T) {
SamenessGroup: "blah",
},
},
"mode: invalid": {
config: &pbcatalog.FailoverConfig{
Mode: 99,
Destinations: []*pbcatalog.FailoverDestination{
{Ref: newRef(ServiceType, "api-backup")},
},
},
expectErr: `invalid "mode" field: not a supported enum value: 99`,
},
"dest: no ref": {
config: &pbcatalog.FailoverConfig{
Destinations: []*pbcatalog.FailoverDestination{