From 49431c7532958bbb852681e46209598adac38a8a Mon Sep 17 00:00:00 2001 From: "R.B. Boyer" <4903+rboyer@users.noreply.github.com> Date: Fri, 11 Feb 2022 10:45:37 -0600 Subject: [PATCH] ensure make dev target puts the newly constructed binary onto the PATH (#12318) This restores the prior behavior of make dev and ensures that tests using the sdk package (like the api package) will correctly locate the consul binary under test. Also ensure the constructed consul binary is present on the path for sdk-based tests. --- GNUmakefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/GNUmakefile b/GNUmakefile index b47d04dc4f..4742cd8784 100644 --- a/GNUmakefile +++ b/GNUmakefile @@ -18,6 +18,8 @@ GOTAGS ?= GOPATH=$(shell go env GOPATH) MAIN_GOPATH=$(shell go env GOPATH | cut -d: -f1) +export PATH := $(PWD)/bin:$(PATH) + ASSETFS_PATH?=agent/uiserver/bindata_assetfs.go # Get the git commit GIT_COMMIT?=$(shell git rev-parse --short HEAD) @@ -145,7 +147,8 @@ dev: dev-build dev-build: mkdir -p bin - CGO_ENABLED=0 go build -o ./bin -ldflags "$(GOLDFLAGS)" -tags "$(GOTAGS)" + CGO_ENABLED=0 go install -ldflags "$(GOLDFLAGS)" -tags "$(GOTAGS)" + cp -f ${MAIN_GOPATH}/bin/consul ./bin/consul dev-docker: linux @echo "Pulling consul container image - $(CONSUL_IMAGE_VERSION)"