From 45e635286ada6d80888e5eed1b7ceb67fa22e8bb Mon Sep 17 00:00:00 2001 From: Chris Piraino Date: Fri, 1 May 2020 09:31:23 -0500 Subject: [PATCH] Re-add comment on connect-proxy virtual hosts --- agent/xds/routes.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/agent/xds/routes.go b/agent/xds/routes.go index a53eebe24f..48de369a14 100644 --- a/agent/xds/routes.go +++ b/agent/xds/routes.go @@ -55,8 +55,11 @@ func routesFromSnapshotConnectProxy(cfgSnap *proxycfg.ConfigSnapshot) ([]proto.M } route := &envoy.RouteConfiguration{ - Name: upstreamID, - VirtualHosts: []envoyroute.VirtualHost{virtualHost}, + Name: upstreamID, + VirtualHosts: []envoyroute.VirtualHost{virtualHost}, + // ValidateClusters defaults to true when defined statically and false + // when done via RDS. Re-set the sane value of true to prevent + // null-routing traffic. ValidateClusters: makeBoolValue(true), } resources = append(resources, route)