From 3da2fbdc632ddc8b002feebf0cadfed3d5f7280b Mon Sep 17 00:00:00 2001 From: Paul Banks Date: Fri, 8 Oct 2021 12:26:11 +0100 Subject: [PATCH] Wording improvements from review --- .../connect/config-entries/ingress-gateway.mdx | 4 ++-- .../docs/connect/config-entries/service-router.mdx | 14 ++++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/website/content/docs/connect/config-entries/ingress-gateway.mdx b/website/content/docs/connect/config-entries/ingress-gateway.mdx index 049a3077a8..6be29df290 100644 --- a/website/content/docs/connect/config-entries/ingress-gateway.mdx +++ b/website/content/docs/connect/config-entries/ingress-gateway.mdx @@ -397,7 +397,7 @@ spec: -Set up a HTTP listener on an ingress gateway named "us-east-ingress" to proxy +Set up an HTTP listener on an ingress gateway named "us-east-ingress" to proxy traffic to a virtual service named "api". Additionally, ensure internal-only debug headers are stripped before responding @@ -476,7 +476,7 @@ spec: -Set up a HTTP listener on an ingress gateway named "us-east-ingress" in the +Set up an HTTP listener on an ingress gateway named "us-east-ingress" in the default namespace to proxy traffic to a virtual service named "api". Additionally, ensure internal-only debug headers are stripped before responding diff --git a/website/content/docs/connect/config-entries/service-router.mdx b/website/content/docs/connect/config-entries/service-router.mdx index e63added61..3e02f16011 100644 --- a/website/content/docs/connect/config-entries/service-router.mdx +++ b/website/content/docs/connect/config-entries/service-router.mdx @@ -610,9 +610,10 @@ spec: yaml: false, name: 'Add', type: 'map: optional', - description: `The set of header values to add, keyed by header name. - If a header with the same (case-insensitive) name already - exists, the value set here will be appended and both will be present. + description: `The set of key/value pairs that specify header values to add. + Use header names as keys. Header names are _not_ case-sensitive. + If header values with the same name already exist, the value set here will + be appended and both will be present. If Envoy is used as the proxy, the value may contain [variable placeholders](https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#custom-request-response-headers) for example \`%DOWNSTREAM_REMOTE_ADDRESS%\` to interpolate dynamic request @@ -622,9 +623,10 @@ spec: yaml: false, name: 'Set', type: 'map: optional', - description: `The set of header value keyed by header name to - add. If one or more header values with the same (case-insensitive) name already exist, - the value set here will replace them all. + description: `The set of key/value pairs that specify header values to add. + Use header names as keys. Header names are _not_ case-sensitive. + If header values with the same name already exist, the value set here will + _replace_ them. If Envoy is used as the proxy, the value may contain [variable placeholders](https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/headers#custom-request-response-headers) for example \`%DOWNSTREAM_REMOTE_ADDRESS%\` to interpolate dynamic request