From 2c21ead80e41f7804dbba16e1f7ebc576acd10fb Mon Sep 17 00:00:00 2001 From: Paul Banks Date: Wed, 13 Jun 2018 20:43:34 +0100 Subject: [PATCH] More test tweaks --- agent/agent_endpoint_test.go | 6 +++--- agent/structs/connect.go | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/agent/agent_endpoint_test.go b/agent/agent_endpoint_test.go index f19a496115..2416cb289f 100644 --- a/agent/agent_endpoint_test.go +++ b/agent/agent_endpoint_test.go @@ -2679,6 +2679,9 @@ func TestAgentConnectCALeafCert_good(t *testing.T) { obj, err := a.srv.AgentConnectCALeafCert(resp, req) require.NoError(err) + // That should've been a cache miss, so no hit change. + require.Equal(cacheHits, a.cache.Hits()) + // Get the issued cert issued, ok := obj.(*structs.IssuedCert) assert.True(ok) @@ -2691,9 +2694,6 @@ func TestAgentConnectCALeafCert_good(t *testing.T) { assert.Equal(fmt.Sprintf("%d", issued.ModifyIndex), resp.Header().Get("X-Consul-Index")) - // That should've been a cache miss, so no hit change - require.Equal(cacheHits, a.cache.Hits()) - // Test caching { // Fetch it again diff --git a/agent/structs/connect.go b/agent/structs/connect.go index e08d016464..f35417c2ba 100644 --- a/agent/structs/connect.go +++ b/agent/structs/connect.go @@ -108,7 +108,7 @@ type ConnectManagedProxy struct { // ConnectManagedProxyConfig represents the parts of the proxy config the agent // needs to understand. It's bad UX to make the user specify these separately // just to make parsing simpler for us so this encapsulates the fields in -// ConnectManagedProxy.Config that we care about. They are all optoinal anyway +// ConnectManagedProxy.Config that we care about. They are all optional anyway // and this is used to decode them with mapstructure. type ConnectManagedProxyConfig struct { BindAddress string `mapstructure:"bind_address"`