github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Clarifies comment about name vs. ID.

pull/1389/head
James Phillips 2015-11-09 21:15:55 -08:00
parent 666619dfc9
commit 0bd7e82686
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
consul/state/prepared_query.go
View File

@ -68,9 +68,12 @@ func (s *StateStore) preparedQuerySetTxn(tx *memdb.Txn, idx uint64, query *struc
query.ModifyIndex = idx query.ModifyIndex = idx
} }
// Verify that the name doesn't alias any existing ID. If we didn't do // Verify that the name doesn't alias any existing ID. We allow queries
// this then a bad actor could steal traffic away from an existing DNS // to be looked up by ID *or* name so we don't want anyone to try to
// entry. // register a query with a name equal to some other query's ID in an
// attempt to hijack it. We also look up by ID *then* name in order to
// prevent this, but it seems prudent to prevent these types of rogue
// queries from ever making it into the state store.
if query.Name != "" { if query.Name != "" {
existing, err := tx.First("prepared-queries", "id", query.Name) existing, err := tx.First("prepared-queries", "id", query.Name)