github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Move destroy handler registration in with-copyable

pull/19226/head
wenincode 2023-10-13 14:40:48 -06:00 committed by Chris Hut
parent 0fd98e7e05
commit 0519b9bd73
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/packages/consul-ui/app/modifiers/with-copyable.js
View File

@ -12,7 +12,7 @@ const typeAssertion = (type, value, withDefault) => {
};
function cleanup(instance) {
if (instance?.source && instance?.hash) {
if (instance && instance?.source && instance?.hash) {
instance.source?.off('success', instance.hash.success)?.off('error', instance.hash.error);
instance.source?.destroy();
@ -49,11 +49,15 @@ export default class WithCopyableModifier extends Modifier {
this.hash = hash;
}
constructor() {
super(...arguments);
registerDestructor(this, cleanup);
}
modify(element, [value], namedArgs) {
this.element = element;
this.disconnect();
this.connect(value, namedArgs);
registerDestructor(this, cleanup);
}
disconnect() {