github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '7510f00100'
${ noResults }
consul/GNUmakefile

64 lines
1.9 KiB
Raw Normal View History Unescape

Add a tools target that fetches various build-time tools
9 years ago
GOTOOLS = github.com/mitchellh/gox golang.org/x/tools/cmd/stringer \
github.com/jteeuwen/go-bindata/... github.com/elazarl/go-bindata-assetfs/...
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
9 years ago
PACKAGES=$(shell go list ./... | grep -v '^github.com/hashicorp/consul/vendor/')
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
10 years ago
VETARGS?=-asmdecl -atomic -bool -buildtags -copylocks -methods \
-nilfunc -printf -rangeloops -shift -structtags -unsafeptr
Use gox for building
9 years ago
VERSION?=$(shell awk -F\" '/^const Version/ { print $$2; exit }' version.go)
consul: adding basic skeleton
11 years ago
Tweaks some of the default makefile targets.
9 years ago
# all builds binaries for all targets
all: tools
consul: adding basic skeleton
11 years ago
@mkdir -p bin/
Use gox for building
9 years ago
@sh -c "'$(CURDIR)/scripts/build.sh'"
Typos
9 years ago
# dev creates binaries for testing locally - these are put into ./bin and $GOPATH
Tweaks some of the default makefile targets.
9 years ago
dev: format
Use gox for building
9 years ago
@CONSUL_DEV=1 sh -c "'$(CURDIR)/scripts/build.sh'"
Tweaks some of the default makefile targets.
9 years ago
# dist builds binaries for all platforms and packages them for distribution
dist:
Use gox for building
9 years ago
@sh -c "'$(CURDIR)/scripts/dist.sh' $(VERSION)"
consul: adding basic skeleton
11 years ago
cov:
gocov test ./... | gocov-html > /tmp/coverage.html
open /tmp/coverage.html
Tweaks some of the default makefile targets.
9 years ago
test: format
Running go vet before test
9 years ago
@$(MAKE) vet
Build consul to a temp dir for API tests
10 years ago
@./scripts/verify_no_uuid.sh
@./scripts/test.sh
Adding fast-path for testing without depedency updates
10 years ago
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
9 years ago
cover:
Separate cover target for tests
10 years ago
go list ./... | xargs -n1 go test --cover
consul: adding basic skeleton
11 years ago
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
9 years ago
format:
Add format task to all and silence large output
11 years ago
@echo "--> Running go fmt"
@go fmt $(PACKAGES)
Add make format task
11 years ago
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
10 years ago
vet:
@go tool vet 2>/dev/null ; if [ $$? -eq 3 ]; then \
go get golang.org/x/tools/cmd/vet; \
fi
@echo "--> Running go tool vet $(VETARGS) ."
Don't run `go vet` on vendor/
9 years ago
@go list ./... \
| grep -v ^github.com/hashicorp/consul/vendor/ \
| cut -d '/' -f 4- \
| xargs -n1 \
go tool vet $(VETARGS) ;\
Makes vet check more sure fire now that it's xargs-ed.
9 years ago
if [ $$? -ne 0 ]; then \
Makefile: add vet target Add a vet target in order to catch suspicious constructs reported by go vet. Vet has successfully detected problems in the past, for example, see c9333b1b9b472feb5cad80e2c8276d41b64bde88 Some vet flags are noisy. In particular, the following flags reports a large amount of generally unharmful constructs: ``` -assign: check for useless assignments -composites: check that composite literals used field-keyed elements -shadow: check for shadowed variables -shadowstrict: whether to be strict about shadowing -unreachable: check for unreachable code ``` In order to skip running the flags mentioned above, vet is invoked on a directory basis with `go tool vet .` since package- level type-checking with `go vet` doesn't accept flags. Hence, each file is vetted in isolation, which is weaker than package-level type-checking. But nevertheless, it might catch suspicious constructs that pose a real issue. The vet target runs the following flags on the entire repo: ``` -asmdecl: check assembly against Go declarations -atomic: check for common mistaken usages of the sync/atomic package -bool: check for mistakes involving boolean operators -buildtags: check that +build tags are valid -copylocks: check that locks are not passed by value -methods: check that canonically named methods are canonically defined -nilfunc: check for comparisons between functions and nil -printf: check printf-like invocations -rangeloops: check that range loop variables are used correctly -shift: check for useless shifts -structtags: check that struct field tags have canonical format and apply to exported fields as needed -unsafeptr: check for misuse of unsafe.Pointer ``` Now and then, it might make sense to check the output of the disabled flags manually. For example, `VETARGS=-unreachable make vet` can detect several lines of dead code that can be deleted, etc.
10 years ago
echo ""; \
echo "Vet found suspicious constructs. Please check the reported constructs"; \
echo "and fix them if necessary before submitting the code for reviewal."; \
fi
Removes from cruft from the makefile.
9 years ago
# generates the static web ui that's compiled into the binary
Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`
9 years ago
static-assets:
agent: compile web assets into consul binary
9 years ago
@echo "--> Generating static assets"
Fixes the static asset generator for new pkg path, updates assets.
9 years ago
@go-bindata-assetfs -pkg agent -prefix pkg ./pkg/web_ui/...
agent: compile web assets into consul binary
9 years ago
@mv bindata_assetfs.go command/agent
$(MAKE) format
Add a tools target that fetches various build-time tools
9 years ago
tools:
go get -u -v $(GOTOOLS)
Removes from cruft from the makefile.
9 years ago
.PHONY: all bin dev dist cov test cover format vet static-assets tools