github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '745d1243f8'
${ noResults }
consul/ui-v2/app/helpers/format-number.js

11 lines
461 B
Raw Normal View History Unescape

UI: Reduce in-development deprecations (also use toLocaleString) (#4677) Various ember addons produced deprecation messages, some in the browser console and some in terminal. Upgrading and replacing some of these has reduced this. Upgrades: - ember-collection - ember-computed-style Replacements: - ember-pluralize replaced with ember-inflector - ember-cli-format-number replaced with custom helper using standard `toLocaleString` Removing ember-cli-format-number also meant some further changes related to decimal places in the tomography graph, done using `toFixed` The ExternalSources background-images have also now been escaped correctly preventing in-development `console` warnings. The only deprecation warnings are now from ember-block-slots, only in terminal, making for a better development experience overall, especially now we have an empty browser console Also adds a `callIfType` 'helper util' which is a util specifically for helpers (it conforms to a helper argument signature) to be expanded upon later.
6 years ago
import { helper } from '@ember/component/helper';
import callIfType from 'consul-ui/utils/helpers/call-if-type';
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString
export function toLocaleString(num, options) {
// TODO: If I make locale configurable use an option
// not mutiple arguments
return num.toLocaleString(undefined, options);
}
export default helper(callIfType('number')(toLocaleString));