SHELL = bash
GOTOOLS = \
github.com/elazarl/go-bindata-assetfs/... \
github.com/hashicorp/go-bindata/... \
github.com/magiconair/vendorfmt/cmd/vendorfmt \
github.com/mitchellh/gox \
golang.org/x/tools/cmd/cover \
golang.org/x/tools/cmd/stringer \
github.com/axw/gocov/gocov \
gopkg.in/matm/v1/gocov-html
GOTAGS ?=
GOFILES ?= $( shell go list ./... | grep -v /vendor/)
i f e q ( $( origin GOTEST_PKGS_EXCLUDE ) , u n d e f i n e d )
GOTEST_PKGS ?= "./..."
e l s e
GOTEST_PKGS = $( shell go list ./... | sed 's/github.com\/hashicorp\/consul/./' | egrep -v " ^( $( GOTEST_PKGS_EXCLUDE) ) $$ " )
e n d i f
GOOS = $( shell go env GOOS)
GOARCH = $( shell go env GOARCH)
GOPATH = $( shell go env GOPATH)
ASSETFS_PATH ?= agent/bindata_assetfs.go
# Get the git commit
GIT_COMMIT ?= $( shell git rev-parse --short HEAD)
GIT_DIRTY ?= $( shell test -n "`git status --porcelain`" && echo "+CHANGES" || true )
GIT_DESCRIBE ?= $( shell git describe --tags --always)
GIT_IMPORT = github.com/hashicorp/consul/version
GOLDFLAGS = -X $( GIT_IMPORT) .GitCommit= $( GIT_COMMIT) $( GIT_DIRTY) -X $( GIT_IMPORT) .GitDescribe= $( GIT_DESCRIBE)
i f e q ( $( FORCE_REBUILD ) , 1 )
NOCACHE = --no-cache
e l s e
NOCACHE =
e n d i f
DOCKER_BUILD_QUIET ?= 1
i f e q ( $ { D O C K E R _ B U I L D _ Q U I E T } , 1 )
QUIET = -q
e l s e
QUIET =
e n d i f
CONSUL_DEV_IMAGE ?= consul-dev
GO_BUILD_TAG ?= consul-build-go
UI_BUILD_TAG ?= consul-build-ui
UI_LEGACY_BUILD_TAG ?= consul-build-ui-legacy
BUILD_CONTAINER_NAME ?= consul-builder
DIST_TAG ?= 1
DIST_BUILD ?= 1
DIST_SIGN ?= 1
i f d e f D I S T _ V E R S I O N
DIST_VERSION_ARG = -v " $( DIST_VERSION) "
e l s e
DIST_VERSION_ARG =
e n d i f
i f d e f D I S T _ R E L E A S E _ D A T E
DIST_DATE_ARG = -d " $( DIST_RELEASE_DATE) "
e l s e
DIST_DATE_ARG =
e n d i f
i f d e f D I S T _ P R E R E L E A S E
DIST_REL_ARG = -r " $( DIST_PRERELEASE) "
e l s e
DIST_REL_ARG =
e n d i f
PUB_GIT ?= 1
PUB_WEBSITE ?= 1
i f e q ( $( PUB_GIT ) , 1 )
PUB_GIT_ARG = -g
e l s e
PUB_GIT_ARG =
e n d i f
i f e q ( $( PUB_WEBSITE ) , 1 )
PUB_WEBSITE_ARG = -g
e l s e
PUB_WEBSITE_ARG =
e n d i f
export GO_BUILD_TAG
export UI_BUILD_TAG
export UI_LEGACY_BUILD_TAG
export BUILD_CONTAINER_NAME
export GIT_COMMIT
export GIT_DIRTY
export GIT_DESCRIBE
export GOTAGS
export GOLDFLAGS
# all builds binaries for all targets
all : bin
bin : tools dev -build
# dev creates binaries for testing locally - these are put into ./bin and $GOPATH
dev : changelogfmt vendorfmt dev -build
dev-build :
@$( SHELL) $( CURDIR) /build-support/scripts/build-local.sh
dev-docker :
@docker build -t '$(CONSUL_DEV_IMAGE)' --build-arg 'GIT_COMMIT=$(GIT_COMMIT)' --build-arg 'GIT_DIRTY=$(GIT_DIRTY)' --build-arg 'GIT_DESCRIBE=$(GIT_DESCRIBE)' -f $( CURDIR) /build-support/docker/Consul-Dev.dockerfile $( CURDIR)
vendorfmt :
@echo "--> Formatting vendor/vendor.json"
test -x $( GOPATH) /bin/vendorfmt || go get -u github.com/magiconair/vendorfmt/cmd/vendorfmt
vendorfmt
changelogfmt :
@echo "--> Making [GH-xxxx] references clickable..."
@sed -E 's|([^\[])\[GH-([0-9]+)\]|\1[[GH-\2](https://github.com/hashicorp/consul/issues/\2)]|g' CHANGELOG.md > changelog.tmp && mv changelog.tmp CHANGELOG.md
# linux builds a linux package independent of the source platform
linux :
@$( SHELL) $( CURDIR) /build-support/scripts/build-local.sh -o linux -a amd64
# dist builds binaries for all platforms and packages them for distribution
dist :
@$( SHELL) $( CURDIR) /build-support/scripts/release.sh -t '$(DIST_TAG)' -b '$(DIST_BUILD)' -S '$(DIST_SIGN)' $( DIST_VERSION_ARG) $( DIST_DATE_ARG) $( DIST_REL_ARG)
publish :
@$( SHELL) $( CURDIR) /build-support/scripts/publish.sh $( PUB_GIT_ARG) $( PUB_WEBSITE_ARG)
dev-tree :
@$( SHELL) $( CURDIR) /build-support/scripts/dev.sh
cov :
gocov test $( GOFILES) | gocov-html > /tmp/coverage.html
open /tmp/coverage.html
test : other -consul dev -build vet
@echo "--> Running go test"
@rm -f test.log exit-code
go test -tags '$(GOTAGS)' -i $( GOTEST_PKGS)
@# Dump verbose output to test.log so we can surface test names on failure but
@# hide it from travis as it exceeds their log limits and causes job to be
@# terminated ( over 4MB and over 10k lines in the UI) . We need to output
@# _something_ to stop them terminating us due to inactivity...
{ go test $( GOTEST_FLAGS) -tags '$(GOTAGS)' -timeout 5m $( GOTEST_PKGS) 2>& 1 ; echo $$ ? > exit-code ; } | tee test.log | egrep '^(ok|FAIL)\s*github.com/hashicorp/consul'
@echo " Exit code: $$ (cat exit-code) " >> test.log
@grep -A5 'DATA RACE' test.log || true
@grep -A10 'panic: test timed out' test.log || true
@grep -A1 -- '--- SKIP:' test.log || true
@grep -A1 -- '--- FAIL:' test.log || true
@grep '^FAIL' test.log || true
@if [ " $$ (cat exit-code) " = = "0" ] ; then echo "PASS" ; exit 0 ; else exit 1 ; fi
test-race :
$( MAKE) GOTEST_FLAGS = -race
other-consul :
@echo "--> Checking for other consul instances"
@if ps -ef | grep 'consul agent' | grep -v grep ; then \
echo "Found other running consul agents. This may affect your tests." ; \
exit 1 ; \
fi
cover :
go test $( GOFILES) --cover
format :
@echo "--> Running go fmt"
@go fmt $( GOFILES)
Makefile: add vet target
Add a vet target in order to catch suspicious constructs
reported by go vet.
Vet has successfully detected problems in the past,
for example, see
c9333b1b9b472feb5cad80e2c8276d41b64bde88
Some vet flags are noisy. In particular, the following flags
reports a large amount of generally unharmful constructs:
```
-assign: check for useless assignments
-composites: check that composite literals used field-keyed
elements
-shadow: check for shadowed variables
-shadowstrict: whether to be strict about shadowing
-unreachable: check for unreachable code
```
In order to skip running the flags mentioned above, vet is
invoked on a directory basis with `go tool vet .` since package-
level type-checking with `go vet` doesn't accept flags.
Hence, each file is vetted in isolation, which is weaker than
package-level type-checking. But nevertheless, it might catch
suspicious constructs that pose a real issue.
The vet target runs the following flags on the entire repo:
```
-asmdecl: check assembly against Go declarations
-atomic: check for common mistaken usages of the
sync/atomic package
-bool: check for mistakes involving boolean operators
-buildtags: check that +build tags are valid
-copylocks: check that locks are not passed by value
-methods: check that canonically named methods are canonically
defined
-nilfunc: check for comparisons between functions and nil
-printf: check printf-like invocations
-rangeloops: check that range loop variables are used correctly
-shift: check for useless shifts
-structtags: check that struct field tags have canonical format
and apply to exported fields as needed
-unsafeptr: check for misuse of unsafe.Pointer
```
Now and then, it might make sense to check the output of the
disabled flags manually.
For example, `VETARGS=-unreachable make vet` can detect several
lines of dead code that can be deleted, etc.
10 years ago
vet :
@echo "--> Running go vet"
@go vet -tags '$(GOTAGS)' $( GOFILES) ; if [ $$ ? -eq 1 ] ; then \
Makefile: add vet target
Add a vet target in order to catch suspicious constructs
reported by go vet.
Vet has successfully detected problems in the past,
for example, see
c9333b1b9b472feb5cad80e2c8276d41b64bde88
Some vet flags are noisy. In particular, the following flags
reports a large amount of generally unharmful constructs:
```
-assign: check for useless assignments
-composites: check that composite literals used field-keyed
elements
-shadow: check for shadowed variables
-shadowstrict: whether to be strict about shadowing
-unreachable: check for unreachable code
```
In order to skip running the flags mentioned above, vet is
invoked on a directory basis with `go tool vet .` since package-
level type-checking with `go vet` doesn't accept flags.
Hence, each file is vetted in isolation, which is weaker than
package-level type-checking. But nevertheless, it might catch
suspicious constructs that pose a real issue.
The vet target runs the following flags on the entire repo:
```
-asmdecl: check assembly against Go declarations
-atomic: check for common mistaken usages of the
sync/atomic package
-bool: check for mistakes involving boolean operators
-buildtags: check that +build tags are valid
-copylocks: check that locks are not passed by value
-methods: check that canonically named methods are canonically
defined
-nilfunc: check for comparisons between functions and nil
-printf: check printf-like invocations
-rangeloops: check that range loop variables are used correctly
-shift: check for useless shifts
-structtags: check that struct field tags have canonical format
and apply to exported fields as needed
-unsafeptr: check for misuse of unsafe.Pointer
```
Now and then, it might make sense to check the output of the
disabled flags manually.
For example, `VETARGS=-unreachable make vet` can detect several
lines of dead code that can be deleted, etc.
10 years ago
echo "" ; \
echo "Vet found suspicious constructs. Please check the reported constructs" ; \
echo "and fix them if necessary before submitting the code for review." ; \
exit 1; \
Makefile: add vet target
Add a vet target in order to catch suspicious constructs
reported by go vet.
Vet has successfully detected problems in the past,
for example, see
c9333b1b9b472feb5cad80e2c8276d41b64bde88
Some vet flags are noisy. In particular, the following flags
reports a large amount of generally unharmful constructs:
```
-assign: check for useless assignments
-composites: check that composite literals used field-keyed
elements
-shadow: check for shadowed variables
-shadowstrict: whether to be strict about shadowing
-unreachable: check for unreachable code
```
In order to skip running the flags mentioned above, vet is
invoked on a directory basis with `go tool vet .` since package-
level type-checking with `go vet` doesn't accept flags.
Hence, each file is vetted in isolation, which is weaker than
package-level type-checking. But nevertheless, it might catch
suspicious constructs that pose a real issue.
The vet target runs the following flags on the entire repo:
```
-asmdecl: check assembly against Go declarations
-atomic: check for common mistaken usages of the
sync/atomic package
-bool: check for mistakes involving boolean operators
-buildtags: check that +build tags are valid
-copylocks: check that locks are not passed by value
-methods: check that canonically named methods are canonically
defined
-nilfunc: check for comparisons between functions and nil
-printf: check printf-like invocations
-rangeloops: check that range loop variables are used correctly
-shift: check for useless shifts
-structtags: check that struct field tags have canonical format
and apply to exported fields as needed
-unsafeptr: check for misuse of unsafe.Pointer
```
Now and then, it might make sense to check the output of the
disabled flags manually.
For example, `VETARGS=-unreachable make vet` can detect several
lines of dead code that can be deleted, etc.
10 years ago
fi
# If you've run "make ui" manually then this will get called for you. This is
# also run as part of the release build script when it verifies that there are no
# changes to the UI assets that aren't checked in.
static-assets :
@go-bindata-assetfs -pkg agent -prefix pkg -o $( ASSETFS_PATH) ./pkg/web_ui/...
$( MAKE) format
# Build the static web ui and build static assets inside a Docker container
ui : ui -legacy -docker ui -docker static -assets -docker
tools :
go get -u -v $( GOTOOLS)
version :
@echo -n "Version: "
@$( SHELL) $( CURDIR) /build-support/scripts/version.sh
@echo -n "Version + release: "
@$( SHELL) $( CURDIR) /build-support/scripts/version.sh -r
@echo -n "Version + git: "
@$( SHELL) $( CURDIR) /build-support/scripts/version.sh -g
@echo -n "Version + release + git: "
@$( SHELL) $( CURDIR) /build-support/scripts/version.sh -r -g
docker-images : go -build -image ui -build -image ui -legacy -build -image
go-build-image :
@echo "Building Golang build container"
@docker build $( NOCACHE) $( QUIET) --build-arg 'GOTOOLS=$(GOTOOLS)' -t $( GO_BUILD_TAG) - < build-support/docker/Build-Go.dockerfile
ui-build-image :
@echo "Building UI build container"
@docker build $( NOCACHE) $( QUIET) -t $( UI_BUILD_TAG) - < build-support/docker/Build-UI.dockerfile
ui-legacy-build-image :
@echo "Building Legacy UI build container"
@docker build $( NOCACHE) $( QUIET) -t $( UI_LEGACY_BUILD_TAG) - < build-support/docker/Build-UI-Legacy.dockerfile
static-assets-docker : go -build -image
@$( SHELL) $( CURDIR) /build-support/scripts/build-docker.sh static-assets
consul-docker : go -build -image
@$( SHELL) $( CURDIR) /build-support/scripts/build-docker.sh consul
ui-docker : ui -build -image
@$( SHELL) $( CURDIR) /build-support/scripts/build-docker.sh ui
ui-legacy-docker : ui -legacy -build -image
@$( SHELL) $( CURDIR) /build-support/scripts/build-docker.sh ui-legacy
.PHONY : all ci bin dev dist cov test cover format vet ui static -assets tools vendorfmt
.PHONY : docker -images go -build -image ui -build -image ui -legacy -build -image static -assets -docker consul -docker ui -docker ui -legacy -docker version