Commit Graph

3032 Commits (fa09dc9115c4d34da6c5797287ee2ba61d6f162e)

Author SHA1 Message Date
Tatsuhiro Tsujikawa fa09dc9115 Clean up if defined style 2013-09-17 23:17:08 +09:00
Tatsuhiro Tsujikawa acd2af82d0 util::htmlEscape: Optimize a bit
The cause of slowness of the first implementation is the memory
allocation overhead and appending character by character.  In this
implementation, the output buffer is reserved the same size of input.
This is reasonable because most likely no replacement happens in
practice. And the unmodified region is copied using iterator range to
speed up a bit.
2013-08-29 01:09:15 +09:00
Nils Maier 75e61ee3d0 Fast-path for percentEncodeMini(string&) 2013-08-24 22:25:29 +02:00
Nils Maier b2da75ca33 Optimize htmlEscape implementation a bit 2013-08-24 21:54:56 +02:00
Nils Maier 1b8de6bb18 Add fast-path to percentEncode(string&) 2013-08-24 21:54:36 +02:00
Nils Maier 4418ebdedc AppleTLSSession: Remove unused private member 2013-08-24 20:08:15 +02:00
Nils Maier 522ae80fd4 Fix no-return warning in FtpInitiateConnectionCommand
... and untangle code a bit while at it.
2013-08-24 20:02:13 +02:00
Tatsuhiro Tsujikawa ee2e21150b Use std::unordered_map in IndexedList for faster speed
Because mingw cross compiler g++-4.6.3 does not support
std::unordered_map::emplace and std::deque::emplace, traditional
insert member function is used instead.
2013-08-21 23:46:16 +09:00
Nils Maier cf6f58ceec More code cleanups 2013-08-21 07:32:01 +02:00
Nils Maier 8526ceeb45 Convert to autos and ranged loops 2013-08-21 05:56:17 +02:00
Nils Maier d8f44ef4f6 Convert most 0/NULL pointers to nullptr
Courtesy of llvm cpp11-migrate 3.3
2013-08-20 21:28:24 +02:00
Nils Maier 9da17424c6 Fix json::decodeGetParams when compiled with recent Apple clang 2013-08-20 20:48:49 +02:00
Nils Maier 270f429838 Fix util::nextParam when compiled with recent Apple clang 2013-08-20 20:48:49 +02:00
Tatsuhiro Tsujikawa c26c1e234a Move GHR outside of function and provide ctor to suppress compiler warning
Without ctor, compiler emits warning "unused variable ghr".
2013-08-19 23:54:54 +09:00
Tatsuhiro Tsujikawa b6d84c0160 Use nullptr for std::shared_ptr and unique_ptr default parameter 2013-08-19 23:50:58 +09:00
Tatsuhiro Tsujikawa 5ba7150333 Code cleanup 2013-08-19 23:50:14 +09:00
Tatsuhiro Tsujikawa 7b04c841d6 Code cleanup 2013-08-19 23:40:28 +09:00
Tatsuhiro Tsujikawa 7f049dc2a4 Fix bad use of std::move
In the original code, std::move(cookieDomain) may be performed before
util::isNumericHost(cookieDomain), which is unintentional.
2013-08-19 23:29:08 +09:00
Nils Maier bf5a940ed4 Define a type for signal handlers 2013-08-18 06:04:20 +02:00
Nils Maier 79fcafc31f Win: Use SetConsoleCtrlHandler for SIGINT/SIGTERM 2013-08-18 06:04:20 +02:00
Nils Maier 9e25335850 Implement a simple resource lock (threading)
In this initial implementation Locks are no-ops on platforms other than
Windows.
2013-08-18 06:01:52 +02:00
Nils Maier a982dee961 Switch CA_BUNDLE to AC_DEFINE 2013-08-16 22:32:16 +02:00
Nils Maier 303f987ee9 Add --with-disk-cache configure option
Enables packagers more fine grained control over the default value
without having to mess with config files.

See GH-115
2013-08-16 22:31:56 +02:00
Nils Maier 90c39522a2 Libuv: Compatiblity fix with master 2013-08-16 22:29:14 +02:00
Nils Maier 4be7ec380f Change defaults: Enable 16M disk cache by default. 2013-08-12 20:51:19 +02:00
Tatsuhiro Tsujikawa 732ed1fb8b Fix broken XMLRPC method call 2013-08-12 10:55:50 +09:00
Tatsuhiro Tsujikawa 8d62682202 Fix segmentation fault if RpcMethod::process throws exception 2013-08-04 00:02:52 +09:00
Tatsuhiro Tsujikawa de55569de5 Always save control file if --force-save is given 2013-07-28 18:07:29 +09:00
Tatsuhiro Tsujikawa 41121e09f7 Use std::unique_ptr for Metalink objects 2013-07-12 23:09:23 +09:00
Tatsuhiro Tsujikawa 59e63d956e Rewrite RPC method factory function 2013-07-11 21:50:47 +09:00
Tatsuhiro Tsujikawa 7c06b903f3 Use std::unique_ptr for ValueBase object hierarchy 2013-07-11 21:09:51 +09:00
Tatsuhiro Tsujikawa 7a57ecc5f8 DefaultBtMessageDispatcher: Remove unused members peerStorage_, pieceStorage_ 2013-07-07 23:28:51 +09:00
Tatsuhiro Tsujikawa cf8cfeefbc DHTInteractionCommand: Use std::unique_ptr for DHTConnection
Remove DHTConnection from DHTMessageReceiver because it is not used.
2013-07-07 23:28:51 +09:00
Nils Maier fc6318d23f Fix a bad std::move in HttpConnection
C++ Standard says that the order of evaluation of arguments is
unspecified. Even if it wasn't, std::move would run first, invalidating
the httpRequest smartptr, so that httpRequest->createRequest() would be
executed on the invalid ptr.
Some compilers might be smart enough to correct this error, clang XCode
Edition surely is not (not should it).
2013-07-07 14:42:36 +02:00
Tatsuhiro Tsujikawa 3f5f1e26d9 Refactor PeerInterationCommand ctor 2013-07-06 22:03:37 +09:00
Tatsuhiro Tsujikawa 3c66c18489 TrackerWatcherCommand: Use std::unique_ptr for trackerRequest_ 2013-07-06 21:00:57 +09:00
Tatsuhiro Tsujikawa 5378ed8c43 MultiUrlRequestFactory: Use std::unique_ptr for DownloadEngine 2013-07-06 19:45:01 +09:00
Tatsuhiro Tsujikawa 00e27e4fa4 DownloadEngine: Use std::unique_ptr for eventPoll_ 2013-07-06 19:39:16 +09:00
Tatsuhiro Tsujikawa f83b0fcfa3 Refactor MultiUrlRequestInfo ctor
StatCalc creation is moved to MultiUrlRequestInfo.  The summary output
is done only when PREF_QUIET is false and it is always to
global::cout(), so remove summaryOut_ and just use global::cout() in
that case. Also use std::unique_ptr for statCalc_ in DownloadEngine.
2013-07-06 19:26:30 +09:00
Tatsuhiro Tsujikawa 162c138362 BtRegistry: Use std::unique_ptr for BtObject 2013-07-06 19:09:39 +09:00
Tatsuhiro Tsujikawa cc3cd8a58b DownloadEngine: Use std::unique_ptr for btRegistry_ 2013-07-06 18:42:57 +09:00
Tatsuhiro Tsujikawa 3a3ac4ef9b DownloadEngine: Use std::unique_ptr for dnsCache_ 2013-07-06 18:38:18 +09:00
Tatsuhiro Tsujikawa 9130dc6776 DownloadEngine:: Use std::unique_ptr for webSocketSessionMan_
Notifier::addDownloadEventListener now takes pointer to
DownloadEventListener. Session holds unique_ptr to
ApiCallbackDownloadEventListener object.
2013-07-06 18:33:59 +09:00
Tatsuhiro Tsujikawa 81f46fbf92 Use CXX11_OVERRIDE 2013-07-06 18:15:09 +09:00
Tatsuhiro Tsujikawa 5c4f97b8a9 MultiUrlRequestInfo: Remove virtual from dtor 2013-07-06 18:14:36 +09:00
Tatsuhiro Tsujikawa 68f2a33355 DownloadEngine: Use std::unique_ptr for RequestGroupMan 2013-07-06 15:56:08 +09:00
Tatsuhiro Tsujikawa 697c1008f7 DownloadEngine: Use std::unique_ptr for checkIntegrityMan_, fileAllocationMan_ 2013-07-06 15:56:08 +09:00
Tatsuhiro Tsujikawa 6b397c8125 Use std::unique_ptr for CheckIntegrityEntry and FileAllocationEntry 2013-07-06 15:56:08 +09:00
Tatsuhiro Tsujikawa c9e58779e1 Use std::unique_ptr for IteratableValidator 2013-07-06 15:56:08 +09:00
Tatsuhiro Tsujikawa d3a04d10a7 DefaultPieceStorage::initStorage: Clean up 2013-07-06 15:56:08 +09:00