Tatsuhiro Tsujikawa
f55c16c7ed
Use std::unique_ptr for DHTBucketTree's left and right pointers
2014-09-13 00:49:08 +09:00
Tatsuhiro Tsujikawa
e18e8aeeaa
Support Adler32 checksum
...
Adler32 checksum is available for --checksum option and hash element
in Metalink files. Currently, we use Adler32 implementation in Zlib.
2014-09-13 00:08:07 +09:00
Tatsuhiro Tsujikawa
d91f7dc721
Use lambda
2014-09-13 00:08:07 +09:00
Tatsuhiro Tsujikawa
2807258279
Use std::make_shared and make_unique where possible, part 1
2014-09-13 00:07:21 +09:00
Tatsuhiro Tsujikawa
bee7a8317c
Update doc
2014-09-12 02:02:33 +09:00
Tatsuhiro Tsujikawa
c0b8b471ab
Fix hash function comparator
2014-09-11 23:54:17 +09:00
Nils Maier
e0d6d04fe8
WinTLS: Fix abrupt connection closing and closing in general.
...
Fixes GH-277
2014-09-10 16:26:34 +02:00
Tatsuhiro Tsujikawa
04f875e273
WinTLS: Return 0 if eof_ is true and decBuf_ is empty
2014-09-10 21:45:08 +09:00
Tatsuhiro Tsujikawa
83c78c497b
LibsslTLSSession: Treat 0 from readData as EOF
2014-09-10 21:26:06 +09:00
Tatsuhiro Tsujikawa
e7e80e5ec6
WinTLS: Fix busy loop on EOF
...
Fixes gh#277
2014-09-10 01:11:57 +09:00
Nils Maier
0f805fb962
Silence some compiler warnings in SessionSerializer.
2014-08-30 02:03:57 +02:00
Nils Maier
bd29fd2c30
Always include raw OS version number on Windows
2014-08-30 01:15:40 +02:00
Nils Maier
bc5d9e5466
Fix typo in FeatureConfig/OS detection
2014-08-30 01:03:58 +02:00
Tatsuhiro Tsujikawa
ae631513f3
Replace A2_ARRAY_LEN with constexpr arraySize
2014-08-29 23:37:31 +09:00
Tatsuhiro Tsujikawa
e74b39deaf
Fix crash in OpenedFileCounter::ensureMaxOpenFileLimit()
...
The crash happens if PieceStorage and/or DiskAdaptor are not
initialized in one of active RequestGroups.
2014-07-30 22:31:48 +09:00
Tatsuhiro Tsujikawa
bd0a3960df
mingw32: Fix bug that aria2 does not read piped stdin
2014-07-30 00:38:45 +09:00
Tatsuhiro Tsujikawa
c659fe939d
Fix std::length_error when no_proxy is used
...
This is regression introduced in 8cada497
.
2014-07-26 16:12:10 +09:00
Nils Maier
8732a24433
Try to set sane limits for RLIMIT_NO_FILE
...
E.g. on OSX the default is 256, which isn't exactly compatible with
torrent downloads.
Closes GH-257
2014-07-22 21:58:31 +02:00
Nils Maier
70a80b1455
Remove request pre-authorization again
2014-07-22 21:58:30 +02:00
Nils Maier
8f2af33b6d
Delay auth failures instead of PBKDF2
...
Closes GH-256
2014-07-22 21:58:30 +02:00
diadistis
9b1667fe81
Fixed segfault unsupported encodings
2014-07-20 18:06:09 +03:00
Tatsuhiro Tsujikawa
d69764879e
Fix regression 100% CPU utility when -V is used and download is multi-file BT
...
This is regression of a3426821c8
2014-07-20 18:36:52 +09:00
Tatsuhiro Tsujikawa
b611cd2bdc
UnknownLengthPieceStorage: Use std::make_shared
2014-07-15 23:48:32 +09:00
Tatsuhiro Tsujikawa
a6b7bd0342
Show bitfield for unknown length download in aria2.tellStatus RPC method
...
Generally, bitfield is not available for download whose total length
is unknown. We create bitfield when download is completed (usually
connection EOF) so that we can use it to show additional info in RPC
aria2.tellStatus response. Specifically, bitfield is now shown. And
completedLength under files key (or completedLength in
aria2.getFiles() response) is correctly shown.
2014-07-15 23:36:10 +09:00
Tatsuhiro Tsujikawa
98681552fc
Fix compile error on big endian platform
2014-07-14 21:32:48 +09:00
Tatsuhiro Tsujikawa
04caefa406
Fix test failure with --enable-libaria2
2014-07-14 00:06:32 +09:00
Tatsuhiro Tsujikawa
7fbd8a50ef
Fix compile error and warning with clang
2014-07-12 17:44:43 +09:00
Tatsuhiro Tsujikawa
3aaa5a7344
Fix file length information in RPC response when length > 2GB is unknown
...
This commit fixes the bug that aria2.tellStopped RPC method returns
total length and completedLength as 0 when file size is unknown in
advance and turns out > 2GB in the end. This commit and addresses the
performance degradation in this case.
2014-07-12 17:01:46 +09:00
Nils Maier
84bd18b9a1
Merge crypto_* from upstream
...
Revert "Fix typo"
This reverts commit 4dfd8b8847
.
Revert "MinGW: Fix compiler warning with -Wstrict-aliasing"
This reverts commit 897f0e87f4
.
2014-07-11 04:11:03 +02:00
Tatsuhiro Tsujikawa
897f0e87f4
MinGW: Fix compiler warning with -Wstrict-aliasing
...
The error message is:
warning: dereferencing type-punned pointer will break strict-aliasing
rules [-Wstrict-aliasing]
2014-07-10 00:28:16 +09:00
Tatsuhiro Tsujikawa
4dfd8b8847
Fix typo
2014-07-10 00:28:06 +09:00
Tatsuhiro Tsujikawa
852f2fb99a
MinGW: Fix compiler warning about winsock2.h and windows.h
...
This commit fixes following compiler warning with mingw compiler:
In file included from common.h:63:0,
from util_security.h:42,
from util_security.cc:36:
/usr/share/mingw-w64/include/winsock2.h:15:2: warning: #warning
Please include winsock2.h before windows.h [-Wcpp]
#warning Please include winsock2.h before windows.h
2014-07-10 00:04:28 +09:00
Tatsuhiro Tsujikawa
a3426821c8
MultiDiskAdaptor: Handle short read
2014-07-02 00:05:44 +09:00
Tatsuhiro Tsujikawa
8750d7be99
Disard cache when checking checksum
...
This will slow down checksum checking but does not thrash cache.
2014-07-02 00:05:43 +09:00
Nils Maier
0b6501043a
Compat with libuv 0.11 (Unstable)
...
Fixes #241
2014-07-01 13:48:19 +02:00
Nils Maier
0c8a2659ea
Drop WinMessageDigestImpl.
...
The algorithms the `CryptProv` on Windows supports does not currently
include SHA-224, so there is a "dark spot" in this implementation. Also
on Win XP < SP3, most of the SHA-2 family is not actually supported.
All other implementation provide support for MD5, SHA-1 and all of the
SHA-2 family, hence drop the incomplete WinMessageDigest implementation
in favor of any other supported implementation (at least the internal
implementation is always available at compile-time).
2014-06-24 20:45:12 +02:00
Nils Maier
8587669995
Fix big endianess support in InternalMessageDigest and PBKDF2
...
- Replace sha1/md5 implementation by ones from https://github.com/nmaier/crypto
- Add endianess functionality fro https://github.com/nmaier/crypto
Closes GH-239
2014-06-24 20:45:05 +02:00
Tatsuhiro Tsujikawa
06a8bf6e0a
Pause download only when RPC is enabled
2014-06-21 00:58:21 +09:00
Tatsuhiro Tsujikawa
e2932608fc
Add --pause-metadata option
...
This option pauses downloads created as a result of metadata
download. There are 3 types of metadata downloads in aria2: (1)
downloading .torrent file. (2) downloading torrent metadata using
magnet link. (3) downloading metalink file. These metadata downloads
will generate downloads using their metadata. This option pauses these
subsequent downloads.
2014-06-21 00:58:21 +09:00
Nils Maier
2b02fac2d5
Improve compiler/platform/libs information in logs
...
Add and use usedCompilerAndPlatform(). This adds compiler information to
INFO logs and the --version output, and may be helpful when trying to
diagnose/reproduce user-reported problems.
Also make INFO logs include usedLibs() output.
Closes #235
2014-06-10 11:28:34 +02:00
Tatsuhiro Tsujikawa
570bc24fb9
Fix use-after-free on exit with multi-file torrent download + DHT
...
DefaultPieceStorage may be referenced by one of DHT task (e.g.,
DHTPeerLookupTask), after RequestGroup was deleted, and even after
RequestGroupMan was deleted. DefaultPieceStorage has a reference to
MultiDiskAdaptor which calls RequestGroupMan object on destruction.
So when DHT task is destroyed, DefaultPieceStorage is destroyed, which
in turn destroys MultiDiskAdaptor. DHT task is destroyed after
RequestGroupMan was destroyed, MultiDiskAdaptor will use now freed
RequestGroupMan object, this is use-after-free.
2014-06-08 17:03:34 +09:00
Tatsuhiro Tsujikawa
442e460055
Fix bug that zero length file is not opened when flushing cache
...
This bug was only seen when MultiDiskAdaptor was used.
2014-06-08 16:43:22 +09:00
Tatsuhiro Tsujikawa
e2ff45f326
AnnounceList, AnnounceTier: Code cleanup using C++11 features
2014-06-06 00:04:37 +09:00
Tatsuhiro Tsujikawa
aff92b5115
SocketRecvBuffer: Cleanup with C++11 features
2014-06-05 23:40:19 +09:00
Tatsuhiro Tsujikawa
0ee8104953
Small code cleanup for SocketBuffer
2014-06-05 23:33:58 +09:00
Tatsuhiro Tsujikawa
c0e4381780
util::parseIntSegments: Return SegList<int>
2014-06-04 23:21:01 +09:00
Tatsuhiro Tsujikawa
007b890fe4
bittorrent::computeFastSet: Return std::vector
2014-06-04 22:50:39 +09:00
Tatsuhiro Tsujikawa
d1d5ea5b21
DownloadContext, FileEntry: Use move semantics to path parameter in ctor
2014-06-04 22:43:29 +09:00
Tatsuhiro Tsujikawa
9b54272190
FileEntry::getUris: Return std::vector<std::string>
2014-06-04 22:33:46 +09:00
Tatsuhiro Tsujikawa
4f3c526dcd
Support PREF_DIR change for Metalink files
...
Reworked previous commit adeead6f03
, and
now support changing PREF_DIR for Metalink downloads.
2014-06-04 21:45:12 +09:00
Tatsuhiro Tsujikawa
adeead6f03
Revert to existing "proper" coding style
...
The rule is simple: don't try to change the coding style of the
existing codebase.
2014-06-03 23:41:30 +09:00
Tatsuhiro Tsujikawa
83f4bced07
Fix assertion failure when dir option of paused HTTP/FTP download is changed
...
When the directory is changed via aria2.changeOption RPC method, we
directly change first FileEntry's path using FileEntry::setPath(). If
there is no PREF_OUT option is given, basically file name is unknown,
so we just set empty string and let the next run determine the correct
file name and new directory is applied there. But previous code does
not reset length property of FileEntry, so the unexpected code path is
taken when unpaused and its path expects path is not empty string.
This commit fixes this issue by setting length to 0 using
FileEntry::setLength().
2014-06-03 23:09:28 +09:00
Tatsuhiro Tsujikawa
631f37433a
Save session only when there is change since the last serialization
...
This is a slight optimization not to cause useless disk access. This
only applies to saving session automatically (see
--save-session-interval). aria2.saveSession and serialization at the
end of the session are always performed as before.
When serialization, we first check that whether there is any change
since the last serialization. To do this, we first calculate hash
value of serialized content without writing into file. Then compare
this value to the value of last serialization. If they do not match,
perform serialization.
2014-05-31 16:19:57 +09:00
Tatsuhiro Tsujikawa
998fba3264
Revert "Save session only when there is change since the last serialization"
...
This reverts commit 1944d8db58
.
2014-05-31 15:28:26 +09:00
Tatsuhiro Tsujikawa
1944d8db58
Save session only when there is change since the last serialization
...
This is a slight optimization not to cause useless disk access. This
only applies to saving session automatically (see
--save-session-interval). aria2.saveSession and serialization at the
end of the session are always performed as before.
2014-05-30 23:20:13 +09:00
Nils Maier
d2e38aab36
Use _setmode to set binary mode in mingw
...
The _CRT_fmode stuff was never working correctly anyway, and is entirely
unsupported in mingw-w64 these days, it seems.
2014-05-29 19:38:34 +02:00
Nils Maier
3c55400d23
Silence deprecation warning about daemon() on OSX
2014-05-29 19:38:34 +02:00
Nils Maier
b9fe4119c0
New round of clang-modernize
2014-05-29 19:38:34 +02:00
Nils Maier
c8ccb43428
Consistent style in util_security
2014-05-29 19:38:34 +02:00
Nils Maier
77f0f1395c
Consistent style in the platform TLS implementations
2014-05-29 19:38:33 +02:00
Nils Maier
8cada49765
Cleanup AbstractCommand take 2
...
Decided to keep the 'if(' -> 'if (' stuff, as I formatted the whole file
and so it is internally consistent within the file. Also, too much
hassle.
2014-05-29 18:39:53 +02:00
Nils Maier
e57d330111
Cleanup HttpHeaderProcessor take 2
...
Decided to keep the 'if(' -> 'if (' stuff, as I formatted the whole file
and so it is internally consistent within the file. Also, too much
hassle.
2014-05-29 18:29:37 +02:00
Nils Maier
48ec56a64d
Revert "Cleanup HttpHeaderProcessor::parse"
...
This reverts commit 047b49b7a0
.
2014-05-29 18:29:37 +02:00
Nils Maier
6240345fd5
Revert "Cleanup AbstractCommand"
...
This reverts commit 0465aa5455
.
2014-05-29 18:29:37 +02:00
Nils Maier
0465aa5455
Cleanup AbstractCommand
...
In my quest to explore the code and understand it, why not clean it up
in the progress. Most formatting provided by clang-format. ;)
Aside from formatting, also extracted some method and unnested some
control structs.
2014-05-27 21:37:15 +02:00
Nils Maier
6e546245e4
Sort and cleanup src/Makefile.am
2014-05-27 21:35:42 +02:00
Nils Maier
047b49b7a0
Cleanup HttpHeaderProcessor::parse
2014-05-27 19:46:54 +02:00
Nils Maier
d72df551ba
Document setUri() in FileEntry does not need to check the return value.
2014-05-27 19:10:14 +02:00
Nils Maier
15cb9e12b2
Remove unused variable in LibgcryptMessageDigestImpl
2014-05-27 19:10:14 +02:00
Nils Maier
fd8dc921fe
Initialize DownloadEngine::tokenAverageDuration_ to something.
2014-05-27 19:10:14 +02:00
Nils Maier
f8db60e54e
OSX: Use F_NOCACHE instead of F_GLOBAL_NOCACHE
...
The latter persists for the lifetime of the file, while the former
affects only the current descriptor.
2014-05-26 21:34:49 +02:00
Nils Maier
dd8e4b0ad0
Remove spurious CXX11_OVERRIDE to make cov-build happy.
2014-05-26 01:34:26 +02:00
Nils Maier
a82f08765e
Fix (unknown length) downloads larger than 2GiB
...
Closes #215
2014-05-25 14:49:29 +02:00
Nils Maier
64b1fefb78
Add missing include in util_security.h
...
Fixes #231
2014-05-23 18:44:10 +02:00
Nils Maier
f7cc24d6cf
Internally use HMAC in http auth
...
To at least get constant time compare.
Also fix incorrect parsing of the creds (were incorrectly stripped).
Also add unit tests.
2014-05-22 15:24:20 +02:00
Nils Maier
d02ee723bd
Improve aria2.rst and usage texts a bit.
...
(Keep in mind that I'm not a native speaker either)
- Fix some typos.
- Fix some grammar stuff.
- Clarify some things.
- Add a new paragraph or two...
2014-05-20 18:02:47 +02:00
Nils Maier
855dfa0e2f
Authorize RPC multicalls only once.
...
Cache the auth status afterwards and just assume the token still matches
(within the same request, of course).
2014-05-20 12:53:39 +02:00
Nils Maier
88b61f2eb9
Adjust RPC token processing time
...
Make it consume a bit less time.
2014-05-20 12:53:38 +02:00
Nils Maier
bb50de1336
Improve write cache failures error reporting
2014-05-20 12:52:26 +02:00
Nils Maier
5c07f0109e
Fix F_PREALLOC based allocation on some OSX versions
2014-05-08 16:40:09 +02:00
Nils Maier
1dd7409c4e
Fix unused function warning about generateRandomDataUrandom in mingw-w64
2014-05-08 16:38:32 +02:00
Nils Maier
a0f275a9f1
Remove unused function getWin32Handle
2014-05-08 16:38:32 +02:00
Tatsuhiro Tsujikawa
f60e55cece
Use index.html as filename for conditional-get when file is missing in URI
...
Previously we disabled conditional-get if file part is missing in URI.
But we use constant string "index.html" in this case, so we can do the
same to determine the modification time. In this patch, if we have
file part in URI, we are not going to set absolute file path in
FileEntry, since it prevents content-disposition from working.
2014-05-08 21:49:04 +09:00
Tatsuhiro Tsujikawa
84f1a15e10
Check negative number from Integer::i() where it is not allowed
2014-05-01 11:34:27 +09:00
Tatsuhiro Tsujikawa
4c2ad69a75
Ignore negative metadata size in extended handshake
2014-04-30 23:46:27 +09:00
Nils Maier
82dad90ff3
Validate token using PBKDF2-HMAC-SHA1.
...
This change should make token validation more resilient to:
- timing attacks (constant time array compare)
- brute-force/dictionary attacks (PBKDF2)
Closes #220
2014-04-19 19:10:06 +02:00
Nils Maier
98ba096951
Add util::security (compare, HMAC, PBKDF2)
...
See #220
2014-04-19 19:07:38 +02:00
Nils Maier
010131161e
Remove ENABLE_MESSAGE_DIGEST, since we got the internal md, always
2014-04-17 18:02:42 +02:00
Nils Maier
aa02545fba
Use mpz_pown_sec where available
2014-04-13 18:51:06 +02:00
Nils Maier
c694a05797
Fix some warnings
2014-04-13 18:51:05 +02:00
Nils Maier
18c35f56b8
AppleTLS: Enable BEAST mitigations in ST
...
Only available in 10.9+, but since we might be building on a previous
version but running on 10.9+, always try to set the option.
2014-04-13 18:51:05 +02:00
Nils Maier
e195dc5f00
AppleTLS: Update cipher suites
...
Also make the suite selection more sane.
2014-04-13 18:51:05 +02:00
Nils Maier
39d66bd560
WinTLS: Improve error reporting
2014-04-13 18:51:05 +02:00
Nils Maier
51beb4bfa7
WinTLS: Move some defines out of the header
2014-04-13 18:51:04 +02:00
Nils Maier
219fd5b4b7
WinTLS: Make ca-file rejection a warning
2014-04-13 18:51:04 +02:00
Nils Maier
8d55e30561
WinTLS: Use SCH_USE_STRONG_CRYPTO
...
See: #217
2014-04-13 18:50:54 +02:00
Nils Maier
0a51b8d172
WinTLS: Accept chains with no revocation information.
...
This is kind what browser do anyway (IE, Firefox, Chrome tested), what
AppleTLS does, what GnuTLS does and what OpenSSL does. Actually, most
browsers will also be OK with the CRL/OCSP provider being offline.
WinTLS will still fail in that case.
Should revocation information be available in the trust chain (CRL or
OCSP) the certificate still will be checked!
"Real" CAs, aka. those provided by the OS or system CA bundle, usually
provide revocation information and are thus still checked.
It should be mostly (only?) custom (organization) CAs that lack
revocation information, but those users might want to use aria2 in their
intranets and VPNs anyway ;)
See #217
2014-04-13 18:50:38 +02:00
Nils Maier
13a202df07
Fix GnuTLS 2.x compatiblity
...
Closes GH-216
2014-04-12 02:55:31 +02:00
Nils Maier
2d9bf0f374
AppleTLS: Use newer, non-deprecated API in 10.8+
2014-04-12 02:55:31 +02:00
Nils Maier
7600886d3d
Implement falloc equivalent in OSX
2014-04-12 02:55:31 +02:00
Tatsuhiro Tsujikawa
f0473dc34d
Ignore error when setting DSCP value
...
Setting DSCP is additional feature and failure to enable it should not
abort download entirely. This change fixes the bug that windows build
does not perform bittorrent downloads.
2014-03-30 14:14:28 +09:00
Tatsuhiro Tsujikawa
551adc5133
mingw: Undef localtime_r and asctime_r
2014-03-24 01:11:30 +09:00
Tatsuhiro Tsujikawa
1188e4f1a2
Fix mingw32 build with gcc 4.8.2
...
Now mingw-w64 C++ compiler defines __USE_MINGW_ANSI_STDIO to 1, we
have to follow it as well. We hope that mingw version of stdio
function behaves like Linux ones. We have not tested them thoroughly
yet. pthread for windows defines its own HAVE_STRUCT_TIMESPEC macro.
To avoid warning, we rename our version of it as
HAVE_A2_STRUCT_TIMESPEC.
2014-03-24 00:37:30 +09:00
Alexander Amanuel
dccd8192a4
Added DSCP support for IPv6 sockets
2014-03-12 15:22:46 +04:00
Tatsuhiro Tsujikawa
a8319a8b78
Add aria2.saveSession RPC method
...
This method saves the current session to a file specified by
--save-session option. This method returns "OK" if it succeeds.
2014-02-19 22:02:50 +09:00
Tatsuhiro Tsujikawa
1a24020e63
Don't allow empty string for --rpc-secret option
2014-02-19 21:46:06 +09:00
Tatsuhiro Tsujikawa
de4cd8b59b
Warn if neither --rpc-secret nor a combination of --rpc-user/rpc-passwd is set
2014-02-19 21:37:11 +09:00
Nils Maier
00e690a4d1
Add some missing includes to AnnounceList.h
2014-02-19 03:09:59 +01:00
Tatsuhiro Tsujikawa
1462d6536a
Add numStoppedTotal key to aria2.getGlobalStat() RPC method response
...
It shows the number of stopped downloads in the current session and
not capped by --max-download-result option. On the other hand, the
existing numStopped key also shows the number of stopped downloads,
but it is capped by --max-download-result option.
2014-02-15 19:10:48 +09:00
Tatsuhiro Tsujikawa
b18e62dba7
Treat 30X response without Location header field as error
...
This is required to make segmented download work.
2014-02-05 21:20:09 +09:00
Tatsuhiro Tsujikawa
ec4b729704
Better handling of 30X HTTP status codes
...
Reference: http://greenbytes.de/tech/tc/httpredirects/
2014-02-05 00:32:43 +09:00
Tatsuhiro Tsujikawa
06bb6d1ac0
Fix longer line in --dscp option help
2014-02-04 21:52:28 +09:00
Tatsuhiro Tsujikawa
1438933c97
Merge branch 'dscp-support' of https://github.com/iavael/aria2 into iavael-dscp-support
...
Conflicts:
src/prefs.cc
src/prefs.h
src/usage_text.h
2014-02-04 21:42:00 +09:00
Alexander Amanuel
a7182b9ee4
Improved dscp parameter description
2014-02-03 17:53:07 +04:00
Tatsuhiro Tsujikawa
7d1aa887ee
Add future deprecation warning to --rpc-user and --rpc-passwd
2014-02-02 17:58:56 +09:00
Tatsuhiro Tsujikawa
7f6987a4b4
Implement new RPC authorization using --rpc-secret option
2014-02-02 17:34:07 +09:00
Alexander Amanuel
96a77e42d1
Minor DSCP-related improvements
...
- Improved usage annotation
- Shifted DSCP value to set not whole DS field, but only it's DSCP part
2014-01-29 20:17:22 +04:00
Tatsuhiro Tsujikawa
30e4077440
Add --enable-color option to enable/disable terminal color output
2014-01-30 00:15:05 +09:00
Alexander Amanuel
46a251e346
Refactored DSCP-related code a bit
2014-01-28 23:09:21 +04:00
Alexander Amanuel
924feb12b0
Added DSCP support
2014-01-28 00:13:15 +04:00
Tatsuhiro Tsujikawa
542064c69b
gnutls: Use SECURE128 priority keyword
2014-01-13 23:11:27 +09:00
Nils Maier
c2ab2f2208
Log an error when session fails to save.
...
Instead of a notice.
2014-01-08 15:58:27 +01:00
Tatsuhiro Tsujikawa
e81dd84641
gnutls: Don't fail handshake if returned error is not fatal
2014-01-08 23:11:56 +09:00
Tatsuhiro Tsujikawa
3c789294b7
gnutls: Handle GNUTLS_E_INTERRUPTED as well as GNUTLS_E_AGAIN
2014-01-08 23:01:36 +09:00
Tatsuhiro Tsujikawa
2f02946b70
Add workaround GnuTLS bug with OCSP status extension and non-blocking socket
...
GnuTLS version 3.1.3 - 3.1.18 and 3.2.0 - 3.2.8, inclusive, has this
bug. For these versions, we disable OCSP status extension.
2014-01-08 22:53:56 +09:00
Nils Maier
4dab854e08
GnuTLS: Refine debug logging
2014-01-06 17:46:21 +01:00
Nils Maier
3194174d4b
Make GnuTLS log level dependent on the aria2 ones
...
Closes GH-180
2014-01-06 17:46:21 +01:00
Nils Maier
7777e1cb37
GnuTLS: Setup logging
2014-01-06 13:40:51 +01:00
Tatsuhiro Tsujikawa
2571bf4a36
Update copyright year to 2014
2014-01-05 20:54:52 +09:00
Tatsuhiro Tsujikawa
dcf98d519f
Fix crash if unpause failed before assigning BtProgressInfoFile object
2014-01-05 20:41:19 +09:00
Tatsuhiro Tsujikawa
b706722c59
Fix unitest crash
2014-01-05 19:16:49 +09:00
Tatsuhiro Tsujikawa
8216bdba79
Fix bug that numOpenFile_ is not reduced when MultiDiskAdaptor is deleted
...
This bug caused assertion error in RequestGroupMan::ensureMaxOpenFileLimit
2013-12-31 22:57:11 +09:00
Nils Maier
a44c71586a
Fix crash in HttpSkipResponseCommand ctor
...
(Regression from the memory holes stuff; missed to commit :p)
2013-12-24 23:14:26 +01:00
Tatsuhiro Tsujikawa
c881f9fcad
Run DHT if torrent is private; but don't use DHT for that torrent
2013-12-20 21:39:30 +09:00
Tatsuhiro Tsujikawa
a21a868af0
FileEntry: Pass by value for simple setter functions
2013-12-15 19:20:31 +09:00
Nils Maier
32e569ab16
Fix broken EXTRA_DIST
2013-12-09 16:38:45 +01:00
Nils Maier
2db0c81fc8
Stuff memory holes
...
Padding changes on x86_64:
- RequestGroup: 29 -> 5 bytes
- DownloadContext: 25 -> 1 bytes
- Cookie: 20 -> 4 bytes
- Command: 8 -> 0 bytes (affects many derived as well)
- HttpRequest: 20 -> 4 bytes
- DownloadCommand: 18 -> 2 bytes
- TimeBasedCommand: 14 -> 6 bytes
- AbstractCommand: 13 -> 5 bytes
- HttpSkipResponseCommand: 12 -> 4 bytes
- FileEntry: 10 -> 2 bytes
- DownloadResult: 15 -> 7 bytes
- UriStruct: 12 -> 4 bytes
- Piece: 11 -> 3 bytes
- BitfieldMan -> 11 -> 3 bytes
2013-12-09 15:41:43 +01:00
Nils Maier
1323048ab1
Remove a dead store in Piece
2013-12-09 15:41:43 +01:00
Nils Maier
ff9607d6a9
Add WinTLS to FeatureConfig::usedLibs
2013-12-09 08:28:56 +01:00
Nils Maier
766209cf2e
It is AppleTLS (everywhere else)
2013-12-09 08:28:56 +01:00
Nils Maier
6a8fb5744c
Fix warning in AppleTLS
2013-12-09 08:28:56 +01:00
Tatsuhiro Tsujikawa
705dadb32b
Fix crash when metaurl contains unsupported URI or text
2013-12-07 01:16:47 +09:00
Tatsuhiro Tsujikawa
2c566ccb68
Fix bad fork() return value handling
2013-12-06 00:40:08 +09:00
Tatsuhiro Tsujikawa
03d5b4627b
ColorizedStreamBuf::str: Append character prefix to stream directly
2013-11-23 15:34:43 +09:00
Nils Maier
80528aa9ce
Use some colors in progress reports (where available)
2013-11-21 15:42:42 +01:00
Nils Maier
87ea4904a0
Implement basic color support for the Windows console
...
Only \033[*m (SGR) is supported, with a 16+16 color terminal.
2013-11-21 15:34:34 +01:00
Nils Maier
a476fb352e
AppleTLS: Implement PKCS12 loading.
2013-11-20 10:48:15 +01:00
Tatsuhiro Tsujikawa
4d105a2686
Limit number of opened file globally with --bt-max-open-files option
...
This change changes the behavior of --bt-max-open-files. Previously,
it specifies the maximum number of opened files for each multi-file
download. Since it is more useful to limit the number globally, the
option now specifies the global limit. This change suggests that
aria2.changeOption() method now ignores --bt-max-open-files and
aria2.changeGlobalOption now reads it and dynamically change the
limit.
2013-11-17 19:33:18 +09:00
Tatsuhiro Tsujikawa
c4334ec579
Use move for XML parser
2013-11-10 20:39:31 +09:00
Tatsuhiro Tsujikawa
9e52483c04
Refactor DownloadHandlerFactory
2013-11-10 18:19:02 +09:00
Tatsuhiro Tsujikawa
ba3b823a66
Code cleanup
2013-11-10 15:36:37 +09:00
Tatsuhiro Tsujikawa
e1e6bb1ec5
Don't fail multiple concurrent dl same file if auto-file-renaming is enabled
2013-11-08 00:59:57 +09:00
Tatsuhiro Tsujikawa
2aa8e01836
Fix typo
2013-11-06 23:40:59 +09:00
Tatsuhiro Tsujikawa
9f5fdb4e10
Code cleanup
2013-11-01 22:10:24 +09:00
Tatsuhiro Tsujikawa
fd0136259c
Remove nativeToUtf8 and utf8ToNative
...
They are now not needed since we use Windows specific command-line
argument converter.
2013-11-01 22:06:13 +09:00
Tatsuhiro Tsujikawa
3a8e8f8e8a
mingw32: Use CommandLineToArgvW() and GetCommandLineW() to read cmd-line args
...
This change enables aria2 to read unicode characters in command-line.
2013-11-01 00:16:35 +09:00
Tatsuhiro Tsujikawa
b759725a61
Peer: Use std::unique_ptr for res_
2013-10-26 21:38:17 +09:00
Tatsuhiro Tsujikawa
6d2dd2ab18
DefaultPeerStorage: Code cleanup
2013-10-26 21:28:58 +09:00
Tatsuhiro Tsujikawa
234dd76cd4
DefaultPeerStorage: Add warn log when Peer::usedBy is non zero on checkoutPeer
2013-10-26 20:02:48 +09:00
Tatsuhiro Tsujikawa
12fe61820a
DefaultPeerStorage: Log origPort in checkoutPeer and returnPeer
...
Also make the log level warning when the returned peer is not found.
2013-10-26 19:58:53 +09:00
Tatsuhiro Tsujikawa
2548cd4d6e
Fix missing sha1.h and md5.h in Makefile.am
2013-10-20 19:09:49 +09:00
Tatsuhiro Tsujikawa
218dc89be9
Update doc
2013-10-20 16:04:09 +09:00
Tatsuhiro Tsujikawa
065979cda4
Remove log message "TLS else" as this function called repeatedly
2013-10-08 21:28:32 +09:00
Tatsuhiro Tsujikawa
33293bcd5a
LibsslTLSContext: Remove weak cipher suite
2013-10-08 21:26:13 +09:00
Tatsuhiro Tsujikawa
98d88ec6d5
Don't log "TLS Handshaking" twice or more
2013-10-07 23:01:51 +09:00
Tatsuhiro Tsujikawa
3080af7370
Request: Remove previousUri_
...
Historically, the previousUri_ has different meaning from referer_,
but in the course of development, they have the same value. This
change remove previousUri_ in favor of referer_.
2013-10-01 21:53:28 +09:00
Nils Maier
3b35887827
WinTLS: Enable --certifcate support
2013-09-30 16:37:09 +02:00
Nils Maier
3b9a385305
AppleTLS: Enable --certificate
...
Tested against self-signed CA with nginx
2013-09-30 16:37:01 +02:00
Nils Maier
4c84af31be
WinTLS: Fix PKCS12 loading
...
It appears that, contrary to most documentation, CERT_CONTEXT* is eaten
alive by AcquireCredentialsHandle(). Hence you cannot really reuse that.
2013-09-30 16:36:15 +02:00
Tatsuhiro Tsujikawa
50ac6afe36
util.cc: Remove uselss inline static
2013-09-30 21:50:51 +09:00
Tatsuhiro Tsujikawa
b772aa6a5e
util::percentEncodeMini: Fix regression bug removed unsignedness
...
srange-based for around std::string is convenient but several
functions depend unsigned char for correctness and readability.
2013-09-30 21:32:57 +09:00
Nils Maier
00dd83b461
Implement WinTLS
2013-09-30 13:53:21 +02:00
Nils Maier
3f1d293ed1
WinMessgeDigestImpl: gcc-4.6 does not support .emplace() yet
2013-09-29 15:47:22 +02:00
Tatsuhiro Tsujikawa
40e53de908
MessageDigestImpl.h: Simplify hash_info_t access
2013-09-28 23:40:06 +09:00
Tatsuhiro Tsujikawa
6f6a17bff7
Randomizer: Remove unused interfaces
2013-09-28 22:55:05 +09:00
Tatsuhiro Tsujikawa
986f69e5bf
SimpleRandomizer: Use std::random
2013-09-28 22:00:37 +09:00
Tatsuhiro Tsujikawa
44479c910e
Log exception; throw error if loading private key and/or certificate failed
2013-09-26 00:56:23 +09:00
Tatsuhiro Tsujikawa
7f18494a8c
SimpleRandmizer: Fix certain bits generated by getRandomBytes are always 0
...
This is because in Linux RAND_MAX is 2**31-1 and we used int32_t to
hold random number from random() and got each bytes. This means that
highest bit is always unset. In little endian system, every 4n-th (n
>=0) byte has highest bit is unset. To fix this, we just use lower 2
bytes of random().
2013-09-26 00:41:33 +09:00
Tatsuhiro Tsujikawa
ac996737e5
Move OpenSSL_add_all_algorithms() to Platform::setUp()
2013-09-26 00:17:59 +09:00
Tatsuhiro Tsujikawa
d7d5e8570b
Include prefs.h instead of typedef PrefPtr everywhere
2013-09-26 00:15:18 +09:00
Tatsuhiro Tsujikawa
8536f13cff
uri.cc: Use auto instead of adhoc typedef
2013-09-26 00:15:18 +09:00
Tatsuhiro Tsujikawa
d2af91ed08
InternalDHKeyExchange: Remove unused dtor
2013-09-26 00:13:25 +09:00
Tatsuhiro Tsujikawa
da278225c1
InternalARC4Encryptor: Fix compiler warning and remove no use ctor/dtor
2013-09-26 00:11:10 +09:00
Tatsuhiro Tsujikawa
f2a1d241c2
Merge branch 'master' into bignum-arc4
2013-09-26 00:00:24 +09:00
Tatsuhiro Tsujikawa
c81fd8e194
InternalMessageDigestImpl: Fix memory leak
2013-09-25 23:58:59 +09:00
Tatsuhiro Tsujikawa
7dc5567cad
InternalMessageDigestImpl: Code cleanup
2013-09-25 23:57:03 +09:00
Tatsuhiro Tsujikawa
77b7747ca8
Ensure that Commands are cleaned up before RequestGroupMan is deleted
2013-09-25 23:35:18 +09:00
Tatsuhiro Tsujikawa
ca8ac6e7d3
bignum.h: Fix compile error
2013-09-25 22:43:48 +09:00
Tatsuhiro Tsujikawa
6198b607e9
Merge branch 'master' into bignum-arc4
2013-09-25 21:55:32 +09:00
Nils Maier
99f170b888
Provide internal ARC4 implementation
...
Now you can build bittorrent support without without external
libraries, meaning you can skip libnettle, libgmp, libgcrypt, GnuTLS and
OpenSSL on OSX (for now).
2013-09-24 19:11:26 +02:00
Nils Maier
e854463b2d
Internal implementation of DHKeyExchange
...
Reusing a bignum (well, unsigned very-long) implementation I had lying
around for years and just cleaned up a bit and brought to C++11 land.
It might not be the most performant implementation, but it shoud be fast
enough for our purposes and will go a long way of removing gcrypt,
nettle, gmp, openssl dependencies when using AppleTLS and WinTLS
(upcoming).
2013-09-24 19:11:00 +02:00
Nils Maier
86c61fcf5b
Make generateRandomBytes less biased.
2013-09-24 19:07:18 +02:00
Nils Maier
e5644a7188
Revert OptionHandlerFactory changes
2013-09-24 16:17:15 +02:00
Nils Maier
d1ae9f87fd
using to typedef to make gcc-4.6 happy
2013-09-24 16:14:35 +02:00
Nils Maier
4a1d186962
Better error messages when PKCS12 import fails
2013-09-24 01:05:58 +02:00
Nils Maier
063451f0c9
TLS: Minor code cleanups
2013-09-23 15:43:11 +02:00
Nils Maier
d560bf0e6f
TLS: Fix dangling str() pointers
2013-09-23 15:10:53 +02:00
Nils Maier
37f9c668ff
Teach GnuTLS backend to load .p12 files
2013-09-22 12:55:27 +02:00
Nils Maier
f7b0fbbf53
Teach Libssl backend to load .p12 files
2013-09-22 12:55:27 +02:00
Nils Maier
38bdea4e06
Add internal md5 and sha1 message digests
2013-09-20 23:06:50 +02:00