Fixed invalid connection count

src/CheckIntegrityCommand.cc

@@ -61,8 +61,7 @@ bool CheckIntegrityCommand::executeInternal()
       return true;
     }
     if(_requestGroup->needsFileAllocation()) {
-      FileAllocationEntryHandle entry = new FileAllocationEntry(cuid, _entry->getCurrentRequest(), _requestGroup, _requestGroup->getExistingFileLength());
+      FileAllocationEntryHandle entry = new FileAllocationEntry(cuid, _entry->getCurrentRequest(), _requestGroup, _entry->popNextDownloadCommand(), _requestGroup->getExistingFileLength());
-      entry->setNextDownloadCommand(_entry->popNextDownloadCommand());
       _e->_fileAllocationMan->pushFileAllocationEntry(entry); 
     } else {
       if(_timer.difference() <= _e->option->getAsInt(PREF_DIRECT_DOWNLOAD_TIMEOUT) &&

src/CheckIntegrityEntry.h

@@ -44,8 +44,9 @@ private:
 public:
   CheckIntegrityEntry(int cuid,
 		      const RequestHandle& currentRequest,
-		      RequestGroup* requestGroup):
+		      RequestGroup* requestGroup,
-    RequestGroupEntry(cuid, currentRequest, requestGroup),
+		      DownloadCommand* nextDownloadCommand = 0):
+    RequestGroupEntry(cuid, currentRequest, requestGroup, nextDownloadCommand),
     _validator(0)
   {}
 

src/FileAllocationEntry.h

@@ -44,8 +44,9 @@ public:
   FileAllocationEntry(int cuid,
 		      const RequestHandle& currentRequest,
 		      RequestGroup* requestGroup,
+		      DownloadCommand* nextDownloadCommand = 0,
 		      int64_t offset = 0):
-    RequestGroupEntry(cuid, currentRequest, requestGroup),
+    RequestGroupEntry(cuid, currentRequest, requestGroup, nextDownloadCommand),
     _offset(offset)
   {}
 

src/RequestGroup.cc

@@ -227,16 +227,14 @@ void RequestGroup::prepareForNextAction(int cuid, const RequestHandle& req, Down
     // purge SegmentEntries
     _segmentMan->purgeSegmentEntry();
 
-    CheckIntegrityEntryHandle entry = new CheckIntegrityEntry(cuid, req, this);
+    CheckIntegrityEntryHandle entry = new CheckIntegrityEntry(cuid, req, this, downloadCommand);
-    entry->setNextDownloadCommand(downloadCommand);
     entry->initValidator();
     CheckIntegrityCommand* command = new CheckIntegrityCommand(cuid, this, e, entry);
     e->commands.push_back(command);
   } else
 #endif // ENABLE_MESSAGE_DIGEST
     if(needsFileAllocation()) {
-      FileAllocationEntryHandle entry = new FileAllocationEntry(cuid, req, this, existingFile.size());
+      FileAllocationEntryHandle entry = new FileAllocationEntry(cuid, req, this, downloadCommand, existingFile.size());
-      entry->setNextDownloadCommand(downloadCommand);
       e->_fileAllocationMan->pushFileAllocationEntry(entry);
     } else {
       if(downloadCommand) {

src/RequestGroupEntry.cc

@@ -37,6 +37,8 @@
 
 RequestGroupEntry::~RequestGroupEntry()
 {
+  if(_shouldAddNumConnection) {
     --_requestGroup->numConnection;
+  }
   delete _nextDownloadCommand;
 }

src/RequestGroupEntry.h

@@ -47,17 +47,24 @@ protected:
   RequestHandle _currentRequest;
   RequestGroup* _requestGroup;
   DownloadCommand* _nextDownloadCommand;
+  bool _shouldAddNumConnection;
 public:
   RequestGroupEntry(int cuid,
 		    const RequestHandle& currentRequest,
-		    RequestGroup* requestGroup):
+		    RequestGroup* requestGroup,
+		    DownloadCommand* nextDownloadCommand = 0):
     _cuid(cuid),
     _currentRequest(currentRequest),
     _requestGroup(requestGroup),
-    _nextDownloadCommand(0)
+    _nextDownloadCommand(nextDownloadCommand)
   {
+    if(nextDownloadCommand) {
+      _shouldAddNumConnection = false;
+    } else {
+      _shouldAddNumConnection = true;
       ++_requestGroup->numConnection;
     }
+  }
 
   virtual ~RequestGroupEntry();
 
@@ -80,12 +87,12 @@ public:
   {
     return _requestGroup;
   }
-
+  /*
   void setNextDownloadCommand(DownloadCommand* command)
   {
     _nextDownloadCommand = command;
   }
-
+  */
   DownloadCommand* getNextDownloadCommand() const
   {
     return _nextDownloadCommand;

src/UriFileListParser.cc

@@ -37,13 +37,13 @@
 
 bool UriFileListParser::hasNext() const
 {
-  return _ifs;
+  return *_ifs;
 }
 
 Strings UriFileListParser::next()
 {
   string line;
-  while(getline(_ifs, line)) {
+  while(getline(*_ifs, line)) {
     if(Util::trim(line) != "") {
       Strings uris;
       Util::slice(uris, line, '\t', true);

src/UriFileListParser.h

@@ -41,9 +41,22 @@
 class UriFileListParser {
 private:
   string _filename;
-  ifstream _ifs;
+  istream* _ifs;
+  bool _deleteOnExit;
 public:
-  UriFileListParser(const string& filename):_filename(filename), _ifs(filename.c_str()) {}
+  UriFileListParser(const string& filename):_filename(filename), _ifs(new ifstream(filename.c_str())), _deleteOnExit(true) {}
+
+  UriFileListParser():_ifs(0) {}
+
+  UriFileListParser(istream& ifs):_filename("-"), _ifs(&ifs), _deleteOnExit(false)
+  {}
+
+  ~UriFileListParser()
+  {
+    if(_deleteOnExit) {
+      delete _ifs;
+    }
+  }
 
   bool hasNext() const;
 

src/main.cc

@@ -52,6 +52,7 @@
 #include "UriFileListParser.h"
 #include "CookieBoxFactory.h"
 #include "a2algo.h"
+#include "message.h"
 #include <deque>
 #include <algorithm>
 #include <time.h>
@@ -211,7 +212,8 @@ void showUsage() {
   cout << _(" -n, --no-netrc               Disables netrc support.") << endl;
   cout << _(" -i, --input-file=FILE        Downloads URIs found in FILE. You can specify\n"
 	    "                              multiple URIs for a single entity: deliminate\n"
-	    "                              URIs by Tab in a single line.") << endl;
+	    "                              URIs by Tab in a single line.\n"
+	    "                              Reads input from stdin when '-' is specified.") << endl;
   cout << _(" -j, --max-concurrent-downloads=N Set maximum number of concurrent downloads.\n"
 	    "                              It should be used with -i option.\n"
 	    "                              Default: 5") << endl;
@@ -753,10 +755,18 @@ int main(int argc, char* argv[]) {
       else
 #endif // ENABLE_METALINK
 	if(op->defined(PREF_INPUT_FILE)) {
-	  UriFileListParser flparser(op->get(PREF_INPUT_FILE));
+	  SharedHandle<UriFileListParser> flparser(0);
+	  if(op->get(PREF_INPUT_FILE) == "-") {
+	    flparser = new UriFileListParser(cin);
+	  } else {
+	    if(!File(op->get(PREF_INPUT_FILE)).isFile()) {
+	      throw new FatalException(EX_FILE_OPEN, op->get(PREF_INPUT_FILE).c_str(), "No such file");
+	    }
+	    flparser = new UriFileListParser(op->get(PREF_INPUT_FILE));
+	  }
 	  RequestGroups groups;
-	  while(flparser.hasNext()) {
+	  while(flparser->hasNext()) {
-	    Strings uris = flparser.next();
+	    Strings uris = flparser->next();
 	    if(!uris.empty()) {
 	      Strings xuris;
 	      ncopy(uris.begin(), uris.end(), op->getAsInt(PREF_SPLIT),