github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

Warn if neither --rpc-secret nor a combination of --rpc-user/rpc-passwd is set

pull/203/head
Tatsuhiro Tsujikawa 2014-02-19 21:34:20 +09:00
parent 00e690a4d1
commit de4cd8b59b
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/DownloadEngineFactory.cc
View File

@ -196,6 +196,12 @@ DownloadEngineFactory::newDownloadEngine
e.get(), pid)); e.get(), pid));
} }
if(op->getAsBool(PREF_ENABLE_RPC)) { if(op->getAsBool(PREF_ENABLE_RPC)) {
if(op->get(PREF_RPC_SECRET).empty() && op->get(PREF_RPC_USER).empty()) {
A2_LOG_WARN("Neither --rpc-secret nor a combination of --rpc-user and "
"--rpc-passwd is set. This is insecure. It is extremely "
"recommended to specify --rpc-secret with the adequate "
"secrecy or now deprecated --rpc-user and --rpc-passwd.");
}
bool ok = false; bool ok = false;
bool secure = op->getAsBool(PREF_RPC_SECURE); bool secure = op->getAsBool(PREF_RPC_SECURE);
if(secure) { if(secure) {