github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2009-08-18 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Avoided unnecessary memory allocation in
	BitfieldMan::getCompletedLength().
	* src/BitfieldMan.cc
pull/1/head
Tatsuhiro Tsujikawa 2009-08-18 14:21:02 +00:00
parent a4d5134f80
commit c1f4af537a
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2009-08-18 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Avoided unnecessary memory allocation in
BitfieldMan::getCompletedLength().
* src/BitfieldMan.cc
2009-08-18 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2009-08-18 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Fixed the bug that download fails if Fixed the bug that download fails if

9
src/BitfieldMan.cc
View File

@ -675,8 +675,9 @@ uint64_t BitfieldMan::getFilteredTotalLengthNow() const {
} }
uint64_t BitfieldMan::getCompletedLength(bool useFilter) const { uint64_t BitfieldMan::getCompletedLength(bool useFilter) const {
unsigned char* temp = new unsigned char[bitfieldLength]; unsigned char* temp;
if(useFilter) { if(useFilter) {
temp = new unsigned char[bitfieldLength];
for(size_t i = 0; i < bitfieldLength; ++i) { for(size_t i = 0; i < bitfieldLength; ++i) {
temp[i] = bitfield[i]; temp[i] = bitfield[i];
if(filterEnabled) { if(filterEnabled) {
@ -684,7 +685,7 @@ uint64_t BitfieldMan::getCompletedLength(bool useFilter) const {
} }
} }
} else { } else {
memcpy(temp, bitfield, bitfieldLength); temp = bitfield;
} }
size_t completedBlocks = bitfield::countSetBit(temp, blocks); size_t completedBlocks = bitfield::countSetBit(temp, blocks);
uint64_t completedLength = 0; uint64_t completedLength = 0;
@ -697,7 +698,9 @@ uint64_t BitfieldMan::getCompletedLength(bool useFilter) const {
completedLength = ((uint64_t)completedBlocks)*blockLength; completedLength = ((uint64_t)completedBlocks)*blockLength;
} }
} }
delete [] temp; if(useFilter) {
delete [] temp;
}
return completedLength; return completedLength;
} }