toUpper, toLower: Let compiler copy src

src/cookie_helper.cc

@@ -380,8 +380,7 @@ bool goodPath
 
 std::string canonicalizeHost(const std::string& host)
 {
-  std::string ch = util::toLower(host);
+  return util::toLower(host);
-  return ch;
 }
 
 bool domainMatch(const std::string& requestHost, const std::string& domain)

src/util.cc

@@ -1184,16 +1184,15 @@ std::string getContentDispositionFilename(const std::string& header)
   }
 }
 
-std::string toUpper(const std::string& src) {
+std::string toUpper(std::string src)
-  std::string temp = src;
+{
-  uppercase(temp);
+  uppercase(src);
-  return temp;
+  return src;
 }
 
-std::string toLower(const std::string& src) {
+std::string toLower(std::string src) {
-  std::string temp = src;
+  lowercase(src);
-  lowercase(temp);
+  return src;
-  return temp;
 }
 
 void uppercase(std::string& s)

src/util.h

@@ -325,9 +325,9 @@ ssize_t parse_content_disposition(char *dest, size_t destlen,
 
 std::string getContentDispositionFilename(const std::string& header);
 
-std::string toUpper(const std::string& src);
+std::string toUpper(std::string src);
 
-std::string toLower(const std::string& src);
+std::string toLower(std::string src);
 
 void uppercase(std::string& s);