github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

Enable --keep-unfinished-download-result by default

pull/749/head
Tatsuhiro Tsujikawa 2016-09-26 22:07:35 +09:00
parent e31f537ac5
commit ae78d7f7d0
3 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/manual-src/en/aria2c.rst
View File

@ -1398,8 +1398,7 @@ Advanced Options
downloads must be saved in session file (see downloads must be saved in session file (see
:option:`--save-session` option). Please keep in mind that there is :option:`--save-session` option). Please keep in mind that there is
no upper bound to the number of unfinished download result to keep. no upper bound to the number of unfinished download result to keep.
User should use this option only when they know the total number of If that is undesirable, turn this option off. Default: ``true``
downloads in advance. Default: ``false``
.. option:: --max-download-result=<NUM> .. option:: --max-download-result=<NUM>
@ -1410,8 +1409,10 @@ Advanced Options
oldest download result is removed from the front of the queue and oldest download result is removed from the front of the queue and
new one is pushed to the back. Setting big number in this option may new one is pushed to the back. Setting big number in this option may
result high memory consumption after thousands of result high memory consumption after thousands of
downloads. Specifying 0 means no download result is kept. Default: downloads. Specifying 0 means no download result is kept. Note that
``1000`` unfinished downloads are kept in memory regardless of this option
value. See :option:`--keep-unfinished-download-result` option.
Default: ``1000``
.. option:: --max-mmap-limit=<SIZE> .. option:: --max-mmap-limit=<SIZE>

2
src/OptionHandlerFactory.cc
View File

@ -407,7 +407,7 @@ std::vector<OptionHandler*> OptionHandlerFactory::createOptionHandlers()
OptionHandler* op( OptionHandler* op(
new BooleanOptionHandler(PREF_KEEP_UNFINISHED_DOWNLOAD_RESULT, new BooleanOptionHandler(PREF_KEEP_UNFINISHED_DOWNLOAD_RESULT,
TEXT_KEEP_UNFINISHED_DOWNLOAD_RESULT, TEXT_KEEP_UNFINISHED_DOWNLOAD_RESULT,
A2_V_FALSE, OptionHandler::OPT_ARG)); A2_V_TRUE, OptionHandler::OPT_ARG));
op->addTag(TAG_ADVANCED); op->addTag(TAG_ADVANCED);
op->setChangeGlobalOption(true); op->setChangeGlobalOption(true);
handlers.push_back(op); handlers.push_back(op);

11
src/usage_text.h
View File

@ -795,7 +795,10 @@
" is pushed to the back. Setting big number in this\n" \ " is pushed to the back. Setting big number in this\n" \
" option may result high memory consumption after\n" \ " option may result high memory consumption after\n" \
" thousands of downloads. Specifying 0 means no\n" \ " thousands of downloads. Specifying 0 means no\n" \
" download result is kept.") " download result is kept. Note that unfinished\n" \
" downloads are kept in memory regardless of this\n" \
" option value. See\n" \
" --keep-unfinished-download-result option.")
#define TEXT_ASYNC_DNS_SERVER \ #define TEXT_ASYNC_DNS_SERVER \
_(" --async-dns-server=IPADDRESS[,...] Comma separated list of DNS server address\n" \ _(" --async-dns-server=IPADDRESS[,...] Comma separated list of DNS server address\n" \
" used in asynchronous DNS resolver. Usually\n" \ " used in asynchronous DNS resolver. Usually\n" \
@ -1106,7 +1109,7 @@
" if all unfinished downloads must be saved in\n" \ " if all unfinished downloads must be saved in\n" \
" session file (see --save-session option). Please\n" \ " session file (see --save-session option). Please\n" \
" keep in mind that there is no upper bound to the\n" \ " keep in mind that there is no upper bound to the\n" \
" number of unfinished download result to keep.\n" \ " number of unfinished download result to keep. If\n" \
" User should use this option only when they know\n" \ " that is undesirable, turn this option off.")
" the total number of downloads in advance.")
// clang-format on // clang-format on