From ab06444ba759b1c2126b2e980fafa2b6264eda90 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Tue, 10 Feb 2009 14:42:49 +0000 Subject: [PATCH] 2009-02-10 Tatsuhiro Tsujikawa Removed tests giving -1 for unsigned argument. * test/AlphaNumberDecoratorTest * test/BitfieldManTest.cc * test/DefaultBtContextTest.cc --- ChangeLog | 7 +++++++ test/AlphaNumberDecoratorTest.cc | 7 ------- test/BitfieldManTest.cc | 3 --- test/DefaultBtContextTest.cc | 2 -- 4 files changed, 7 insertions(+), 12 deletions(-) diff --git a/ChangeLog b/ChangeLog index 180972bb..edb54837 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2009-02-10 Tatsuhiro Tsujikawa + + Removed tests giving -1 for unsigned argument. + * test/AlphaNumberDecoratorTest + * test/BitfieldManTest.cc + * test/DefaultBtContextTest.cc + 2009-02-10 Tatsuhiro Tsujikawa Fixed compile error without libcares when epoll is available. diff --git a/test/AlphaNumberDecoratorTest.cc b/test/AlphaNumberDecoratorTest.cc index 91384680..0c9bf63b 100644 --- a/test/AlphaNumberDecoratorTest.cc +++ b/test/AlphaNumberDecoratorTest.cc @@ -9,7 +9,6 @@ class AlphaNumberDecoratorTest:public CppUnit::TestFixture { CPPUNIT_TEST_SUITE(AlphaNumberDecoratorTest); CPPUNIT_TEST(testDecorate); CPPUNIT_TEST(testDecorate_uppercase); - CPPUNIT_TEST(testDecorate_minus); CPPUNIT_TEST_SUITE_END(); private: @@ -19,7 +18,6 @@ public: void testDecorate(); void testDecorate_uppercase(); - void testDecorate_minus(); }; @@ -41,9 +39,4 @@ void AlphaNumberDecoratorTest::testDecorate_uppercase() CPPUNIT_ASSERT_EQUAL(std::string("AAB"), AlphaNumberDecorator(3, true).decorate(1)); } -void AlphaNumberDecoratorTest::testDecorate_minus() -{ - CPPUNIT_ASSERT_EQUAL(std::string("NXMRLXV"), AlphaNumberDecorator(1, true).decorate(-1)); -} - } // namespace aria2 diff --git a/test/BitfieldManTest.cc b/test/BitfieldManTest.cc index 0d6111ae..c1539f9d 100644 --- a/test/BitfieldManTest.cc +++ b/test/BitfieldManTest.cc @@ -553,9 +553,6 @@ void BitfieldManTest::testGetMissingUnusedLength() // from index 10 and all blocks are unused and not acquired. CPPUNIT_ASSERT_EQUAL((uint64_t)10ULL, bf.getMissingUnusedLength(10)); - // from index -1 - CPPUNIT_ASSERT_EQUAL((uint64_t)0ULL, bf.getMissingUnusedLength(-1)); - // from index 11 CPPUNIT_ASSERT_EQUAL((uint64_t)0ULL, bf.getMissingUnusedLength(11)); diff --git a/test/DefaultBtContextTest.cc b/test/DefaultBtContextTest.cc index 14a1395f..0824b485 100644 --- a/test/DefaultBtContextTest.cc +++ b/test/DefaultBtContextTest.cc @@ -94,8 +94,6 @@ void DefaultBtContextTest::testGetPieceHash() { btContext.getPieceHash(1)); CPPUNIT_ASSERT_EQUAL(Util::toHex((const unsigned char*)"CCCCCCCCCCCCCCCCCCCC", 20), btContext.getPieceHash(2)); - CPPUNIT_ASSERT_EQUAL(std::string(""), - btContext.getPieceHash(-1)); CPPUNIT_ASSERT_EQUAL(std::string(""), btContext.getPieceHash(3)); }