github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

FileEntry: Pass by value for simple setter functions

pull/159/merge
Tatsuhiro Tsujikawa 2013-12-15 19:20:31 +09:00
parent caf7213bad
commit a21a868af0
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/FileEntry.cc
View File

@ -546,14 +546,14 @@ bool FileEntry::insertUri(const std::string& uri, size_t pos)
return true; return true;
} }
void FileEntry::setPath(const std::string& path) void FileEntry::setPath(std::string path)
{ {
path_ = path; path_ = std::move(path);
} }
void FileEntry::setContentType(const std::string& contentType) void FileEntry::setContentType(std::string contentType)
{ {
contentType_ = contentType; contentType_ = std::move(contentType);
} }
size_t FileEntry::countInFlightRequest() const size_t FileEntry::countInFlightRequest() const
@ -566,9 +566,9 @@ size_t FileEntry::countPooledRequest() const
return requestPool_.size(); return requestPool_.size();
} }
void FileEntry::setOriginalName(const std::string& originalName) void FileEntry::setOriginalName(std::string originalName)
{ {
originalName_ = originalName; originalName_ = std::move(originalName);
} }
bool FileEntry::emptyRequestUri() const bool FileEntry::emptyRequestUri() const

6
src/FileEntry.h
View File

@ -109,7 +109,7 @@ public:
const std::string& getPath() const { return path_; } const std::string& getPath() const { return path_; }
void setPath(const std::string& path); void setPath(std::string path);
int64_t getLength() const { return length_; } int64_t getLength() const { return length_; }
@ -167,7 +167,7 @@ public:
// Inserts uris_ and spentUris_ into uris. // Inserts uris_ and spentUris_ into uris.
void getUris(std::vector<std::string>& uris) const; void getUris(std::vector<std::string>& uris) const;
void setContentType(const std::string& contentType); void setContentType(std::string contentType);
const std::string& getContentType() const { return contentType_; } const std::string& getContentType() const { return contentType_; }
@ -257,7 +257,7 @@ public:
// Push URIs in pooled or in-flight requests to the front of uris_. // Push URIs in pooled or in-flight requests to the front of uris_.
void putBackRequest(); void putBackRequest();
void setOriginalName(const std::string& originalName); void setOriginalName(std::string originalName);
const std::string& getOriginalName() const const std::string& getOriginalName() const
{ {