Use std::make_shared and make_unique where possible, part 2

src/HttpInitiateConnectionCommand.cc

@@ -95,13 +95,9 @@ std::unique_ptr<Command> HttpInitiateConnectionCommand::createNextCommand
                                            getDownloadEngine(),
                                            getSocket());
       if(proxyMethod == V_TUNNEL) {
-        std::shared_ptr<HttpProxyRequestConnectChain> chain
+        c->setControlChain(std::make_shared<HttpProxyRequestConnectChain>());
-          (new HttpProxyRequestConnectChain());
-        c->setControlChain(chain);
       } else if(proxyMethod == V_GET) {
-        std::shared_ptr<HttpRequestConnectChain> chain
+        c->setControlChain(std::make_shared<HttpRequestConnectChain>());
-          (new HttpRequestConnectChain());
-        c->setControlChain(chain);
       } else {
         // Unreachable
         assert(0);
@@ -110,15 +106,14 @@ std::unique_ptr<Command> HttpInitiateConnectionCommand::createNextCommand
       return std::move(c);
     } else {
       setConnectedAddrInfo(getRequest(), hostname, pooledSocket);
-      std::shared_ptr<SocketRecvBuffer> socketRecvBuffer
+      auto c = make_unique<HttpRequestCommand>
-        (new SocketRecvBuffer(pooledSocket));
+        (getCuid(),
-      std::shared_ptr<HttpConnection> httpConnection
-        (new HttpConnection(getCuid(), pooledSocket, socketRecvBuffer));
-      auto c = make_unique<HttpRequestCommand>(getCuid(),
          getRequest(),
          getFileEntry(),
          getRequestGroup(),
-                                               httpConnection,
+         std::make_shared<HttpConnection>
+         (getCuid(), pooledSocket,
+          std::make_shared<SocketRecvBuffer>(pooledSocket)),
          getDownloadEngine(),
          pooledSocket);
       if(proxyMethod == V_GET) {
@@ -144,24 +139,21 @@ std::unique_ptr<Command> HttpInitiateConnectionCommand::createNextCommand
                                            getRequestGroup(),
                                            getDownloadEngine(),
                                            getSocket());
-      std::shared_ptr<HttpRequestConnectChain> chain
+      c->setControlChain(std::make_shared<HttpRequestConnectChain>());
-        (new HttpRequestConnectChain());
-      c->setControlChain(chain);
       setupBackupConnection(hostname, addr, port, c.get());
       return std::move(c);
     } else {
       setSocket(pooledSocket);
       setConnectedAddrInfo(getRequest(), hostname, pooledSocket);
 
-      std::shared_ptr<SocketRecvBuffer> socketRecvBuffer
+      return make_unique<HttpRequestCommand>
-        (new SocketRecvBuffer(getSocket()));
+        (getCuid(),
-      std::shared_ptr<HttpConnection> httpConnection
-        (new HttpConnection(getCuid(), getSocket(), socketRecvBuffer));
-      return make_unique<HttpRequestCommand>(getCuid(),
          getRequest(),
          getFileEntry(),
          getRequestGroup(),
-                                             httpConnection,
+         std::make_shared<HttpConnection>
+         (getCuid(), getSocket(),
+          std::make_shared<SocketRecvBuffer>(getSocket())),
          getDownloadEngine(),
          getSocket());
     }

src/HttpListenCommand.cc

@@ -96,7 +96,7 @@ bool HttpListenCommand::bindPort(uint16_t port)
   if(serverSocket_) {
     e_->deleteSocketForReadCheck(serverSocket_, this);
   }
-  serverSocket_.reset(new SocketCore());
+  serverSocket_ = std::make_shared<SocketCore>();
   const int ipv = (family_ == AF_INET) ? 4 : 6;
   try {
     int flags = 0;

src/HttpServer.cc

@@ -62,7 +62,7 @@ std::unique_ptr<util::security::HMAC> HttpServer::hmac_;
 
 HttpServer::HttpServer(const std::shared_ptr<SocketCore>& socket)
  : socket_(socket),
-   socketRecvBuffer_(new SocketRecvBuffer(socket_)),
+   socketRecvBuffer_(std::make_shared<SocketRecvBuffer>(socket_)),
    socketBuffer_(socket),
    headerProcessor_(make_unique<HttpHeaderProcessor>
                     (HttpHeaderProcessor::SERVER_PARSER)),
@@ -341,7 +341,7 @@ int HttpServer::setupResponseRecv()
     if(path == "/jsonrpc") {
       if(reqType_ != RPC_TYPE_JSON) {
         reqType_ = RPC_TYPE_JSON;
-        lastBody_.reset(new json::JsonDiskWriter());
+        lastBody_ = make_unique<json::JsonDiskWriter>();
       }
       return 0;
     }
@@ -349,7 +349,7 @@ int HttpServer::setupResponseRecv()
     if(path == "/rpc") {
       if(reqType_ != RPC_TYPE_XML) {
         reqType_ = RPC_TYPE_XML;
-        lastBody_.reset(new rpc::XmlRpcDiskWriter());
+        lastBody_ = make_unique<rpc::XmlRpcDiskWriter>();
       }
       return 0;
     }

src/HttpServerCommand.cc

@@ -67,7 +67,7 @@ HttpServerCommand::HttpServerCommand
   : Command(cuid),
     e_(e),
     socket_(socket),
-    httpServer_(new HttpServer(socket)),
+    httpServer_(std::make_shared<HttpServer>(socket)),
     writeCheck_(false)
 {
   setStatus(Command::STATUS_ONESHOT_REALTIME);

src/InitiateConnectionCommand.cc

@@ -147,7 +147,7 @@ InitiateConnectionCommand::createBackupIPv4ConnectCommand
   for(std::vector<std::string>::const_iterator i = addrs.begin(),
         eoi = addrs.end(); i != eoi; ++i) {
     if(inetPton(AF_INET, (*i).c_str(), &buf) == 0) {
-      info.reset(new BackupConnectInfo());
+      info = std::make_shared<BackupConnectInfo>();
       auto command = make_unique<BackupIPv4ConnectCommand>
         (getDownloadEngine()->newCUID(), *i, port, info, mainCommand,
          getRequestGroup(), getDownloadEngine());

src/InitiatorMSEHandshakeCommand.cc

@@ -70,7 +70,7 @@ InitiatorMSEHandshakeCommand::InitiatorMSEHandshakeCommand
     requestGroup_(requestGroup),
     btRuntime_(btRuntime),
     sequence_(INITIATOR_SEND_KEY),
-    mseHandshake_(new MSEHandshake(cuid, s, getOption().get()))
+    mseHandshake_(make_unique<MSEHandshake>(cuid, s, getOption().get()))
 {
   disableReadCheckSocket();
   setWriteCheckSocket(getSocket());
@@ -84,8 +84,6 @@ InitiatorMSEHandshakeCommand::~InitiatorMSEHandshakeCommand()
 {
   requestGroup_->decreaseNumCommand();
   btRuntime_->decreaseConnections();
-
-  delete mseHandshake_;
 }
 
 bool InitiatorMSEHandshakeCommand::executeInternal() {

src/InitiatorMSEHandshakeCommand.h

@@ -67,7 +67,7 @@ private:
   std::shared_ptr<BtRuntime> btRuntime_;
 
   Seq sequence_;
-  MSEHandshake* mseHandshake_;
+  std::unique_ptr<MSEHandshake> mseHandshake_;
 
   const std::shared_ptr<Option>& getOption() const;
 

src/IteratableChunkChecksumValidator.cc

@@ -58,7 +58,7 @@ IteratableChunkChecksumValidator::IteratableChunkChecksumValidator
  const std::shared_ptr<PieceStorage>& pieceStorage)
   : dctx_(dctx),
     pieceStorage_(pieceStorage),
-    bitfield_(new BitfieldMan(dctx_->getPieceLength(),
+    bitfield_(make_unique<BitfieldMan>(dctx_->getPieceLength(),
                                        dctx_->getTotalLength())),
     currentIndex_(0)
 {}

src/IteratableChunkChecksumValidator.h

@@ -52,7 +52,7 @@ class IteratableChunkChecksumValidator:public IteratableValidator
 private:
   std::shared_ptr<DownloadContext> dctx_;
   std::shared_ptr<PieceStorage> pieceStorage_;
-  std::shared_ptr<BitfieldMan> bitfield_;
+  std::unique_ptr<BitfieldMan> bitfield_;
   size_t currentIndex_;
   std::unique_ptr<MessageDigest> ctx_;
 

src/KqueueEventPoll.cc

@@ -280,8 +280,6 @@ bool KqueueEventPoll::addNameResolver
 bool KqueueEventPoll::deleteNameResolver
 (const std::shared_ptr<AsyncNameResolver>& resolver, Command* command)
 {
-  std::shared_ptr<KAsyncNameResolverEntry> entry
-    (new KAsyncNameResolverEntry(resolver, command));
   auto key = std::make_pair(resolver.get(), command);
   auto itr = nameResolverEntries_.find(key);
   if(itr == std::end(nameResolverEntries_)) {

src/LibgcryptMessageDigestImpl.cc

@@ -108,7 +108,7 @@ typedef MessageDigestBase<GCRY_MD_SHA512> MessageDigestSHA512;
 
 std::unique_ptr<MessageDigestImpl> MessageDigestImpl::sha1()
 {
-  return std::unique_ptr<MessageDigestImpl>(new MessageDigestSHA1());
+  return make_unique<MessageDigestSHA1>();
 }
 
 MessageDigestImpl::hashes_t MessageDigestImpl::hashes = {

src/LibnettleMessageDigestImpl.cc

@@ -45,7 +45,7 @@ namespace {
 template<const nettle_hash* hash>
 class MessageDigestBase : public MessageDigestImpl {
 public:
-  MessageDigestBase() : ctx_(new char[hash->context_size]) {
+  MessageDigestBase() : ctx_(make_unique<char[]>(hash->context_size)) {
     reset();
   }
   virtual ~MessageDigestBase() {}
@@ -87,7 +87,7 @@ typedef MessageDigestBase<&nettle_sha512> MessageDigestSHA512;
 
 std::unique_ptr<MessageDigestImpl> MessageDigestImpl::sha1()
 {
-  return std::unique_ptr<MessageDigestImpl>(new MessageDigestSHA1());
+  return make_unique<MessageDigestSHA1>();
 }
 
 MessageDigestImpl::hashes_t MessageDigestImpl::hashes = {

src/LibsslMessageDigestImpl.cc

@@ -86,7 +86,7 @@ typedef MessageDigestBase<EVP_sha1> MessageDigestSHA1;
 
 std::unique_ptr<MessageDigestImpl> MessageDigestImpl::sha1()
 {
-  return std::unique_ptr<MessageDigestImpl>(new MessageDigestSHA1());
+  return make_unique<MessageDigestSHA1>();
 }
 
 MessageDigestImpl::hashes_t MessageDigestImpl::hashes = {

src/LogFactory.cc

@@ -94,7 +94,7 @@ void LogFactory::reconfigure()
 const std::shared_ptr<Logger>& LogFactory::getInstance()
 {
   if(!logger_) {
-    std::shared_ptr<Logger> slogger(new Logger());
+    auto slogger = std::make_shared<Logger>();
     openLogger(slogger);
     logger_.swap(slogger);
   }

src/Logger.cc

@@ -67,7 +67,8 @@ void Logger::openFile(const std::string& filename)
   if(filename == DEV_STDOUT) {
     fpp_ = global::cout();
   } else {
-    fpp_.reset(new BufferedFile(filename.c_str(), BufferedFile::APPEND));
+    fpp_ = std::make_shared<BufferedFile>(filename.c_str(),
+                                          BufferedFile::APPEND);
     if(!*static_cast<BufferedFile*>(fpp_.get())) {
       throw DL_ABORT_EX(fmt(EX_FILE_OPEN, filename.c_str(), "n/a"));
     }

src/LpdMessageDispatcher.cc

@@ -65,7 +65,7 @@ bool LpdMessageDispatcher::init(const std::string& localAddr,
                                 unsigned char ttl, unsigned char loop)
 {
   try {
-    socket_.reset(new SocketCore(SOCK_DGRAM));
+    socket_ = std::make_shared<SocketCore>(SOCK_DGRAM);
     socket_->create(AF_INET);
     A2_LOG_DEBUG(fmt("Setting multicast outgoing interface=%s",
                      localAddr.c_str()));

src/MSEHandshake.cc

@@ -81,20 +81,15 @@ MSEHandshake::MSEHandshake
     rbufLength_(0),
     socketBuffer_(socket),
     negotiatedCryptoType_(CRYPTO_NONE),
-    dh_(nullptr),
     initiator_(true),
     markerIndex_(0),
     padLength_(0),
     iaLength_(0),
-    ia_(nullptr),
     sha1_(MessageDigest::sha1())
 {}
 
 MSEHandshake::~MSEHandshake()
-{
+{}
-  delete dh_;
-  delete [] ia_;
-}
 
 MSEHandshake::HANDSHAKE_TYPE MSEHandshake::identifyHandshakeType()
 {
@@ -115,8 +110,7 @@ MSEHandshake::HANDSHAKE_TYPE MSEHandshake::identifyHandshakeType()
 
 void MSEHandshake::initEncryptionFacility(bool initiator)
 {
-  delete dh_;
+  dh_ = make_unique<DHKeyExchange>();
-  dh_ = new DHKeyExchange();
   dh_->init(PRIME, PRIME_BITS, GENERATOR, 160);
   dh_->generatePublicKey();
   A2_LOG_DEBUG(fmt("CUID#%" PRId64 " - DH initialized.", cuid_));
@@ -501,9 +495,8 @@ bool MSEHandshake::receiveReceiverIA()
     wantRead_ = true;
     return false;
   }
-  delete [] ia_;
+  ia_ = make_unique<unsigned char[]>(iaLength_);
-  ia_ = new unsigned char[iaLength_];
+  decryptor_->encrypt(iaLength_, ia_.get(), rbuf_);
-  decryptor_->encrypt(iaLength_, ia_, rbuf_);
   A2_LOG_DEBUG(fmt("CUID#%" PRId64 " - IA received.", cuid_));
   // shift rbuf_
   shiftBuffer(iaLength_);

src/MSEHandshake.h

@@ -87,7 +87,7 @@ private:
   SocketBuffer socketBuffer_;
 
   CRYPTO_TYPE negotiatedCryptoType_;
-  DHKeyExchange* dh_;
+  std::unique_ptr<DHKeyExchange> dh_;
   std::unique_ptr<ARC4Encryptor> encryptor_;
   std::unique_ptr<ARC4Encryptor> decryptor_;
   unsigned char infoHash_[INFO_HASH_LENGTH];
@@ -97,7 +97,7 @@ private:
   size_t markerIndex_;
   uint16_t padLength_;
   uint16_t iaLength_;
-  unsigned char* ia_;
+  std::unique_ptr<unsigned char[]> ia_;
   std::unique_ptr<MessageDigest> sha1_;
 
   void encryptAndSendData(unsigned char* data, size_t length);
@@ -179,7 +179,7 @@ public:
   // returns plain text IA
   const unsigned char* getIA() const
   {
-    return ia_;
+    return ia_.get();
   }
 
   size_t getIALength() const

src/Netrc.cc

@@ -171,11 +171,11 @@ void Netrc::parse(const std::string& path)
       if(state == GET_TOKEN) {
         if(util::streq((*iter).first, (*iter).second, "machine")) {
           storeAuthenticator(std::move(authenticator));
-          authenticator.reset(new Authenticator());
+          authenticator = make_unique<Authenticator>();
           state = SET_MACHINE;
         } else if(util::streq((*iter).first, (*iter).second, "default")) {
           storeAuthenticator(std::move(authenticator));
-          authenticator.reset(new DefaultAuthenticator());
+          authenticator = make_unique<DefaultAuthenticator>();
         } else {
           if(!authenticator) {
             throw DL_ABORT_EX

src/OptionHandlerException.cc

@@ -64,8 +64,7 @@ OptionHandlerException::~OptionHandlerException() throw() {}
 
 std::shared_ptr<Exception> OptionHandlerException::copy() const
 {
-  std::shared_ptr<Exception> e(new OptionHandlerException(*this));
+  return std::make_shared<OptionHandlerException>(*this);
-  return e;
 }
 
 } // namespace aria2

src/OptionParser.cc

@@ -352,7 +352,7 @@ std::shared_ptr<OptionParser> OptionParser::optionParser_;
 const std::shared_ptr<OptionParser>& OptionParser::getInstance()
 {
   if(!optionParser_) {
-    optionParser_.reset(new OptionParser());
+    optionParser_ = std::make_shared<OptionParser>();
     optionParser_->setOptionHandlers(OptionHandlerFactory::createOptionHandlers());
   }
   return optionParser_;

src/PeerAbstractCommand.cc

@@ -195,7 +195,7 @@ void PeerAbstractCommand::updateKeepAlive()
 
 void PeerAbstractCommand::createSocket()
 {
-  socket_.reset(new SocketCore());
+  socket_ = std::make_shared<SocketCore>();
 }
 
 void PeerAbstractCommand::addCommandSelf()

src/PeerConnection.cc

@@ -70,7 +70,7 @@ PeerConnection::PeerConnection
     socket_(socket),
     msgState_(BT_MSG_PREV_READ_LENGTH),
     bufferCapacity_(MAX_BUFFER_CAPACITY),
-    resbuf_(new unsigned char[bufferCapacity_]),
+    resbuf_(make_unique<unsigned char[]>(bufferCapacity_)),
     resbufLength_(0),
     currentPayloadLength_(0),
     resbufOffset_(0),
@@ -81,9 +81,7 @@ PeerConnection::PeerConnection
 {}
 
 PeerConnection::~PeerConnection()
-{
+{}
-  delete [] resbuf_;
-}
 
 void PeerConnection::pushBytes(unsigned char* data, size_t len,
                                std::unique_ptr<ProgressUpdate> progressUpdate)
@@ -142,7 +140,7 @@ bool PeerConnection::receiveMessage(unsigned char* data, size_t& dataLength)
     resbufOffset_ = i;
     if(done) {
       if(data) {
-        memcpy(data, resbuf_ + msgOffset_ + 4, currentPayloadLength_);
+        memcpy(data, resbuf_.get() + msgOffset_ + 4, currentPayloadLength_);
       }
       dataLength = currentPayloadLength_;
       return true;
@@ -158,7 +156,8 @@ bool PeerConnection::receiveMessage(unsigned char* data, size_t& dataLength)
         } else {
           // Shift buffer so that resbuf_[msgOffset_] moves to
           // rebuf_[0].
-          memmove(resbuf_, resbuf_ + msgOffset_, resbufLength_ - msgOffset_);
+          memmove(resbuf_.get(), resbuf_.get() + msgOffset_,
+                  resbufLength_ - msgOffset_);
           resbufLength_ -= msgOffset_;
           resbufOffset_ = resbufLength_;
           msgOffset_ = 0;
@@ -172,7 +171,7 @@ bool PeerConnection::receiveMessage(unsigned char* data, size_t& dataLength)
       } else {
         nread = bufferCapacity_ - resbufLength_;
       }
-      readData(resbuf_+resbufLength_, nread, encryptionEnabled_);
+      readData(resbuf_.get() +resbufLength_, nread, encryptionEnabled_);
       if(nread == 0) {
         if(socket_->wantRead() || socket_->wantWrite()) {
           break;
@@ -198,7 +197,7 @@ bool PeerConnection::receiveHandshake(unsigned char* data, size_t& dataLength,
   size_t remaining = BtHandshakeMessage::MESSAGE_LENGTH-resbufLength_;
   if(remaining > 0) {
     size_t temp = remaining;
-    readData(resbuf_+resbufLength_, remaining, encryptionEnabled_);
+    readData(resbuf_.get()+resbufLength_, remaining, encryptionEnabled_);
     if(remaining == 0 && !socket_->wantRead() && !socket_->wantWrite()) {
       // we got EOF
       A2_LOG_DEBUG
@@ -214,7 +213,7 @@ bool PeerConnection::receiveHandshake(unsigned char* data, size_t& dataLength,
     }
   }
   size_t writeLength = std::min(resbufLength_, dataLength);
-  memcpy(data, resbuf_, writeLength);
+  memcpy(data, resbuf_.get(), writeLength);
   dataLength = writeLength;
   if(retval && !peek) {
     resbufLength_ = 0;
@@ -244,7 +243,7 @@ void PeerConnection::enableEncryption
 void PeerConnection::presetBuffer(const unsigned char* data, size_t length)
 {
   size_t nwrite = std::min(bufferCapacity_, length);
-  memcpy(resbuf_, data, nwrite);
+  memcpy(resbuf_.get(), data, nwrite);
   resbufLength_ = length;
 }
 
@@ -267,17 +266,16 @@ ssize_t PeerConnection::sendPendingData()
 
 const unsigned char* PeerConnection::getMsgPayloadBuffer() const
 {
-  return resbuf_ + msgOffset_ + 4;
+  return resbuf_.get() + msgOffset_ + 4;
 }
 
 void PeerConnection::reserveBuffer(size_t minSize)
 {
   if(bufferCapacity_ < minSize) {
     bufferCapacity_ = minSize;
-    auto buf = new unsigned char[bufferCapacity_];
+    auto buf = make_unique<unsigned char[]>(bufferCapacity_);
-    memcpy(buf, resbuf_, resbufLength_);
+    memcpy(buf.get(), resbuf_.get(), resbufLength_);
-    delete [] resbuf_;
+    resbuf_ = std::move(buf);
-    resbuf_ = buf;
   }
 }
 

src/PeerConnection.h

@@ -64,7 +64,7 @@ private:
   // The capacity of the buffer resbuf_
   size_t bufferCapacity_;
   // The internal buffer of incoming handshakes and messages
-  unsigned char* resbuf_;
+  std::unique_ptr<unsigned char[]> resbuf_;
   // The number of bytes written in resbuf_
   size_t resbufLength_;
   // The length of message (not handshake) currently receiving
@@ -124,7 +124,7 @@ public:
 
   const unsigned char* getBuffer() const
   {
-    return resbuf_;
+    return resbuf_.get();
   }
 
   size_t getBufferLength() const

src/PeerListenCommand.cc

@@ -65,7 +65,7 @@ PeerListenCommand::~PeerListenCommand() {}
 
 bool PeerListenCommand::bindPort(uint16_t& port, SegList<int>& sgl)
 {
-  socket_.reset(new SocketCore());
+  socket_ = std::make_shared<SocketCore>();
   std::vector<uint16_t> ports;
   while(sgl.hasNext()) {
     ports.push_back(sgl.next());
@@ -114,7 +114,8 @@ bool PeerListenCommand::execute() {
       std::pair<std::string, uint16_t> peerInfo;
       peerSocket->getPeerInfo(peerInfo);
 
-      std::shared_ptr<Peer> peer(new Peer(peerInfo.first, peerInfo.second, true));
+      auto peer = std::make_shared<Peer>(peerInfo.first, peerInfo.second,
+                                         true);
       cuid_t cuid = e_->newCUID();
       e_->addCommand(make_unique<ReceiverMSEHandshakeCommand>
                      (cuid, peer, e_, peerSocket));

src/PeerSessionResource.cc

@@ -41,12 +41,13 @@
 #include "A2STR.h"
 #include "BtMessageDispatcher.h"
 #include "wallclock.h"
+#include "a2functional.h"
 
 namespace aria2 {
 
 PeerSessionResource::PeerSessionResource(int32_t pieceLength, int64_t totalLength)
   :
-  bitfieldMan_(new BitfieldMan(pieceLength, totalLength)),
+  bitfieldMan_(make_unique<BitfieldMan>(pieceLength, totalLength)),
   lastDownloadUpdate_(0),
   lastAmUnchoking_(0),
   dispatcher_(nullptr),
@@ -63,9 +64,7 @@ PeerSessionResource::PeerSessionResource(int32_t pieceLength, int64_t totalLengt
 {}
 
 PeerSessionResource::~PeerSessionResource()
-{
+{}
-  delete bitfieldMan_;
-}
 
 void PeerSessionResource::amChoking(bool b)
 {
@@ -251,8 +250,7 @@ size_t PeerSessionResource::countOutstandingUpload() const
 
 void PeerSessionResource::reconfigure(int32_t pieceLength, int64_t totalLenth)
 {
-  delete bitfieldMan_;
+  bitfieldMan_ = make_unique<BitfieldMan>(pieceLength, totalLenth);
-  bitfieldMan_ = new BitfieldMan(pieceLength, totalLenth);
 }
 
 } // namespace aria2

src/PeerSessionResource.h

@@ -39,6 +39,7 @@
 
 #include <string>
 #include <set>
+#include <memory>
 
 #include "BtConstants.h"
 #include "NetStat.h"
@@ -52,7 +53,7 @@ class BtMessageDispatcher;
 
 class PeerSessionResource {
 private:
-  BitfieldMan* bitfieldMan_;
+  std::unique_ptr<BitfieldMan> bitfieldMan_;
   // fast index set which a peer has sent to localhost.
   std::set<size_t> peerAllowedIndexSet_;
   // fast index set which localhost has sent to a peer.

src/Piece.cc

@@ -51,17 +51,14 @@
 namespace aria2 {
 
 Piece::Piece()
-  : bitfield_(nullptr),
+  : index_(0),
-    wrCache_(nullptr),
-    index_(0),
     length_(0),
     nextBegin_(0),
     usedBySegment_(false)
 {}
 
 Piece::Piece(size_t index, int64_t length, int32_t blockLength)
- : bitfield_(new BitfieldMan(blockLength, length)),
+  : bitfield_(make_unique<BitfieldMan>(blockLength, length)),
-   wrCache_(nullptr),
     index_(index),
     length_(length),
     nextBegin_(0),
@@ -69,10 +66,7 @@ Piece::Piece(size_t index, int64_t length, int32_t blockLength)
 {}
 
 Piece::~Piece()
-{
+{}
-  delete wrCache_;
-  delete bitfield_;
-}
 
 void Piece::completeBlock(size_t blockIndex) {
   bitfield_->setBit(blockIndex);
@@ -185,7 +179,6 @@ std::string Piece::toString() const {
 
 void Piece::reconfigure(int64_t length)
 {
-  delete bitfield_;
   length_ = length;
   // TODO currently, this function is only called from
   // GrowSegment::updateWrittenLength().  If we use default block
@@ -193,7 +186,8 @@ void Piece::reconfigure(int64_t length)
   // BitfieldMan for each call is very expensive.  Therefore, we use
   // maximum block length for now to reduce the overhead.  Ideally, we
   // check the code thoroughly and remove bitfield_ if we can.
-  bitfield_ = new BitfieldMan(std::numeric_limits<int32_t>::max(), length_);
+  bitfield_ = make_unique<BitfieldMan>(std::numeric_limits<int32_t>::max(),
+                                       length_);
 }
 
 void Piece::setBitfield(const unsigned char* bitfield, size_t len)
@@ -323,9 +317,9 @@ void Piece::initWrCache(WrDiskCache* diskCache,
   if(!diskCache) {
     return;
   }
-  assert(wrCache_ == nullptr);
+  assert(!wrCache_);
-  wrCache_ = new WrDiskCacheEntry(diskAdaptor);
+  wrCache_ = make_unique<WrDiskCacheEntry>(diskAdaptor);
-  bool rv = diskCache->add(wrCache_);
+  bool rv = diskCache->add(wrCache_.get());
   assert(rv);
 }
 
@@ -336,7 +330,7 @@ void Piece::flushWrCache(WrDiskCache* diskCache)
   }
   assert(wrCache_);
   ssize_t size = static_cast<ssize_t>(wrCache_->getSize());
-  diskCache->update(wrCache_, -size);
+  diskCache->update(wrCache_.get(), -size);
   wrCache_->writeToDisk();
 }
 
@@ -347,7 +341,7 @@ void Piece::clearWrCache(WrDiskCache* diskCache)
   }
   assert(wrCache_);
   ssize_t size = static_cast<ssize_t>(wrCache_->getSize());
-  diskCache->update(wrCache_, -size);
+  diskCache->update(wrCache_.get(), -size);
   wrCache_->clear();
 }
 
@@ -359,7 +353,7 @@ void Piece::updateWrCache(WrDiskCache* diskCache, unsigned char* data,
     return;
   }
   assert(wrCache_);
-  A2_LOG_DEBUG(fmt("updateWrCache entry=%p", wrCache_));
+  A2_LOG_DEBUG(fmt("updateWrCache entry=%p", wrCache_.get()));
   auto cell = new WrDiskCacheEntry::DataCell();
   cell->goff = goff;
   cell->data = data;
@@ -369,7 +363,7 @@ void Piece::updateWrCache(WrDiskCache* diskCache, unsigned char* data,
   bool rv;
   rv = wrCache_->cacheData(cell);
   assert(rv);
-  rv = diskCache->update(wrCache_, len);
+  rv = diskCache->update(wrCache_.get(), len);
   assert(rv);
 }
 
@@ -383,7 +377,7 @@ size_t Piece::appendWrCache(WrDiskCache* diskCache, int64_t goff,
   size_t delta = wrCache_->append(goff, data, len);
   bool rv;
   if(delta > 0) {
-    rv = diskCache->update(wrCache_, delta);
+    rv = diskCache->update(wrCache_.get(), delta);
     assert(rv);
   }
   return delta;
@@ -392,9 +386,8 @@ size_t Piece::appendWrCache(WrDiskCache* diskCache, int64_t goff,
 void Piece::releaseWrCache(WrDiskCache* diskCache)
 {
   if(diskCache && wrCache_) {
-    diskCache->remove(wrCache_);
+    diskCache->remove(wrCache_.get());
-    delete wrCache_;
+    wrCache_.reset();
-    wrCache_ = nullptr;
   }
 }
 

src/Piece.h

@@ -54,8 +54,8 @@ class MessageDigest;
 
 class Piece {
 private:
-  BitfieldMan* bitfield_;
+  std::unique_ptr<BitfieldMan> bitfield_;
-  WrDiskCacheEntry* wrCache_;
+  std::unique_ptr<WrDiskCacheEntry> wrCache_;
   std::unique_ptr<MessageDigest> mdctx_;
   std::vector<cuid_t> users_;
   std::string hashType_;
@@ -204,7 +204,7 @@ public:
   void releaseWrCache(WrDiskCache* diskCache);
   WrDiskCacheEntry* getWrDiskCacheEntry() const
   {
-    return wrCache_;
+    return wrCache_.get();
   }
 };
 

src/ReceiverMSEHandshakeCommand.cc

@@ -61,16 +61,14 @@ ReceiverMSEHandshakeCommand::ReceiverMSEHandshakeCommand
 
   PeerAbstractCommand(cuid, peer, e, s),
   sequence_(RECEIVER_IDENTIFY_HANDSHAKE),
-  mseHandshake_(new MSEHandshake(cuid, s, e->getOption()))
+  mseHandshake_(make_unique<MSEHandshake>(cuid, s, e->getOption()))
 {
   setTimeout(e->getOption()->getAsInt(PREF_PEER_CONNECTION_TIMEOUT));
   mseHandshake_->setWantRead(true);
 }
 
 ReceiverMSEHandshakeCommand::~ReceiverMSEHandshakeCommand()
-{
+{}
-  delete mseHandshake_;
-}
 
 bool ReceiverMSEHandshakeCommand::exitBeforeExecute()
 {

src/ReceiverMSEHandshakeCommand.h

@@ -60,7 +60,7 @@ public:
 private:
   Seq sequence_;
 
-  MSEHandshake* mseHandshake_;
+  std::unique_ptr<MSEHandshake> mseHandshake_;
 
   void createCommand();
 protected:

src/RecoverableException.cc

@@ -38,8 +38,7 @@ namespace aria2 {
 
 std::shared_ptr<Exception> RecoverableException::copy() const
 {
-  std::shared_ptr<Exception> e(new RecoverableException(*this));
+  return std::make_shared<RecoverableException>(*this);
-  return e;
 }
 
 RecoverableException::RecoverableException

src/Request.cc

@@ -168,7 +168,7 @@ const std::shared_ptr<PeerStat>& Request::initPeerStat()
   assert(v == 0);
   std::string host = uri::getFieldString(us, USR_HOST, uri_.c_str());
   std::string protocol = uri::getFieldString(us, USR_SCHEME, uri_.c_str());
-  peerStat_.reset(new PeerStat(0, host, protocol));
+  peerStat_ = std::make_shared<PeerStat>(0, host, protocol);
   return peerStat_;
 }
 

src/RequestGroup.cc

@@ -124,7 +124,7 @@ RequestGroup::RequestGroup(const std::shared_ptr<GroupId>& gid,
   : belongsToGID_(0),
     gid_(gid),
     option_(option),
-    progressInfoFile_(new NullProgressInfoFile()),
+    progressInfoFile_(std::make_shared<NullProgressInfoFile>()),
     uriSelector_(make_unique<InorderURISelector>()),
     requestGroupMan_(nullptr),
 #ifdef ENABLE_BITTORRENT
@@ -1123,7 +1123,7 @@ std::shared_ptr<DownloadResult> RequestGroup::createDownloadResult() const
   A2_LOG_DEBUG(fmt("GID#%s - Creating DownloadResult.",
                    gid_->toHex().c_str()));
   TransferStat st = calculateStat();
-  std::shared_ptr<DownloadResult> res(new DownloadResult());
+  auto res = std::make_shared<DownloadResult>();
   res->gid = gid_;
   res->fileEntries = downloadContext_->getFileEntries();
   res->inMemoryDownload = inMemoryDownload_;

src/RequestGroupMan.cc

@@ -106,7 +106,7 @@ RequestGroupMan::RequestGroupMan
  const Option* option)
   : maxSimultaneousDownloads_(maxSimultaneousDownloads),
     option_(option),
-    serverStatMan_(new ServerStatMan()),
+    serverStatMan_(std::make_shared<ServerStatMan>()),
     maxOverallDownloadSpeedLimit_
     (option->getAsInt(PREF_MAX_OVERALL_DOWNLOAD_LIMIT)),
     maxOverallUploadSpeedLimit_(option->getAsInt
@@ -116,7 +116,6 @@ RequestGroupMan::RequestGroupMan
     removedErrorResult_(0),
     removedLastErrorResult_(error_code::FINISHED),
     maxDownloadResult_(option->getAsInt(PREF_MAX_DOWNLOAD_RESULT)),
-    wrDiskCache_(nullptr),
     openedFileCounter_(std::make_shared<OpenedFileCounter>
                        (this, option->getAsInt(PREF_BT_MAX_OPEN_FILES))),
     numStoppedTotal_(0)
@@ -128,7 +127,6 @@ RequestGroupMan::RequestGroupMan
 RequestGroupMan::~RequestGroupMan()
 {
   openedFileCounter_->deactivate();
-  delete wrDiskCache_;
 }
 
 bool RequestGroupMan::downloadFinished()
@@ -871,7 +869,7 @@ RequestGroupMan::getOrCreateServerStat(const std::string& hostname,
 {
   std::shared_ptr<ServerStat> ss = findServerStat(hostname, protocol);
   if(!ss) {
-    ss.reset(new ServerStat(hostname, protocol));
+    ss = std::make_shared<ServerStat>(hostname, protocol);
     addServerStat(ss);
   }
   return ss;
@@ -960,10 +958,10 @@ void RequestGroupMan::setUriListParser
 
 void RequestGroupMan::initWrDiskCache()
 {
-  assert(wrDiskCache_ == nullptr);
+  assert(!wrDiskCache_);
   size_t limit = option_->getAsInt(PREF_DISK_CACHE);
   if(limit > 0) {
-    wrDiskCache_ = new WrDiskCache(limit);
+    wrDiskCache_ = make_unique<WrDiskCache>(limit);
   }
 }
 

src/RequestGroupMan.h

@@ -103,7 +103,7 @@ private:
   // UriListParser for deferred input.
   std::shared_ptr<UriListParser> uriListParser_;
 
-  WrDiskCache* wrDiskCache_;
+  std::unique_ptr<WrDiskCache> wrDiskCache_;
 
   std::shared_ptr<OpenedFileCounter> openedFileCounter_;
 
@@ -340,7 +340,7 @@ public:
 
   WrDiskCache* getWrDiskCache() const
   {
-    return wrDiskCache_;
+    return wrDiskCache_.get();
   }
 
   // Initializes WrDiskCache according to PREF_DISK_CACHE option.  If

src/SegmentMan.cc

@@ -150,11 +150,12 @@ std::shared_ptr<Segment> SegmentMan::checkoutSegment
   piece->setUsedBySegment(true);
   std::shared_ptr<Segment> segment;
   if(piece->getLength() == 0) {
-    segment.reset(new GrowSegment(piece));
+    segment = std::make_shared<GrowSegment>(piece);
   } else {
-    segment.reset(new PiecedSegment(downloadContext_->getPieceLength(), piece));
+    segment = std::make_shared<PiecedSegment>
+      (downloadContext_->getPieceLength(), piece);
   }
-  std::shared_ptr<SegmentEntry> entry(new SegmentEntry(cuid, segment));
+  auto entry = std::make_shared<SegmentEntry>(cuid, segment);
   usedSegmentEntries_.push_back(entry);
   A2_LOG_DEBUG(fmt("index=%lu, length=%" PRId64 ", segmentLength=%" PRId64 ","
                    " writtenLength=%" PRId64,

src/ServerStatMan.cc

@@ -59,7 +59,7 @@ ServerStatMan::~ServerStatMan() {}
 std::shared_ptr<ServerStat> ServerStatMan::find(const std::string& hostname,
                                              const std::string& protocol) const
 {
-  std::shared_ptr<ServerStat> ss(new ServerStat(hostname, protocol));
+  auto ss = std::make_shared<ServerStat>(hostname, protocol);
   auto i = serverStats_.find(ss);
   if(i == serverStats_.end()) {
     return nullptr;
@@ -193,7 +193,7 @@ bool ServerStatMan::load(const std::string& filename)
     if(m[S_HOST].empty() || m[S_PROTOCOL].empty()) {
       continue;
     }
-    std::shared_ptr<ServerStat> sstat(new ServerStat(m[S_HOST], m[S_PROTOCOL]));
+    auto sstat = std::make_shared<ServerStat>(m[S_HOST], m[S_PROTOCOL]);
 
     uint32_t uintval;
     if(!util::parseUIntNoThrow(uintval, m[S_DL_SPEED])) {

src/SessionSerializer.cc

@@ -77,12 +77,12 @@ bool SessionSerializer::save(const std::string& filename) const
     std::shared_ptr<IOFile> fp;
 #if HAVE_ZLIB
     if (util::endsWith(filename, ".gz")) {
-      fp.reset(new GZipFile(tempFilename.c_str(), IOFile::WRITE));
+      fp = std::make_shared<GZipFile>(tempFilename.c_str(), IOFile::WRITE);
     }
     else
 #endif
     {
-     fp.reset(new BufferedFile(tempFilename.c_str(), IOFile::WRITE));
+      fp = std::make_shared<BufferedFile>(tempFilename.c_str(), IOFile::WRITE);
     }
     if(!*fp) {
       return false;

src/SimpleRandomizer.cc

@@ -41,6 +41,7 @@
 #include <cstring>
 
 #include "a2time.h"
+#include "a2functional.h"
 
 namespace aria2 {
 

src/SocketCore.cc

@@ -355,7 +355,7 @@ std::shared_ptr<SocketCore> SocketCore::acceptConnection() const
   if(fd == (sock_t) -1) {
     throw DL_ABORT_EX(fmt(EX_SOCKET_ACCEPT, errorMsg(errNum).c_str()));
   }
-  std::shared_ptr<SocketCore> sock(new SocketCore(fd, sockType_));
+  auto sock = std::shared_ptr<SocketCore>(new SocketCore(fd, sockType_));
   sock->setNonBlockingMode();
   return sock;
 }

src/UDPTrackerClient.cc

@@ -179,7 +179,7 @@ int UDPTrackerClient::receiveReply
     }
     req->state = UDPT_STA_COMPLETE;
 
-    req->reply.reset(new UDPTrackerReply());
+    req->reply = std::make_shared<UDPTrackerReply>();
     req->reply->action = action;
     req->reply->transactionId = transactionId;
     req->reply->interval = bittorrent::getIntParam(data, 8);
@@ -265,7 +265,7 @@ ssize_t UDPTrackerClient::createRequest
                                               req->remotePort,
                                               now);
     if(!c) {
-      std::shared_ptr<UDPTrackerRequest> creq(new UDPTrackerRequest());
+      auto creq = std::make_shared<UDPTrackerRequest>();
       creq->action = UDPT_ACT_CONNECT;
       creq->remoteAddr = req->remoteAddr;
       creq->remotePort = req->remotePort;

src/UnknownOptionException.cc

@@ -61,8 +61,7 @@ UnknownOptionException::~UnknownOptionException() throw() {}
 
 std::shared_ptr<Exception> UnknownOptionException::copy() const
 {
-  std::shared_ptr<Exception> e(new UnknownOptionException(*this));
+  return std::make_shared<UnknownOptionException>(*this);
-  return e;
 }
 
 } // namespace aria2

src/UriListParser.cc

@@ -53,9 +53,9 @@ namespace aria2 {
 
 UriListParser::UriListParser(const std::string& filename)
 #if HAVE_ZLIB
-  : fp_(new GZipFile(filename.c_str(), IOFile::READ))
+  : fp_(make_unique<GZipFile>(filename.c_str(), IOFile::READ))
 #else
-  : fp_(new BufferedFile(filename.c_str(), IOFile::READ))
+  : fp_(make_unique<BufferedFile>(filename.c_str(), IOFile::READ))
 #endif
 {}
 

src/UriListParser.h

@@ -49,7 +49,7 @@ namespace aria2 {
 
 class UriListParser {
 private:
-  std::shared_ptr<IOFile> fp_;
+  std::unique_ptr<IOFile> fp_;
 
   std::string line_;
 public:

src/aria2api.cc

@@ -69,7 +69,7 @@
 namespace aria2 {
 
 Session::Session(const KeyVals& options)
-  : context(new Context(false, 0, nullptr, options))
+  : context(std::make_shared<Context>(false, 0, nullptr, options))
 {}
 
 Session::~Session()
@@ -270,7 +270,7 @@ int addUri(Session* session,
            int position)
 {
   auto& e = session->context->reqinfo->getDownloadEngine();
-  std::shared_ptr<Option> requestOption(new Option(*e->getOption()));
+  auto requestOption = std::make_shared<Option>(*e->getOption());
   try {
     apiGatherRequestOption(requestOption.get(), options,
                            OptionParser::getInstance());
@@ -299,7 +299,7 @@ int addMetalink(Session* session,
 {
 #ifdef ENABLE_METALINK
   auto& e = session->context->reqinfo->getDownloadEngine();
-  std::shared_ptr<Option> requestOption(new Option(*e->getOption()));
+  auto requestOption = std::make_shared<Option>(*e->getOption());
   std::vector<std::shared_ptr<RequestGroup> > result;
   try {
     apiGatherRequestOption(requestOption.get(), options,
@@ -338,7 +338,7 @@ int addTorrent(Session* session,
 {
 #ifdef ENABLE_BITTORRENT
   auto& e = session->context->reqinfo->getDownloadEngine();
-  std::shared_ptr<Option> requestOption(new Option(*e->getOption()));
+  auto requestOption = std::make_shared<Option>(*e->getOption());
   std::vector<std::shared_ptr<RequestGroup> > result;
   try {
     apiGatherRequestOption(requestOption.get(), options,

src/console.cc

@@ -52,15 +52,14 @@ Console consoleCerr;
 void initConsole(bool suppress)
 {
   if(suppress) {
-    consoleCerr.reset(new NullOutputFile());
+    consoleCout = consoleCerr = std::make_shared<NullOutputFile>();
-    consoleCout.reset(new NullOutputFile());
   } else {
 #ifdef __MINGW32__
-    consoleCout.reset(new WinConsoleFile(STD_OUTPUT_HANDLE));
+    consoleCout = std::make_shared<WinConsoleFile>(STD_OUTPUT_HANDLE);
-    consoleCerr.reset(new WinConsoleFile(STD_ERROR_HANDLE));
+    consoleCerr = std::make_shared<WinConsoleFile>(STD_ERROR_HANDLE);
 #else // !__MINGW32__
-    consoleCout.reset(new BufferedFile(stdout));
+    consoleCout = std::make_shared<BufferedFile>(stdout);
-    consoleCerr.reset(new BufferedFile(stderr));
+    consoleCerr = std::make_shared<BufferedFile>(stderr);
 #endif // !__MINGW32__
   }
 }

src/option_processing.cc

@@ -221,7 +221,7 @@ error_code::Value option_processing(Option& op, bool standalone,
         }
       }
     }
-    std::shared_ptr<Option> confOption(new Option());
+    auto confOption = std::make_shared<Option>();
     oparser->parseDefaultValues(*confOption);
     if(!noConf) {
       std::string cfname =