From 9a98c7197229f4d3ab907c85cdcfb146ad0e5c09 Mon Sep 17 00:00:00 2001
From: Tatsuhiro Tsujikawa <tatsuhiro.t@gmail.com>
Date: Wed, 14 May 2008 13:52:47 +0000
Subject: [PATCH] 2008-05-14  Tatsuhiro Tsujikawa  <tujikawa at rednoah dot
 com>

	Defined "\r\n", "A", "I" as static const std::string
	* src/A2STR.cc
	* src/A2STR.h
	* src/FtpConnection.cc
	* src/FtpConnection.h
---
 ChangeLog            |  8 ++++++++
 src/A2STR.cc         |  2 ++
 src/A2STR.h          |  2 ++
 src/FtpConnection.cc | 13 +++++++++----
 src/FtpConnection.h  |  5 +++++
 5 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ae8222e1..c50c2d2a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-05-14  Tatsuhiro Tsujikawa  <tujikawa at rednoah dot com>
+
+	Defined "\r\n", "A", "I" as static const std::string
+	* src/A2STR.cc
+	* src/A2STR.h
+	* src/FtpConnection.cc
+	* src/FtpConnection.h
+
 2008-05-14  Tatsuhiro Tsujikawa  <tujikawa at rednoah dot com>
 
 	Added COLON_C(".") and used it in Request::parseUrl()
diff --git a/src/A2STR.cc b/src/A2STR.cc
index 1f351e6e..33497572 100644
--- a/src/A2STR.cc
+++ b/src/A2STR.cc
@@ -44,6 +44,8 @@ const std::string A2STR::CR_C("\r");
 
 const std::string A2STR::LF_C("\n");
 
+const std::string A2STR::CRLF("\r\n");
+
 const std::string A2STR::SLASH_C("/");
 
 const std::string A2STR::DOT_C(".");
diff --git a/src/A2STR.h b/src/A2STR.h
index f6babd6b..d8ea881c 100644
--- a/src/A2STR.h
+++ b/src/A2STR.h
@@ -51,6 +51,8 @@ public:
 
   static const std::string LF_C;
 
+  static const std::string CRLF;
+
   static const std::string SLASH_C;
 
   static const std::string DOT_C;
diff --git a/src/FtpConnection.cc b/src/FtpConnection.cc
index e49906a1..d4cf5f33 100644
--- a/src/FtpConnection.cc
+++ b/src/FtpConnection.cc
@@ -46,9 +46,14 @@
 #include "DlRetryEx.h"
 #include "DlAbortEx.h"
 #include "Socket.h"
+#include "A2STR.h"
 
 namespace aria2 {
 
+const std::string FtpConnection::A("A");
+
+const std::string FtpConnection::I("I");
+
 FtpConnection::FtpConnection(int32_t cuid, const SocketHandle& socket,
 			     const RequestHandle& req, const Option* op):
   cuid(cuid), socket(socket), req(req), option(op),
@@ -74,9 +79,9 @@ void FtpConnection::sendType() const
 {
   std::string type;
   if(option->get(PREF_FTP_TYPE) == V_ASCII) {
-    type = "A";
+    type = FtpConnection::A;
   } else {
-    type = "I";
+    type = FtpConnection::I;
   }
   std::string request = "TYPE "+type+"\r\n";
   logger->info(MSG_SENDING_REQUEST, cuid, request.c_str());
@@ -99,7 +104,7 @@ void FtpConnection::sendSize() const
 
 void FtpConnection::sendPasv() const
 {
-  std::string request = "PASV\r\n";
+  static const std::string request("PASV\r\n");
   logger->info(MSG_SENDING_REQUEST, cuid, request.c_str());
   socket->writeData(request);
 }
@@ -170,7 +175,7 @@ bool FtpConnection::isEndOfResponse(unsigned int status, const std::string& resp
       return false;
     }
   }
-  if(Util::endsWith(response, "\r\n")) {
+  if(Util::endsWith(response, A2STR::CRLF)) {
     return true;
   } else {
     return false;
diff --git a/src/FtpConnection.h b/src/FtpConnection.h
index 2f1f7709..51fe4039 100644
--- a/src/FtpConnection.h
+++ b/src/FtpConnection.h
@@ -61,6 +61,11 @@ private:
   unsigned int getStatus(const std::string& response) const;
   bool isEndOfResponse(unsigned int status, const std::string& response) const;
   bool bulkReceiveResponse(std::pair<unsigned int, std::string>& response);
+
+  static const std::string A;
+
+  static const std::string I;
+
 public:
   FtpConnection(int32_t cuid, const SharedHandle<SocketCore>& socket,
 		const SharedHandle<Request>& req, const Option* op);