github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

Fixed the bug due to dangling pointers in RequestGroup. 

RequestGroup holds a poitner to btRuntime_ and peerStorage_. After
removing them from BtRegistry, we failed to set 0 to them.  When
program access them, it goes undefined world, such as random crash.
We found this bug when pasuing download and valgrind warned memory
corruption.
pull/1/head
Tatsuhiro Tsujikawa 2011-07-21 23:59:44 +09:00
parent c58f736bb9
commit 97f76b7cf4
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/RequestGroup.cc
View File

@ -1021,6 +1021,8 @@ void RequestGroup::releaseRuntimeResource(DownloadEngine* e)
{ {
#ifdef ENABLE_BITTORRENT #ifdef ENABLE_BITTORRENT
e->getBtRegistry()->remove(gid_); e->getBtRegistry()->remove(gid_);
btRuntime_ = 0;
peerStorage_ = 0;
#endif // ENABLE_BITTORRENT #endif // ENABLE_BITTORRENT
if(pieceStorage_) { if(pieceStorage_) {
pieceStorage_->removeAdvertisedPiece(0); pieceStorage_->removeAdvertisedPiece(0);