github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2009-06-14 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Receive the return value as const reference from
	DownloadContext::getFileEntries().
	* src/DefaultPieceStorage.cc
	* src/RequestGroupMan.cc
	* src/XmlRpcMethodImpl.cc
pull/1/head
Tatsuhiro Tsujikawa 2009-06-14 11:17:20 +00:00
parent 39472a64eb
commit 85db426de5
4 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2009-06-14 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Receive the return value as const reference from
DownloadContext::getFileEntries().
* src/DefaultPieceStorage.cc
* src/RequestGroupMan.cc
* src/XmlRpcMethodImpl.cc
2009-06-14 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2009-06-14 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
DownloadContext now has _fileEntries so that DownloadContext now has _fileEntries so that

2
src/DefaultPieceStorage.cc
View File

@ -420,7 +420,7 @@ size_t DefaultPieceStorage::getInFlightPieceCompletedLength() const
// not unittested // not unittested
void DefaultPieceStorage::setupFileFilter() void DefaultPieceStorage::setupFileFilter()
{ {
std::deque<SharedHandle<FileEntry> > fileEntries = const std::deque<SharedHandle<FileEntry> >& fileEntries =
downloadContext->getFileEntries(); downloadContext->getFileEntries();
bool allSelected = true; bool allSelected = true;
for(std::deque<SharedHandle<FileEntry> >::const_iterator i = for(std::deque<SharedHandle<FileEntry> >::const_iterator i =

4
src/RequestGroupMan.cc
View File

@ -670,7 +670,7 @@ bool RequestGroupMan::isSameFileBeingDownloaded(RequestGroup* requestGroup) cons
for(RequestGroups::const_iterator itr = _requestGroups.begin(); for(RequestGroups::const_iterator itr = _requestGroups.begin();
itr != _requestGroups.end(); ++itr) { itr != _requestGroups.end(); ++itr) {
if((*itr).get() != requestGroup) { if((*itr).get() != requestGroup) {
std::deque<SharedHandle<FileEntry> > entries = const std::deque<SharedHandle<FileEntry> >& entries =
(*itr)->getDownloadContext()->getFileEntries(); (*itr)->getDownloadContext()->getFileEntries();
std::transform(entries.begin(), entries.end(), std::transform(entries.begin(), entries.end(),
std::back_inserter(files), std::back_inserter(files),
@ -678,7 +678,7 @@ bool RequestGroupMan::isSameFileBeingDownloaded(RequestGroup* requestGroup) cons
} }
} }
std::sort(files.begin(), files.end()); std::sort(files.begin(), files.end());
std::deque<SharedHandle<FileEntry> > entries = const std::deque<SharedHandle<FileEntry> >& entries =
requestGroup->getDownloadContext()->getFileEntries(); requestGroup->getDownloadContext()->getFileEntries();
return sameFilePathExists(files.begin(), files.end(), return sameFilePathExists(files.begin(), files.end(),
entries.begin(), entries.end()); entries.begin(), entries.end());

2
src/XmlRpcMethodImpl.cc
View File

@ -396,7 +396,7 @@ BDE GetFilesXmlRpcMethod::process
createFileEntry(files, dr->fileEntries.begin(), dr->fileEntries.end()); createFileEntry(files, dr->fileEntries.begin(), dr->fileEntries.end());
} }
} else { } else {
std::deque<SharedHandle<FileEntry> > fileEntries = const std::deque<SharedHandle<FileEntry> >& fileEntries =
group->getDownloadContext()->getFileEntries(); group->getDownloadContext()->getFileEntries();
createFileEntry(files, fileEntries.begin(), fileEntries.end()); createFileEntry(files, fileEntries.begin(), fileEntries.end());
} }