2009-06-14 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>

Receive the return value as const reference from
	DownloadContext::getFileEntries().
	* src/DefaultPieceStorage.cc
	* src/RequestGroupMan.cc
	* src/XmlRpcMethodImpl.cc

ChangeLog

@@ -1,3 +1,11 @@
+2009-06-14  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
+
+	Receive the return value as const reference from
+	DownloadContext::getFileEntries().
+	* src/DefaultPieceStorage.cc
+	* src/RequestGroupMan.cc
+	* src/XmlRpcMethodImpl.cc
+
 2009-06-14  Tatsuhiro Tsujikawa  <t-tujikawa@users.sourceforge.net>
 
 	DownloadContext now has _fileEntries so that

src/DefaultPieceStorage.cc

@@ -420,7 +420,7 @@ size_t DefaultPieceStorage::getInFlightPieceCompletedLength() const
 // not unittested
 void DefaultPieceStorage::setupFileFilter()
 {
-  std::deque<SharedHandle<FileEntry> > fileEntries =
+  const std::deque<SharedHandle<FileEntry> >& fileEntries =
     downloadContext->getFileEntries();
   bool allSelected = true;
   for(std::deque<SharedHandle<FileEntry> >::const_iterator i =

src/RequestGroupMan.cc

@@ -670,7 +670,7 @@ bool RequestGroupMan::isSameFileBeingDownloaded(RequestGroup* requestGroup) cons
   for(RequestGroups::const_iterator itr = _requestGroups.begin();
       itr != _requestGroups.end(); ++itr) {
     if((*itr).get() != requestGroup) {
-      std::deque<SharedHandle<FileEntry> > entries =
+      const std::deque<SharedHandle<FileEntry> >& entries =
 	(*itr)->getDownloadContext()->getFileEntries();
       std::transform(entries.begin(), entries.end(),
 		     std::back_inserter(files),
@@ -678,7 +678,7 @@ bool RequestGroupMan::isSameFileBeingDownloaded(RequestGroup* requestGroup) cons
     }
   }
   std::sort(files.begin(), files.end());
-  std::deque<SharedHandle<FileEntry> > entries =
+  const std::deque<SharedHandle<FileEntry> >& entries =
     requestGroup->getDownloadContext()->getFileEntries();
   return sameFilePathExists(files.begin(), files.end(),
 			    entries.begin(), entries.end());

src/XmlRpcMethodImpl.cc

@@ -396,7 +396,7 @@ BDE GetFilesXmlRpcMethod::process
       createFileEntry(files, dr->fileEntries.begin(), dr->fileEntries.end());
     }
   } else {
-    std::deque<SharedHandle<FileEntry> > fileEntries =
+    const std::deque<SharedHandle<FileEntry> >& fileEntries =
       group->getDownloadContext()->getFileEntries();
     createFileEntry(files, fileEntries.begin(), fileEntries.end());
   }