diff --git a/ChangeLog b/ChangeLog index 777fef85..3263e686 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2008-05-07 Tatsuhiro Tsujikawa + + Receive content body of 302 response so that the connection can be + reused later when http keep-alive is enabled. + * src/HttpNullDownloadCommand.cc + * src/HttpNullDownloadCommand.h + * src/HttpResponseCommand.cc + * src/HttpResponseCommand.h + 2008-05-07 Tatsuhiro Tsujikawa const SharedHandle -> const SharedHandle& diff --git a/src/HttpNullDownloadCommand.cc b/src/HttpNullDownloadCommand.cc new file mode 100644 index 00000000..a8f5098f --- /dev/null +++ b/src/HttpNullDownloadCommand.cc @@ -0,0 +1,115 @@ +/* */ +#include "HttpNullDownloadCommand.h" +#include "HttpConnection.h" +#include "HttpResponse.h" +#include "message.h" +#include "SocketCore.h" +#include "TransferEncoding.h" +#include "DlRetryEx.h" +#include "Request.h" +#include "DownloadEngine.h" +#include "Logger.h" +#include "HttpRequest.h" +#include "Segment.h" + +namespace aria2 { + +HttpNullDownloadCommand::HttpNullDownloadCommand +(int cuid, + const SharedHandle& req, + RequestGroup* requestGroup, + const SharedHandle& httpConnection, + const SharedHandle& httpResponse, + DownloadEngine* e, + const SharedHandle& s): + AbstractCommand(cuid, req, requestGroup, e, s), + _httpConnection(httpConnection), + _httpResponse(httpResponse), + _totalLength(_httpResponse->getEntityLength()), + _receivedBytes(0) +{} + +HttpNullDownloadCommand::~HttpNullDownloadCommand() {} + +void HttpNullDownloadCommand::setTransferDecoder +(const SharedHandle& transferDecoder) +{ + _transferDecoder = transferDecoder; +} + +bool HttpNullDownloadCommand::executeInternal() +{ + const size_t BUFSIZE = 16*1024; + unsigned char buf[BUFSIZE]; + size_t bufSize = BUFSIZE; + socket->readData(buf, bufSize); + + if(_transferDecoder.isNull()) { + _receivedBytes += bufSize; + } else { + // _receivedBytes is not updated if transferEncoding is set. + size_t infbufSize = 16*1024; + unsigned char infbuf[infbufSize]; + _transferDecoder->inflate(infbuf, infbufSize, buf, bufSize); + } + if(_totalLength != 0 && bufSize == 0) { + throw DlRetryEx(EX_GOT_EOF); + } + + if(bufSize == 0) { + // Since this method is called by DownloadEngine only when the socket is + // readable, bufSize == 0 means server shutdown the connection. + // So socket cannot be reused in this case. + return prepareForRetry(0); + } else if((!_transferDecoder.isNull() && _transferDecoder->finished()) + || (_transferDecoder.isNull() && _totalLength == _receivedBytes)) { + if(!_transferDecoder.isNull()) _transferDecoder->end(); + + if(req->supportsPersistentConnection()) { + std::pair peerInfo; + socket->getPeerInfo(peerInfo); + e->poolSocket(peerInfo.first, peerInfo.second, socket); + } + _httpResponse->processRedirect(); + logger->info(MSG_REDIRECT, cuid, _httpResponse->getRedirectURI().c_str()); + return prepareForRetry(0); + } else { + e->commands.push_back(this); + return false; + } +} + +} // namespace aria2 diff --git a/src/HttpNullDownloadCommand.h b/src/HttpNullDownloadCommand.h new file mode 100644 index 00000000..8860ee4a --- /dev/null +++ b/src/HttpNullDownloadCommand.h @@ -0,0 +1,75 @@ +/* */ +#ifndef _D_HTTP_NULL_DOWNLOAD_COMMAND_H_ +#define _D_HTTP_NULL_DOWNLOAD_COMMAND_H_ + +#include "AbstractCommand.h" + +namespace aria2 { + +class HttpConnection; +class HttpResponse; +class TransferEncoding; + +class HttpNullDownloadCommand : public AbstractCommand { +private: + SharedHandle _httpConnection; + + SharedHandle _httpResponse; + + SharedHandle _transferDecoder; + + uint64_t _totalLength; + + uint64_t _receivedBytes; +protected: + virtual bool executeInternal(); +public: + HttpNullDownloadCommand(int cuid, + const SharedHandle& req, + RequestGroup* requestGroup, + const SharedHandle& httpConnection, + const SharedHandle& httpResponse, + DownloadEngine* e, + const SharedHandle& s); + + virtual ~HttpNullDownloadCommand(); + + void setTransferDecoder(const SharedHandle& transferDecoder); +}; + +} // namespace aria2 + +#endif // _D_HTTP_NULL_DOWNLOAD_COMMAND_H_ diff --git a/src/HttpResponseCommand.cc b/src/HttpResponseCommand.cc index d19acd95..55c2a4fb 100644 --- a/src/HttpResponseCommand.cc +++ b/src/HttpResponseCommand.cc @@ -60,6 +60,7 @@ #include "message.h" #include "prefs.h" #include "StringFormat.h" +#include "HttpNullDownloadCommand.h" namespace aria2 { @@ -88,11 +89,24 @@ bool HttpResponseCommand::executeInternal() httpResponse->retrieveCookie(); // check whether Location header exists. If it does, update request object // with redirected URL. - // then establish a connection to the new host and port if(httpResponse->isRedirect()) { - httpResponse->processRedirect(); - logger->info(MSG_REDIRECT, cuid, httpResponse->getRedirectURI().c_str()); - return prepareForRetry(0); + // To reuse a connection, a response body must be received. + if(req->supportsPersistentConnection() && + (httpResponse->getEntityLength() > 0 || + httpResponse->isTransferEncodingSpecified())) { + return handleRedirect(httpResponse); + } else { + // Response body is 0 length or a response header shows that a persistent + // connection is not enabled. + if(req->supportsPersistentConnection()) { + std::pair peerInfo; + socket->getPeerInfo(peerInfo); + e->poolSocket(peerInfo.first, peerInfo.second, socket); + } + httpResponse->processRedirect(); + logger->info(MSG_REDIRECT, cuid, httpResponse->getRedirectURI().c_str()); + return prepareForRetry(0); + } } if(!_requestGroup->isSingleHostMultiConnectionEnabled()) { _requestGroup->removeURIWhoseHostnameIs(_requestGroup->searchServerHost(cuid)->getHostname()); @@ -179,7 +193,8 @@ bool HttpResponseCommand::handleOtherEncoding(const HttpResponseHandle& httpResp return true; } -HttpDownloadCommand* HttpResponseCommand::createHttpDownloadCommand(const HttpResponseHandle& httpResponse) +static SharedHandle getTransferEncoding +(const SharedHandle& httpResponse) { TransferEncodingHandle enc; if(httpResponse->isTransferEncodingSpecified()) { @@ -191,6 +206,23 @@ HttpDownloadCommand* HttpResponseCommand::createHttpDownloadCommand(const HttpRe } enc->init(); } + return enc; +} + +bool HttpResponseCommand::handleRedirect +(const SharedHandle& httpResponse) +{ + SharedHandle enc(getTransferEncoding(httpResponse)); + HttpNullDownloadCommand* command = new HttpNullDownloadCommand + (cuid, req, _requestGroup, httpConnection, httpResponse, e, socket); + command->setTransferDecoder(enc); + e->commands.push_back(command); + return true; +} + +HttpDownloadCommand* HttpResponseCommand::createHttpDownloadCommand(const HttpResponseHandle& httpResponse) +{ + TransferEncodingHandle enc(getTransferEncoding(httpResponse)); HttpDownloadCommand* command = new HttpDownloadCommand(cuid, req, _requestGroup, httpConnection, e, socket); command->setMaxDownloadSpeedLimit(e->option->getAsInt(PREF_MAX_DOWNLOAD_LIMIT)); diff --git a/src/HttpResponseCommand.h b/src/HttpResponseCommand.h index 25d2cd80..19940264 100644 --- a/src/HttpResponseCommand.h +++ b/src/HttpResponseCommand.h @@ -50,6 +50,8 @@ private: bool handleDefaultEncoding(const SharedHandle& httpResponse); bool handleOtherEncoding(const SharedHandle& httpResponse); + bool handleRedirect(const SharedHandle& httpResponse); + HttpDownloadCommand* createHttpDownloadCommand(const SharedHandle& httpResponse); protected: bool executeInternal();