2010-06-11 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>

Made protected member variable private. Added accessor funcs.
	* src/AbstractAuthResolver.h
	* src/DefaultAuthResolver.cc
	* src/DefaultAuthResolver.h
	* src/NetrcAuthResolver.cc
	* src/NetrcAuthResolver.h
pull/1/head
Tatsuhiro Tsujikawa 2010-06-11 12:01:37 +00:00
parent 812563bb6d
commit 4c719530d9
6 changed files with 27 additions and 22 deletions

View File

@ -1,3 +1,12 @@
2010-06-11 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Made protected member variable private. Added accessor funcs.
* src/AbstractAuthResolver.h
* src/DefaultAuthResolver.cc
* src/DefaultAuthResolver.h
* src/NetrcAuthResolver.cc
* src/NetrcAuthResolver.h
2010-06-11 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2010-06-11 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Made protected member variable private. Added accessor funcs. Made protected member variable private. Added accessor funcs.

View File

@ -40,12 +40,10 @@
namespace aria2 { namespace aria2 {
class AbstractAuthResolver : public AuthResolver { class AbstractAuthResolver : public AuthResolver {
protected: private:
SharedHandle<AuthConfig> _userDefinedAuthConfig; SharedHandle<AuthConfig> _userDefinedAuthConfig;
SharedHandle<AuthConfig> _defaultAuthConfig; SharedHandle<AuthConfig> _defaultAuthConfig;
public: public:
AbstractAuthResolver(); AbstractAuthResolver();

View File

@ -37,14 +37,13 @@
namespace aria2 { namespace aria2 {
DefaultAuthResolver::~DefaultAuthResolver() {} AuthConfigHandle DefaultAuthResolver::resolveAuthConfig
(const std::string& hostname)
AuthConfigHandle DefaultAuthResolver::resolveAuthConfig(const std::string& hostname)
{ {
if(_userDefinedAuthConfig.isNull()) { if(getUserDefinedAuthConfig().isNull()) {
return _defaultAuthConfig; return getDefaultAuthConfig();
} else { } else {
return _userDefinedAuthConfig; return getUserDefinedAuthConfig();
} }
} }

View File

@ -41,9 +41,8 @@ namespace aria2 {
class DefaultAuthResolver : public AbstractAuthResolver { class DefaultAuthResolver : public AbstractAuthResolver {
public: public:
virtual ~DefaultAuthResolver(); virtual SharedHandle<AuthConfig> resolveAuthConfig
(const std::string& hostname);
virtual SharedHandle<AuthConfig> resolveAuthConfig(const std::string& hostname);
}; };
typedef SharedHandle<DefaultAuthResolver> DefaultAuthResolverHandle; typedef SharedHandle<DefaultAuthResolver> DefaultAuthResolverHandle;

View File

@ -43,10 +43,10 @@ NetrcAuthResolver::NetrcAuthResolver():_ignoreDefault(false) {}
SharedHandle<AuthConfig> SharedHandle<AuthConfig>
NetrcAuthResolver::resolveAuthConfig(const std::string& hostname) NetrcAuthResolver::resolveAuthConfig(const std::string& hostname)
{ {
if(_userDefinedAuthConfig.isNull()) { if(getUserDefinedAuthConfig().isNull()) {
return findNetrcAuthenticator(hostname); return findNetrcAuthenticator(hostname);
} else { } else {
return _userDefinedAuthConfig; return getUserDefinedAuthConfig();
} }
} }
@ -54,14 +54,14 @@ SharedHandle<AuthConfig>
NetrcAuthResolver::findNetrcAuthenticator(const std::string& hostname) const NetrcAuthResolver::findNetrcAuthenticator(const std::string& hostname) const
{ {
if(_netrc.isNull()) { if(_netrc.isNull()) {
return _defaultAuthConfig; return getDefaultAuthConfig();
} else { } else {
SharedHandle<Authenticator> auth = _netrc->findAuthenticator(hostname); SharedHandle<Authenticator> auth = _netrc->findAuthenticator(hostname);
if(auth.isNull()) { if(auth.isNull()) {
return _defaultAuthConfig; return getDefaultAuthConfig();
} else { } else {
if(_ignoreDefault && auth->getMachine() == "") { if(_ignoreDefault && auth->getMachine().empty()) {
return _defaultAuthConfig; return getDefaultAuthConfig();
} else { } else {
return SharedHandle<AuthConfig> return SharedHandle<AuthConfig>
(new AuthConfig(auth->getLogin(), auth->getPassword())); (new AuthConfig(auth->getLogin(), auth->getPassword()));

View File

@ -47,13 +47,13 @@ private:
bool _ignoreDefault; bool _ignoreDefault;
SharedHandle<AuthConfig> findNetrcAuthenticator(const std::string& hostname) const; SharedHandle<AuthConfig> findNetrcAuthenticator
(const std::string& hostname) const;
public: public:
NetrcAuthResolver(); NetrcAuthResolver();
virtual ~NetrcAuthResolver() {} virtual SharedHandle<AuthConfig> resolveAuthConfig
(const std::string& hostname);
virtual SharedHandle<AuthConfig> resolveAuthConfig(const std::string& hostname);
void setNetrc(const SharedHandle<Netrc>& netrc); void setNetrc(const SharedHandle<Netrc>& netrc);