github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2009-09-29 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Limit the size of values list when sending get_peers reply.
	* src/DHTGetPeersReplyMessage.cc
pull/1/head
Tatsuhiro Tsujikawa 2009-09-28 16:05:08 +00:00
parent 1cd092f6a1
commit 2e8b0d785e
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2009-09-29 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Limit the size of values list when sending get_peers reply.
* src/DHTGetPeersReplyMessage.cc
2009-09-29 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2009-09-29 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Updated banner Updated banner

14
src/DHTGetPeersReplyMessage.cc
View File

@ -92,9 +92,21 @@ BDE DHTGetPeersReplyMessage::getResponse()
} }
rDict[NODES] = BDE(buffer, offset); rDict[NODES] = BDE(buffer, offset);
} else { } else {
// Limit the size of values list. The maxmum payload size of UDP
// packet is limited to 65507bytes. aria2 uses 20bytes token and
// 2byte transaction ID. The size of get_peers reply message
// without values list is 87bytes:
//
// d1:rd2:id20:aaaaaaaaaaaaaaaaaaaa5:token20:aaaaaaaaaaaaaaaaaaaa
// 6:valueslee1:t2:bb1:y1:re
//
// With this configuration, We can send (65507-87)/8 = 8177
// values. Since the size of token and transaction ID may vary in
// implementations, we use 8100.
static const size_t MAX_VALUES_SIZE = 8100;
BDE valuesList = BDE::list(); BDE valuesList = BDE::list();
for(std::deque<SharedHandle<Peer> >::const_iterator i = _values.begin(); for(std::deque<SharedHandle<Peer> >::const_iterator i = _values.begin();
i != _values.end(); ++i) { i != _values.end() && valuesList.size() < MAX_VALUES_SIZE; ++i) {
const SharedHandle<Peer>& peer = *i; const SharedHandle<Peer>& peer = *i;
unsigned char buffer[6]; unsigned char buffer[6];
if(PeerMessageUtil::createcompact(buffer, peer->ipaddr, peer->port)) { if(PeerMessageUtil::createcompact(buffer, peer->ipaddr, peer->port)) {