diff --git a/src/CheckIntegrityMan.cc b/src/CheckIntegrityMan.cc deleted file mode 100644 index 1a7f438a..00000000 --- a/src/CheckIntegrityMan.cc +++ /dev/null @@ -1,53 +0,0 @@ -/* */ -#include "CheckIntegrityMan.h" -#include "CheckIntegrityEntry.h" - -namespace aria2 { - -bool CheckIntegrityMan::isPicked(std::shared_ptr rg) { - return pickedEntry_ && rg && pickedEntry_->getRequestGroup() == rg.get(); -} - -bool CheckIntegrityMan::isQueued(std::shared_ptr rg) { - bool found = false; - for(auto& e : entries_) { - if(e && rg && e->getRequestGroup() == rg.get()) - found = true; - } - return found; -} - -} diff --git a/src/CheckIntegrityMan.h b/src/CheckIntegrityMan.h index 611910aa..2ea3b097 100644 --- a/src/CheckIntegrityMan.h +++ b/src/CheckIntegrityMan.h @@ -41,15 +41,8 @@ namespace aria2 { class CheckIntegrityEntry; -class RequestGroup; -class CheckIntegrityMan : public SequentialPicker { -public: - bool isPicked(std::shared_ptr rg); - bool isQueued(std::shared_ptr rg); -}; - -// typedef SequentialPicker CheckIntegrityMan; +typedef SequentialPicker CheckIntegrityMan; } // namespace aria2 diff --git a/src/Makefile.am b/src/Makefile.am index d87a31c4..8614834a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -39,7 +39,7 @@ SRCS = \ CheckIntegrityCommand.cc CheckIntegrityCommand.h\ CheckIntegrityDispatcherCommand.cc CheckIntegrityDispatcherCommand.h\ CheckIntegrityEntry.cc CheckIntegrityEntry.h\ - CheckIntegrityMan.cc CheckIntegrityMan.h\ + CheckIntegrityMan.h\ Checksum.cc Checksum.h\ ChecksumCheckIntegrityEntry.cc ChecksumCheckIntegrityEntry.h\ ChunkChecksum.cc ChunkChecksum.h\ diff --git a/src/RequestGroupEntry.h b/src/RequestGroupEntry.h index 7a1416c7..7484bf48 100644 --- a/src/RequestGroupEntry.h +++ b/src/RequestGroupEntry.h @@ -37,7 +37,6 @@ #include "common.h" -#include "Command.h" #include namespace aria2 { diff --git a/src/RpcMethodImpl.cc b/src/RpcMethodImpl.cc index cdb4fb1f..d808d83c 100644 --- a/src/RpcMethodImpl.cc +++ b/src/RpcMethodImpl.cc @@ -796,13 +796,22 @@ void gatherProgress(Dict* entryDict, const std::shared_ptr& group, e->getBtRegistry()->get(group->getGID()), keys); } #endif // ENABLE_BITTORRENT - if (e && e->getCheckIntegrityMan()) { - if (e->getCheckIntegrityMan()->isPicked(group)) { - entryDict->put(KEY_VERIFIED_LENGTH, util::itos(e->getCheckIntegrityMan()->getPickedEntry()->getCurrentLength())); - } - if (e->getCheckIntegrityMan()->isQueued(group)) { - entryDict->put(KEY_VERIFY_PENDING, VLB_TRUE); - } + if (e->getCheckIntegrityMan()) { + if (e->getCheckIntegrityMan()->isPicked( + [&group](const CheckIntegrityEntry& ent) { + return ent.getRequestGroup() == group.get(); + })) { + entryDict->put( + KEY_VERIFIED_LENGTH, + util::itos( + e->getCheckIntegrityMan()->getPickedEntry()->getCurrentLength())); + } + if (e->getCheckIntegrityMan()->isQueued( + [&group](const CheckIntegrityEntry& ent) { + return ent.getRequestGroup() == group.get(); + })) { + entryDict->put(KEY_VERIFY_PENDING, VLB_TRUE); + } } } } // namespace diff --git a/src/SequentialPicker.h b/src/SequentialPicker.h index c464be78..eb4489b0 100644 --- a/src/SequentialPicker.h +++ b/src/SequentialPicker.h @@ -43,7 +43,7 @@ namespace aria2 { template class SequentialPicker { -protected: +private: std::deque> entries_; std::unique_ptr pickedEntry_; @@ -72,6 +72,21 @@ public: } size_t countEntryInQueue() const { return entries_.size(); } + + bool isPicked(const std::function& pred) const + { + return pickedEntry_ && pred(*pickedEntry_); + } + + bool isQueued(const std::function& pred) const + { + for (auto& e : entries_) { + if (pred(*e)) { + return true; + } + } + return false; + } }; } // namespace aria2