github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2010-06-26 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Code cleanup
	* src/util.cc
pull/1/head
Tatsuhiro Tsujikawa 2010-06-26 14:03:14 +00:00
parent 9d0eb8c08b
commit 2deed225e4
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2010-06-26 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Code cleanup
* src/util.cc
2010-06-26 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2010-06-26 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Removed unused getOverflow(). Added assertion in Removed unused getOverflow(). Added assertion in

8
src/util.cc
View File

@ -396,7 +396,7 @@ std::string fromHex(const std::string& src)
if(src.size()%2) { if(src.size()%2) {
return dest; return dest;
} }
for(size_t i = 0; i < src.size(); i += 2) { for(size_t i = 0, eoi = src.size(); i < eoi; i += 2) {
unsigned char high = hexCharToUInt(src[i]); unsigned char high = hexCharToUInt(src[i]);
unsigned char low = hexCharToUInt(src[i+1]); unsigned char low = hexCharToUInt(src[i+1]);
if(high == 255 || low == 255) { if(high == 255 || low == 255) {
@ -1003,7 +1003,7 @@ bool isLowercase(const std::string& what)
if(what.empty()) { if(what.empty()) {
return false; return false;
} }
for(uint32_t i = 0; i < what.size(); ++i) { for(uint32_t i = 0, eoi = what.size(); i < eoi; ++i) {
if(!('a' <= what[i] && what[i] <= 'z')) { if(!('a' <= what[i] && what[i] <= 'z')) {
return false; return false;
} }
@ -1016,7 +1016,7 @@ bool isUppercase(const std::string& what)
if(what.empty()) { if(what.empty()) {
return false; return false;
} }
for(uint32_t i = 0; i < what.size(); ++i) { for(uint32_t i = 0, eoi = what.size(); i < eoi; ++i) {
if(!('A' <= what[i] && what[i] <= 'Z')) { if(!('A' <= what[i] && what[i] <= 'Z')) {
return false; return false;
} }
@ -1036,7 +1036,7 @@ unsigned int alphaToNum(const std::string& alphabets)
base = 'A'; base = 'A';
} }
uint64_t num = 0; uint64_t num = 0;
for(size_t i = 0; i < alphabets.size(); ++i) { for(size_t i = 0, eoi = alphabets.size(); i < eoi; ++i) {
unsigned int v = alphabets[i]-base; unsigned int v = alphabets[i]-base;
num = num*26+v; num = num*26+v;
if(num > UINT32_MAX) { if(num > UINT32_MAX) {