From 2417225023d1bc94d994a639c7251ec6aa588f5f Mon Sep 17 00:00:00 2001 From: Kurt Kartaltepe Date: Wed, 16 Mar 2016 00:27:09 -0500 Subject: [PATCH] Report CheckIntegrity info in tellStatus - Adds verifiedLength to tellStatus. Reports the length of data that has been verified of the current RequestGroup being verified. - Adds verifyPending to tellStatus. Reports if the RequestGroup has a verification of integrity pending. Closes #561 --- src/CheckIntegrityMan.cc | 53 ++++++++++++++++++++++++++++++++++++++++ src/CheckIntegrityMan.h | 9 ++++++- src/Makefile.am | 2 +- src/RequestGroupEntry.h | 1 + src/RpcMethodImpl.cc | 11 +++++++++ src/RpcMethodImpl.h | 1 + src/SequentialPicker.h | 2 +- 7 files changed, 76 insertions(+), 3 deletions(-) create mode 100644 src/CheckIntegrityMan.cc diff --git a/src/CheckIntegrityMan.cc b/src/CheckIntegrityMan.cc new file mode 100644 index 00000000..1a7f438a --- /dev/null +++ b/src/CheckIntegrityMan.cc @@ -0,0 +1,53 @@ +/* */ +#include "CheckIntegrityMan.h" +#include "CheckIntegrityEntry.h" + +namespace aria2 { + +bool CheckIntegrityMan::isPicked(std::shared_ptr rg) { + return pickedEntry_ && rg && pickedEntry_->getRequestGroup() == rg.get(); +} + +bool CheckIntegrityMan::isQueued(std::shared_ptr rg) { + bool found = false; + for(auto& e : entries_) { + if(e && rg && e->getRequestGroup() == rg.get()) + found = true; + } + return found; +} + +} diff --git a/src/CheckIntegrityMan.h b/src/CheckIntegrityMan.h index 2ea3b097..611910aa 100644 --- a/src/CheckIntegrityMan.h +++ b/src/CheckIntegrityMan.h @@ -41,8 +41,15 @@ namespace aria2 { class CheckIntegrityEntry; +class RequestGroup; -typedef SequentialPicker CheckIntegrityMan; +class CheckIntegrityMan : public SequentialPicker { +public: + bool isPicked(std::shared_ptr rg); + bool isQueued(std::shared_ptr rg); +}; + +// typedef SequentialPicker CheckIntegrityMan; } // namespace aria2 diff --git a/src/Makefile.am b/src/Makefile.am index 629218bb..6ca448cb 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -39,7 +39,7 @@ SRCS = \ CheckIntegrityCommand.cc CheckIntegrityCommand.h\ CheckIntegrityDispatcherCommand.cc CheckIntegrityDispatcherCommand.h\ CheckIntegrityEntry.cc CheckIntegrityEntry.h\ - CheckIntegrityMan.h\ + CheckIntegrityMan.cc CheckIntegrityMan.h\ Checksum.cc Checksum.h\ ChecksumCheckIntegrityEntry.cc ChecksumCheckIntegrityEntry.h\ ChunkChecksum.cc ChunkChecksum.h\ diff --git a/src/RequestGroupEntry.h b/src/RequestGroupEntry.h index 7484bf48..7a1416c7 100644 --- a/src/RequestGroupEntry.h +++ b/src/RequestGroupEntry.h @@ -37,6 +37,7 @@ #include "common.h" +#include "Command.h" #include namespace aria2 { diff --git a/src/RpcMethodImpl.cc b/src/RpcMethodImpl.cc index 5d6e8202..42fdb8c6 100644 --- a/src/RpcMethodImpl.cc +++ b/src/RpcMethodImpl.cc @@ -77,6 +77,7 @@ #include "BtRuntime.h" #include "BtAnnounce.h" #endif // ENABLE_BITTORRENT +#include "CheckIntegrityEntry.h" namespace aria2 { @@ -144,6 +145,8 @@ const char KEY_NUM_WAITING[] = "numWaiting"; const char KEY_NUM_STOPPED[] = "numStopped"; const char KEY_NUM_ACTIVE[] = "numActive"; const char KEY_NUM_STOPPED_TOTAL[] = "numStoppedTotal"; +const char KEY_VERIFIED_LENGTH[] = "verifiedLength"; +const char KEY_VERIFY_PENDING[] = "verifyIntegrityPending"; } // namespace namespace { @@ -793,6 +796,14 @@ void gatherProgress(Dict* entryDict, const std::shared_ptr& group, e->getBtRegistry()->get(group->getGID()), keys); } #endif // ENABLE_BITTORRENT + if (e && e->getCheckIntegrityMan()) { + if (e->getCheckIntegrityMan()->isPicked(group)) { + entryDict->put(KEY_VERIFIED_LENGTH, util::itos(e->getCheckIntegrityMan()->getPickedEntry()->getCurrentLength())); + } + if (e->getCheckIntegrityMan()->isQueued(group)) { + entryDict->put(KEY_VERIFY_PENDING, VLB_TRUE); + } + } } } // namespace diff --git a/src/RpcMethodImpl.h b/src/RpcMethodImpl.h index 59f86359..15285859 100644 --- a/src/RpcMethodImpl.h +++ b/src/RpcMethodImpl.h @@ -54,6 +54,7 @@ namespace aria2 { struct DownloadResult; class RequestGroup; +class CheckIntegrityEntry; namespace rpc { diff --git a/src/SequentialPicker.h b/src/SequentialPicker.h index e8485041..c464be78 100644 --- a/src/SequentialPicker.h +++ b/src/SequentialPicker.h @@ -43,7 +43,7 @@ namespace aria2 { template class SequentialPicker { -private: +protected: std::deque> entries_; std::unique_ptr pickedEntry_;