From 236e64cb25a054eed3fa8888168e71d09decf561 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Sat, 30 Oct 2010 16:02:15 +0000 Subject: [PATCH] 2010-10-30 Tatsuhiro Tsujikawa Use unnamed namespace instead of static keyword. * src/AbstractCommand.cc * src/AdaptiveURISelector.cc * src/Base64.cc * src/BitfieldMan.cc * src/BtDependency.cc * src/ConsoleStatCalc.cc * src/ContentTypeRequestGroupCriteria.cc * src/CookieStorage.cc * src/DHTMessageFactoryImpl.cc * src/DHTRoutingTableDeserializer.cc * src/DefaultBtAnnounce.cc * src/DefaultBtProgressInfoFile.cc * src/DefaultPeerStorage.cc * src/DefaultPieceStorage.cc * src/DownloadCommand.cc * src/DownloadEngine.cc * src/EpollEventPoll.cc * src/ExpatMetalinkProcessor.cc * src/ExpatXmlRpcRequestProcessor.cc * src/FileEntry.cc * src/HttpRequest.cc * src/HttpRequestCommand.cc * src/HttpResponseCommand.cc * src/KqueueEventPoll.cc * src/LongestSequencePieceSelector.cc * src/MetalinkParserStateV3Impl.cc * src/MetalinkParserStateV4Impl.cc * src/MultiDiskAdaptor.cc * src/MultiUrlRequestInfo.cc * src/OptionParser.cc * src/PeerSessionResource.cc * src/PortEventPoll.cc * src/Request.cc * src/RequestGroupMan.cc * src/SelectEventPoll.cc * src/SessionSerializer.cc * src/SimpleLogFormatter.cc * src/Sqlite3CookieParser.cc * src/TrackerWatcherCommand.cc * src/XML2SAXMetalinkProcessor.cc * src/Xml2XmlRpcRequestProcessor.cc * src/XmlRpcMethod.cc * src/XmlRpcMethodImpl.cc * src/XmlRpcResponse.cc * src/base32.cc * src/bencode2.cc * src/bittorrent_helper.cc * src/download_helper.cc * src/main.cc * src/messageDigest.cc * src/option_processing.cc * src/util.cc * test/AnnounceListTest.cc * test/BtRegistryTest.cc * test/DHTBucketTest.cc * test/DHTRoutingTableTest.cc * test/DefaultBtAnnounceTest.cc * test/FileEntryTest.cc * test/FtpConnectionTest.cc * test/MSEHandshakeTest.cc * test/MagnetTest.cc * test/XmlRpcMethodTest.cc * test/array_funTest.cc --- ChangeLog | 67 ++++++++++++++++++ src/AbstractCommand.cc | 18 +++-- src/AdaptiveURISelector.cc | 4 +- src/Base64.cc | 8 ++- src/BitfieldMan.cc | 20 ++++-- src/BtDependency.cc | 6 +- src/ConsoleStatCalc.cc | 8 ++- src/ContentTypeRequestGroupCriteria.cc | 4 +- src/CookieStorage.cc | 6 +- src/DHTMessageFactoryImpl.cc | 32 ++++++--- src/DHTRoutingTableDeserializer.cc | 6 +- src/DefaultBtAnnounce.cc | 4 +- src/DefaultBtProgressInfoFile.cc | 4 +- src/DefaultPeerStorage.cc | 12 +++- src/DefaultPieceStorage.cc | 6 +- src/DownloadCommand.cc | 4 +- src/DownloadEngine.cc | 10 ++- src/EpollEventPoll.cc | 4 +- src/ExpatMetalinkProcessor.cc | 24 +++++-- src/ExpatXmlRpcRequestProcessor.cc | 12 +++- src/FileEntry.cc | 9 ++- src/HttpRequest.cc | 4 +- src/HttpRequestCommand.cc | 4 +- src/HttpResponseCommand.cc | 98 +++++++++++++------------- src/KqueueEventPoll.cc | 4 +- src/LongestSequencePieceSelector.cc | 8 ++- src/MetalinkParserStateV3Impl.cc | 4 +- src/MetalinkParserStateV4Impl.cc | 4 +- src/MultiDiskAdaptor.cc | 25 ++++--- src/MultiUrlRequestInfo.cc | 4 +- src/OptionParser.cc | 18 +++-- src/PeerSessionResource.cc | 4 +- src/PortEventPoll.cc | 4 +- src/Request.cc | 17 +++-- src/RequestGroupMan.cc | 24 ++++--- src/SelectEventPoll.cc | 4 +- src/SessionSerializer.cc | 16 +++-- src/SimpleLogFormatter.cc | 4 +- src/Sqlite3CookieParser.cc | 13 ++-- src/TrackerWatcherCommand.cc | 4 +- src/XML2SAXMetalinkProcessor.cc | 16 +++-- src/Xml2XmlRpcRequestProcessor.cc | 18 +++-- src/XmlRpcMethod.cc | 14 ++-- src/XmlRpcMethodImpl.cc | 79 +++++++++++++++------ src/XmlRpcResponse.cc | 8 ++- src/base32.cc | 4 +- src/bencode2.cc | 36 +++++++--- src/bittorrent_helper.cc | 78 ++++++++++++-------- src/download_helper.cc | 38 ++++++---- src/main.cc | 12 +++- src/messageDigest.cc | 4 +- src/option_processing.cc | 8 ++- src/util.cc | 16 +++-- test/AnnounceListTest.cc | 4 +- test/BtRegistryTest.cc | 4 +- test/DHTBucketTest.cc | 4 +- test/DHTRoutingTableTest.cc | 4 +- test/DefaultBtAnnounceTest.cc | 14 ++-- test/FileEntryTest.cc | 4 +- test/FtpConnectionTest.cc | 4 +- test/MSEHandshakeTest.cc | 10 ++- test/MagnetTest.cc | 4 +- test/XmlRpcMethodTest.cc | 15 ++-- test/array_funTest.cc | 16 +++-- 64 files changed, 667 insertions(+), 278 deletions(-) diff --git a/ChangeLog b/ChangeLog index 862b3759..cbc558bf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,70 @@ +2010-10-30 Tatsuhiro Tsujikawa + + Use unnamed namespace instead of static keyword. + * src/AbstractCommand.cc + * src/AdaptiveURISelector.cc + * src/Base64.cc + * src/BitfieldMan.cc + * src/BtDependency.cc + * src/ConsoleStatCalc.cc + * src/ContentTypeRequestGroupCriteria.cc + * src/CookieStorage.cc + * src/DHTMessageFactoryImpl.cc + * src/DHTRoutingTableDeserializer.cc + * src/DefaultBtAnnounce.cc + * src/DefaultBtProgressInfoFile.cc + * src/DefaultPeerStorage.cc + * src/DefaultPieceStorage.cc + * src/DownloadCommand.cc + * src/DownloadEngine.cc + * src/EpollEventPoll.cc + * src/ExpatMetalinkProcessor.cc + * src/ExpatXmlRpcRequestProcessor.cc + * src/FileEntry.cc + * src/HttpRequest.cc + * src/HttpRequestCommand.cc + * src/HttpResponseCommand.cc + * src/KqueueEventPoll.cc + * src/LongestSequencePieceSelector.cc + * src/MetalinkParserStateV3Impl.cc + * src/MetalinkParserStateV4Impl.cc + * src/MultiDiskAdaptor.cc + * src/MultiUrlRequestInfo.cc + * src/OptionParser.cc + * src/PeerSessionResource.cc + * src/PortEventPoll.cc + * src/Request.cc + * src/RequestGroupMan.cc + * src/SelectEventPoll.cc + * src/SessionSerializer.cc + * src/SimpleLogFormatter.cc + * src/Sqlite3CookieParser.cc + * src/TrackerWatcherCommand.cc + * src/XML2SAXMetalinkProcessor.cc + * src/Xml2XmlRpcRequestProcessor.cc + * src/XmlRpcMethod.cc + * src/XmlRpcMethodImpl.cc + * src/XmlRpcResponse.cc + * src/base32.cc + * src/bencode2.cc + * src/bittorrent_helper.cc + * src/download_helper.cc + * src/main.cc + * src/messageDigest.cc + * src/option_processing.cc + * src/util.cc + * test/AnnounceListTest.cc + * test/BtRegistryTest.cc + * test/DHTBucketTest.cc + * test/DHTRoutingTableTest.cc + * test/DefaultBtAnnounceTest.cc + * test/FileEntryTest.cc + * test/FtpConnectionTest.cc + * test/MSEHandshakeTest.cc + * test/MagnetTest.cc + * test/XmlRpcMethodTest.cc + * test/array_funTest.cc + 2010-10-30 Tatsuhiro Tsujikawa Added '// namespace' after end of unnamed namespace. diff --git a/src/AbstractCommand.cc b/src/AbstractCommand.cc index 8fc74f81..c83ef87b 100644 --- a/src/AbstractCommand.cc +++ b/src/AbstractCommand.cc @@ -521,8 +521,9 @@ void AbstractCommand::setWriteCheckSocketIf } } +namespace { // Returns proxy option value for the given protocol. -static const std::string& getProxyOptionFor +const std::string& getProxyOptionFor (const std::string& proxyPref, const SharedHandle