github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2010-05-19 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Code cleanup.
	* src/RequestGroupMan.cc
	* src/UTMetadataPostDownloadHandler.cc
	* src/XmlRpcMethodImpl.cc
pull/1/head
Tatsuhiro Tsujikawa 2010-05-19 14:16:04 +00:00
parent 83465ff83d
commit 2284c0a837
4 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
2010-05-19 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Code cleanup.
* src/RequestGroupMan.cc
* src/UTMetadataPostDownloadHandler.cc
* src/XmlRpcMethodImpl.cc
2010-05-15 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2010-05-15 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Store both whole checksum and piece hash in metalink file. Store both whole checksum and piece hash in metalink file.

2
src/RequestGroupMan.cc
View File

@ -349,7 +349,7 @@ public:
void operator()(const SharedHandle<RequestGroup>& group) void operator()(const SharedHandle<RequestGroup>& group)
{ {
if(group->getNumCommand() == 0) { if(group->getNumCommand() == 0) {
SharedHandle<DownloadContext> dctx = group->getDownloadContext(); const SharedHandle<DownloadContext>& dctx = group->getDownloadContext();
// DownloadContext::resetDownloadStopTime() is only called when // DownloadContext::resetDownloadStopTime() is only called when
// download completed. If // download completed. If
// DownloadContext::getDownloadStopTime().isZero() is true, then // DownloadContext::getDownloadStopTime().isZero() is true, then

4
src/UTMetadataPostDownloadHandler.cc
View File

@ -56,7 +56,7 @@ namespace aria2 {
bool UTMetadataPostDownloadHandler::Criteria::match bool UTMetadataPostDownloadHandler::Criteria::match
(const RequestGroup* requestGroup) const (const RequestGroup* requestGroup) const
{ {
SharedHandle<DownloadContext> dctx = const SharedHandle<DownloadContext>& dctx =
requestGroup->getDownloadContext(); requestGroup->getDownloadContext();
if(dctx->hasAttribute(bittorrent::BITTORRENT)) { if(dctx->hasAttribute(bittorrent::BITTORRENT)) {
const BDE& attrs = dctx->getAttribute(bittorrent::BITTORRENT); const BDE& attrs = dctx->getAttribute(bittorrent::BITTORRENT);
@ -76,7 +76,7 @@ UTMetadataPostDownloadHandler::UTMetadataPostDownloadHandler():
void UTMetadataPostDownloadHandler::getNextRequestGroups void UTMetadataPostDownloadHandler::getNextRequestGroups
(std::vector<SharedHandle<RequestGroup> >& groups, RequestGroup* requestGroup) (std::vector<SharedHandle<RequestGroup> >& groups, RequestGroup* requestGroup)
{ {
SharedHandle<DownloadContext> dctx = requestGroup->getDownloadContext(); const SharedHandle<DownloadContext>& dctx =requestGroup->getDownloadContext();
const BDE& attrs = dctx->getAttribute(bittorrent::BITTORRENT); const BDE& attrs = dctx->getAttribute(bittorrent::BITTORRENT);
std::string metadata = std::string metadata =
util::toString(requestGroup->getPieceStorage()->getDiskAdaptor()); util::toString(requestGroup->getPieceStorage()->getDiskAdaptor());

4
src/XmlRpcMethodImpl.cc
View File

@ -1044,7 +1044,7 @@ BDE GetServersXmlRpcMethod::process
throw DL_ABORT_EX(StringFormat("No active download for GID#%s", throw DL_ABORT_EX(StringFormat("No active download for GID#%s",
util::itos(gid).c_str()).str()); util::itos(gid).c_str()).str());
} }
SharedHandle<DownloadContext> dctx = group->getDownloadContext(); const SharedHandle<DownloadContext>& dctx = group->getDownloadContext();
const std::vector<SharedHandle<FileEntry> >& files = dctx->getFileEntries(); const std::vector<SharedHandle<FileEntry> >& files = dctx->getFileEntries();
BDE result = BDE::list(); BDE result = BDE::list();
size_t index = 1; size_t index = 1;
@ -1099,7 +1099,7 @@ BDE ChangeUriXmlRpcMethod::process
(StringFormat("Cannot remove URIs from GID#%s", (StringFormat("Cannot remove URIs from GID#%s",
util::itos(gid).c_str()).str()); util::itos(gid).c_str()).str());
} }
SharedHandle<DownloadContext> dctx = group->getDownloadContext(); const SharedHandle<DownloadContext>& dctx = group->getDownloadContext();
const std::vector<SharedHandle<FileEntry> >& files = dctx->getFileEntries(); const std::vector<SharedHandle<FileEntry> >& files = dctx->getFileEntries();
if(files.size() <= index) { if(files.size() <= index) {
throw DL_ABORT_EX(StringFormat("fileIndex is out of range").str()); throw DL_ABORT_EX(StringFormat("fileIndex is out of range").str());