Code cleanup

pull/28/head
Tatsuhiro Tsujikawa 2012-09-28 22:00:46 +09:00
parent 1fdc6e0a33
commit 1c57a3ff9f
11 changed files with 119 additions and 123 deletions

View File

@ -45,8 +45,6 @@ public:
(const std::string& hostname); (const std::string& hostname);
}; };
typedef SharedHandle<DefaultAuthResolver> DefaultAuthResolverHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_AUTH_RESOLVER_H #endif // D_DEFAULT_AUTH_RESOLVER_H

View File

@ -264,8 +264,6 @@ public:
} }
}; };
typedef SharedHandle<DefaultBtInteractive> DefaultBtInteractiveHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_BT_INTERACTIVE_H #endif // D_DEFAULT_BT_INTERACTIVE_H

View File

@ -69,7 +69,7 @@ public:
DefaultBtMessageDispatcher(); DefaultBtMessageDispatcher();
virtual ~DefaultBtMessageDispatcher(); virtual ~DefaultBtMessageDispatcher();
virtual void addMessageToQueue(const SharedHandle<BtMessage>& btMessage); virtual void addMessageToQueue(const SharedHandle<BtMessage>& btMessage);
virtual void addMessageToQueue virtual void addMessageToQueue
@ -100,7 +100,7 @@ public:
{ {
return requestSlots_.size(); return requestSlots_.size();
} }
virtual bool isOutstandingRequest(size_t index, size_t blockIndex); virtual bool isOutstandingRequest(size_t index, size_t blockIndex);
virtual RequestSlot getOutstandingRequest virtual RequestSlot getOutstandingRequest
@ -145,8 +145,6 @@ public:
} }
}; };
typedef SharedHandle<DefaultBtMessageDispatcher> DefaultBtMessageDispatcherHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_BT_MESSAGE_DISPATCHER_H #endif // D_DEFAULT_BT_MESSAGE_DISPATCHER_H

View File

@ -74,8 +74,6 @@ public:
void setBtMessageFactory(BtMessageFactory* factory); void setBtMessageFactory(BtMessageFactory* factory);
}; };
typedef SharedHandle<DefaultBtMessageReceiver> DefaultBtMessageReceiverHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_BT_MESSAGE_RECEIVER_H #endif // D_DEFAULT_BT_MESSAGE_RECEIVER_H

View File

@ -105,8 +105,6 @@ public:
} }
}; };
typedef SharedHandle<DefaultBtRequestFactory> DefaultBtRequestFactoryHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_BT_REQUEST_FACTORY_H #endif // D_DEFAULT_BT_REQUEST_FACTORY_H

View File

@ -48,8 +48,6 @@ public:
virtual void initAndOpenFile(int64_t totalLength = 0); virtual void initAndOpenFile(int64_t totalLength = 0);
}; };
typedef SharedHandle<DefaultDiskWriter> DefaultDiskWriterHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_DISK_WRITER_H #endif // D_DEFAULT_DISK_WRITER_H

View File

@ -47,8 +47,6 @@ public:
virtual SharedHandle<DiskWriter> newDiskWriter(const std::string& filename); virtual SharedHandle<DiskWriter> newDiskWriter(const std::string& filename);
}; };
typedef SharedHandle<DefaultDiskWriterFactory> DefaultDiskWriterFactoryHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_DISK_WRITER_FACTORY_H #endif // D_DEFAULT_DISK_WRITER_FACTORY_H

View File

@ -98,15 +98,13 @@ public:
{ {
dispatcher_ = disp; dispatcher_ = disp;
} }
void setUTMetadataRequestTracker(UTMetadataRequestTracker* tracker) void setUTMetadataRequestTracker(UTMetadataRequestTracker* tracker)
{ {
tracker_ = tracker; tracker_ = tracker;
} }
}; };
typedef SharedHandle<DefaultExtensionMessageFactory> DefaultExtensionMessageFactoryHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_EXTENSION_MESSAGE_FACTORY_H #endif // D_DEFAULT_EXTENSION_MESSAGE_FACTORY_H

View File

@ -306,8 +306,6 @@ public:
} }
}; };
typedef SharedHandle<DefaultPieceStorage> DefaultPieceStorageHandle;
} // namespace aria2 } // namespace aria2
#endif // D_DEFAULT_PIECE_STORAGE_H #endif // D_DEFAULT_PIECE_STORAGE_H

View File

@ -132,36 +132,42 @@ PeerInteractionCommand::PeerInteractionCommand
utMetadataRequestTracker.reset(new UTMetadataRequestTracker()); utMetadataRequestTracker.reset(new UTMetadataRequestTracker());
} }
SharedHandle<DefaultExtensionMessageFactory> extensionMessageFactory DefaultExtensionMessageFactory* extensionMessageFactoryPtr
(new DefaultExtensionMessageFactory(getPeer(), exMsgRegistry)); (new DefaultExtensionMessageFactory(getPeer(), exMsgRegistry));
extensionMessageFactory->setPeerStorage(peerStorage); extensionMessageFactoryPtr->setPeerStorage(peerStorage);
extensionMessageFactory->setDownloadContext extensionMessageFactoryPtr->setDownloadContext
(requestGroup_->getDownloadContext()); (requestGroup_->getDownloadContext());
extensionMessageFactory->setUTMetadataRequestTracker extensionMessageFactoryPtr->setUTMetadataRequestTracker
(utMetadataRequestTracker.get()); (utMetadataRequestTracker.get());
// PieceStorage will be set later. // PieceStorage will be set later.
SharedHandle<ExtensionMessageFactory> extensionMessageFactory
(extensionMessageFactoryPtr);
SharedHandle<DefaultBtMessageFactory> factory(new DefaultBtMessageFactory());
factory->setCuid(cuid);
factory->setDownloadContext(requestGroup_->getDownloadContext()); DefaultBtMessageFactory* factoryPtr(new DefaultBtMessageFactory());
factory->setPieceStorage(pieceStorage); factoryPtr->setCuid(cuid);
factory->setPeerStorage(peerStorage); factoryPtr->setDownloadContext(requestGroup_->getDownloadContext());
factory->setExtensionMessageFactory(extensionMessageFactory); factoryPtr->setPieceStorage(pieceStorage);
factory->setPeer(getPeer()); factoryPtr->setPeerStorage(peerStorage);
factoryPtr->setExtensionMessageFactory(extensionMessageFactory);
factoryPtr->setPeer(getPeer());
if(family == AF_INET) { if(family == AF_INET) {
factory->setLocalNode(DHTRegistry::getData().localNode.get()); factoryPtr->setLocalNode(DHTRegistry::getData().localNode.get());
factory->setRoutingTable(DHTRegistry::getData().routingTable.get()); factoryPtr->setRoutingTable(DHTRegistry::getData().routingTable.get());
factory->setTaskQueue(DHTRegistry::getData().taskQueue.get()); factoryPtr->setTaskQueue(DHTRegistry::getData().taskQueue.get());
factory->setTaskFactory(DHTRegistry::getData().taskFactory.get()); factoryPtr->setTaskFactory(DHTRegistry::getData().taskFactory.get());
} else { } else {
factory->setLocalNode(DHTRegistry::getData6().localNode.get()); factoryPtr->setLocalNode(DHTRegistry::getData6().localNode.get());
factory->setRoutingTable(DHTRegistry::getData6().routingTable.get()); factoryPtr->setRoutingTable(DHTRegistry::getData6().routingTable.get());
factory->setTaskQueue(DHTRegistry::getData6().taskQueue.get()); factoryPtr->setTaskQueue(DHTRegistry::getData6().taskQueue.get());
factory->setTaskFactory(DHTRegistry::getData6().taskFactory.get()); factoryPtr->setTaskFactory(DHTRegistry::getData6().taskFactory.get());
} }
if(metadataGetMode) { if(metadataGetMode) {
factory->enableMetadataGetMode(); factoryPtr->enableMetadataGetMode();
} }
SharedHandle<BtMessageFactory> factory(factoryPtr);
PeerConnectionHandle peerConnection; PeerConnectionHandle peerConnection;
if(!passedPeerConnection) { if(!passedPeerConnection) {
@ -183,91 +189,94 @@ PeerInteractionCommand::PeerInteractionCommand
1+(requestGroup_->getDownloadContext()->getNumPieces()+7)/8; 1+(requestGroup_->getDownloadContext()->getNumPieces()+7)/8;
peerConnection->reserveBuffer(bitfieldPayloadSize); peerConnection->reserveBuffer(bitfieldPayloadSize);
SharedHandle<DefaultBtMessageDispatcher> dispatcher DefaultBtMessageDispatcher* dispatcherPtr(new DefaultBtMessageDispatcher());
(new DefaultBtMessageDispatcher()); dispatcherPtr->setCuid(cuid);
dispatcher->setCuid(cuid); dispatcherPtr->setPeer(getPeer());
dispatcher->setPeer(getPeer()); dispatcherPtr->setDownloadContext(requestGroup_->getDownloadContext());
dispatcher->setDownloadContext(requestGroup_->getDownloadContext()); dispatcherPtr->setPieceStorage(pieceStorage);
dispatcher->setPieceStorage(pieceStorage); dispatcherPtr->setPeerStorage(peerStorage);
dispatcher->setPeerStorage(peerStorage); dispatcherPtr->setRequestTimeout(getOption()->
dispatcher->setRequestTimeout(getOption()->getAsInt(PREF_BT_REQUEST_TIMEOUT)); getAsInt(PREF_BT_REQUEST_TIMEOUT));
dispatcher->setBtMessageFactory(factory.get()); dispatcherPtr->setBtMessageFactory(factoryPtr);
dispatcher->setRequestGroupMan dispatcherPtr->setRequestGroupMan
(getDownloadEngine()->getRequestGroupMan().get()); (getDownloadEngine()->getRequestGroupMan().get());
SharedHandle<BtMessageDispatcher> dispatcher(dispatcherPtr);
DefaultBtMessageReceiverHandle receiver(new DefaultBtMessageReceiver()); DefaultBtMessageReceiver* receiverPtr(new DefaultBtMessageReceiver());
receiver->setDownloadContext(requestGroup_->getDownloadContext()); receiverPtr->setDownloadContext(requestGroup_->getDownloadContext());
receiver->setPeerConnection(peerConnection.get()); receiverPtr->setPeerConnection(peerConnection.get());
receiver->setDispatcher(dispatcher.get()); receiverPtr->setDispatcher(dispatcherPtr);
receiver->setBtMessageFactory(factory.get()); receiverPtr->setBtMessageFactory(factoryPtr);
SharedHandle<BtMessageReceiver> receiver(receiverPtr);
SharedHandle<DefaultBtRequestFactory> reqFactory DefaultBtRequestFactory* reqFactoryPtr(new DefaultBtRequestFactory());
(new DefaultBtRequestFactory()); reqFactoryPtr->setPeer(getPeer());
reqFactory->setPeer(getPeer()); reqFactoryPtr->setPieceStorage(pieceStorage);
reqFactory->setPieceStorage(pieceStorage); reqFactoryPtr->setBtMessageDispatcher(dispatcherPtr);
reqFactory->setBtMessageDispatcher(dispatcher.get()); reqFactoryPtr->setBtMessageFactory(factoryPtr);
reqFactory->setBtMessageFactory(factory.get()); reqFactoryPtr->setCuid(cuid);
reqFactory->setCuid(cuid); SharedHandle<BtRequestFactory> reqFactory(reqFactoryPtr);
DefaultBtInteractiveHandle btInteractive DefaultBtInteractive* btInteractivePtr
(new DefaultBtInteractive(requestGroup_->getDownloadContext(), getPeer())); (new DefaultBtInteractive(requestGroup_->getDownloadContext(), getPeer()));
btInteractive->setBtRuntime(btRuntime_); btInteractivePtr->setBtRuntime(btRuntime_);
btInteractive->setPieceStorage(pieceStorage_); btInteractivePtr->setPieceStorage(pieceStorage_);
btInteractive->setPeerStorage(peerStorage); // Note: Not a member variable. btInteractivePtr->setPeerStorage(peerStorage); // Note: Not a member variable.
btInteractive->setCuid(cuid); btInteractivePtr->setCuid(cuid);
btInteractive->setBtMessageReceiver(receiver); btInteractivePtr->setBtMessageReceiver(receiver);
btInteractive->setDispatcher(dispatcher); btInteractivePtr->setDispatcher(dispatcher);
btInteractive->setBtRequestFactory(reqFactory); btInteractivePtr->setBtRequestFactory(reqFactory);
btInteractive->setPeerConnection(peerConnection); btInteractivePtr->setPeerConnection(peerConnection);
btInteractive->setExtensionMessageFactory(extensionMessageFactory); btInteractivePtr->setExtensionMessageFactory(extensionMessageFactory);
btInteractive->setExtensionMessageRegistry(exMsgRegistry); btInteractivePtr->setExtensionMessageRegistry(exMsgRegistry);
btInteractive->setKeepAliveInterval btInteractivePtr->setKeepAliveInterval
(getOption()->getAsInt(PREF_BT_KEEP_ALIVE_INTERVAL)); (getOption()->getAsInt(PREF_BT_KEEP_ALIVE_INTERVAL));
btInteractive->setRequestGroupMan btInteractivePtr->setRequestGroupMan
(getDownloadEngine()->getRequestGroupMan().get()); (getDownloadEngine()->getRequestGroupMan().get());
btInteractive->setBtMessageFactory(factory); btInteractivePtr->setBtMessageFactory(factory);
if((metadataGetMode || !torrentAttrs->privateTorrent) && if((metadataGetMode || !torrentAttrs->privateTorrent) &&
!getPeer()->isLocalPeer()) { !getPeer()->isLocalPeer()) {
if(getOption()->getAsBool(PREF_ENABLE_PEER_EXCHANGE)) { if(getOption()->getAsBool(PREF_ENABLE_PEER_EXCHANGE)) {
btInteractive->setUTPexEnabled(true); btInteractivePtr->setUTPexEnabled(true);
} }
if(family == AF_INET) { if(family == AF_INET) {
if(DHTRegistry::isInitialized()) { if(DHTRegistry::isInitialized()) {
btInteractive->setDHTEnabled(true); btInteractivePtr->setDHTEnabled(true);
factory->setDHTEnabled(true); factoryPtr->setDHTEnabled(true);
btInteractive->setLocalNode(DHTRegistry::getData().localNode.get()); btInteractivePtr->setLocalNode(DHTRegistry::getData().localNode.get());
} }
} else { } else {
if(DHTRegistry::isInitialized6()) { if(DHTRegistry::isInitialized6()) {
btInteractive->setDHTEnabled(true); btInteractivePtr->setDHTEnabled(true);
factory->setDHTEnabled(true); factoryPtr->setDHTEnabled(true);
btInteractive->setLocalNode(DHTRegistry::getData6().localNode.get()); btInteractivePtr->setLocalNode(DHTRegistry::getData6().localNode.get());
} }
} }
} }
btInteractive->setUTMetadataRequestFactory(utMetadataRequestFactory); btInteractivePtr->setUTMetadataRequestFactory(utMetadataRequestFactory);
btInteractive->setUTMetadataRequestTracker(utMetadataRequestTracker); btInteractivePtr->setUTMetadataRequestTracker(utMetadataRequestTracker);
btInteractive->setTcpPort(e->getBtRegistry()->getTcpPort()); btInteractivePtr->setTcpPort(e->getBtRegistry()->getTcpPort());
if(metadataGetMode) { if(metadataGetMode) {
btInteractive->enableMetadataGetMode(); btInteractivePtr->enableMetadataGetMode();
} }
SharedHandle<BtInteractive> btInteractive(btInteractivePtr);
btInteractive_ = btInteractive; btInteractive_ = btInteractive;
// reverse depends // reverse depends
factory->setBtMessageDispatcher(dispatcher.get()); factoryPtr->setBtMessageDispatcher(dispatcherPtr);
factory->setBtRequestFactory(reqFactory.get()); factoryPtr->setBtRequestFactory(reqFactoryPtr);
factory->setPeerConnection(peerConnection.get()); factoryPtr->setPeerConnection(peerConnection.get());
extensionMessageFactory->setBtMessageDispatcher(dispatcher.get()); extensionMessageFactoryPtr->setBtMessageDispatcher(dispatcherPtr);
extensionMessageFactory->setBtMessageFactory(factory.get()); extensionMessageFactoryPtr->setBtMessageFactory(factoryPtr);
if(metadataGetMode) { if(metadataGetMode) {
utMetadataRequestFactory->setCuid(cuid); utMetadataRequestFactory->setCuid(cuid);
utMetadataRequestFactory->setDownloadContext utMetadataRequestFactory->setDownloadContext
(requestGroup_->getDownloadContext()); (requestGroup_->getDownloadContext());
utMetadataRequestFactory->setBtMessageDispatcher(dispatcher.get()); utMetadataRequestFactory->setBtMessageDispatcher(dispatcherPtr);
utMetadataRequestFactory->setBtMessageFactory(factory.get()); utMetadataRequestFactory->setBtMessageFactory(factoryPtr);
utMetadataRequestFactory->setPeer(getPeer()); utMetadataRequestFactory->setPeer(getPeer());
utMetadataRequestFactory->setUTMetadataRequestTracker utMetadataRequestFactory->setUTMetadataRequestTracker
(utMetadataRequestTracker.get()); (utMetadataRequestTracker.get());
@ -276,7 +285,7 @@ PeerInteractionCommand::PeerInteractionCommand
getPeer()->allocateSessionResource getPeer()->allocateSessionResource
(requestGroup_->getDownloadContext()->getPieceLength(), (requestGroup_->getDownloadContext()->getPieceLength(),
requestGroup_->getDownloadContext()->getTotalLength()); requestGroup_->getDownloadContext()->getTotalLength());
getPeer()->setBtMessageDispatcher(dispatcher.get()); getPeer()->setBtMessageDispatcher(dispatcherPtr);
btRuntime_->increaseConnections(); btRuntime_->increaseConnections();
requestGroup_->increaseNumCommand(); requestGroup_->increaseNumCommand();

View File

@ -218,7 +218,7 @@ void RequestGroup::closeFile()
// that this function open file. // that this function open file.
SharedHandle<CheckIntegrityEntry> RequestGroup::createCheckIntegrityEntry() SharedHandle<CheckIntegrityEntry> RequestGroup::createCheckIntegrityEntry()
{ {
BtProgressInfoFileHandle infoFile SharedHandle<BtProgressInfoFile> infoFile
(new DefaultBtProgressInfoFile(downloadContext_, pieceStorage_, (new DefaultBtProgressInfoFile(downloadContext_, pieceStorage_,
option_.get())); option_.get()));
SharedHandle<CheckIntegrityEntry> checkEntry; SharedHandle<CheckIntegrityEntry> checkEntry;
@ -309,38 +309,42 @@ void RequestGroup::createInitialCommand
pieceStorage_->setupFileFilter(); pieceStorage_->setupFileFilter();
} }
} }
SharedHandle<DefaultBtProgressInfoFile> progressInfoFile; DefaultBtProgressInfoFile* progressInfoFilePtr = 0;
SharedHandle<BtProgressInfoFile> progressInfoFile;
if(!metadataGetMode) { if(!metadataGetMode) {
progressInfoFile.reset(new DefaultBtProgressInfoFile(downloadContext_, progressInfoFilePtr = new DefaultBtProgressInfoFile(downloadContext_,
pieceStorage_, pieceStorage_,
option_.get())); option_.get());
progressInfoFile.reset(progressInfoFilePtr);
} }
BtRuntimeHandle btRuntime(new BtRuntime()); BtRuntimeHandle btRuntime(new BtRuntime());
btRuntime->setMaxPeers(option_->getAsInt(PREF_BT_MAX_PEERS)); btRuntime->setMaxPeers(option_->getAsInt(PREF_BT_MAX_PEERS));
btRuntime_ = btRuntime.get(); btRuntime_ = btRuntime.get();
if(progressInfoFile) { if(progressInfoFilePtr) {
progressInfoFile->setBtRuntime(btRuntime); progressInfoFilePtr->setBtRuntime(btRuntime);
} }
SharedHandle<DefaultPeerStorage> peerStorage(new DefaultPeerStorage()); DefaultPeerStorage* peerStoragePtr(new DefaultPeerStorage());
peerStorage->setBtRuntime(btRuntime); peerStoragePtr->setBtRuntime(btRuntime);
peerStorage->setPieceStorage(pieceStorage_); peerStoragePtr->setPieceStorage(pieceStorage_);
peerStorage_ = peerStorage.get(); peerStorage_ = peerStoragePtr;
if(progressInfoFile) { SharedHandle<PeerStorage> peerStorage(peerStoragePtr);
progressInfoFile->setPeerStorage(peerStorage); if(progressInfoFilePtr) {
progressInfoFilePtr->setPeerStorage(peerStorage);
} }
SharedHandle<DefaultBtAnnounce> btAnnounce DefaultBtAnnounce* btAnnouncePtr
(new DefaultBtAnnounce(downloadContext_, option_.get())); (new DefaultBtAnnounce(downloadContext_, option_.get()));
btAnnounce->setBtRuntime(btRuntime); btAnnouncePtr->setBtRuntime(btRuntime);
btAnnounce->setPieceStorage(pieceStorage_); btAnnouncePtr->setPieceStorage(pieceStorage_);
btAnnounce->setPeerStorage(peerStorage); btAnnouncePtr->setPeerStorage(peerStorage);
btAnnounce->setUserDefinedInterval btAnnouncePtr->setUserDefinedInterval
(option_->getAsInt(PREF_BT_TRACKER_INTERVAL)); (option_->getAsInt(PREF_BT_TRACKER_INTERVAL));
btAnnounce->shuffleAnnounce(); btAnnouncePtr->shuffleAnnounce();
SharedHandle<BtAnnounce> btAnnounce(btAnnouncePtr);
assert(!btRegistry->get(gid_)); assert(!btRegistry->get(gid_));
btRegistry->put btRegistry->put
(gid_, SharedHandle<BtObject> (gid_, SharedHandle<BtObject>
@ -351,8 +355,7 @@ void RequestGroup::createInitialCommand
btAnnounce, btAnnounce,
btRuntime, btRuntime,
(progressInfoFile ? (progressInfoFile ?
SharedHandle<BtProgressInfoFile>(progressInfoFile) : progressInfoFile : progressInfoFile_))));
progressInfoFile_))));
if(metadataGetMode) { if(metadataGetMode) {
if(option_->getAsBool(PREF_ENABLE_DHT) || if(option_->getAsBool(PREF_ENABLE_DHT) ||
(!e->getOption()->getAsBool(PREF_DISABLE_IPV6) && (!e->getOption()->getAsBool(PREF_DISABLE_IPV6) &&
@ -508,7 +511,7 @@ void RequestGroup::createInitialCommand
if(downloadContext_->getFileEntries().size() > 1) { if(downloadContext_->getFileEntries().size() > 1) {
pieceStorage_->setupFileFilter(); pieceStorage_->setupFileFilter();
} }
SharedHandle<DefaultBtProgressInfoFile> progressInfoFile SharedHandle<BtProgressInfoFile> progressInfoFile
(new DefaultBtProgressInfoFile(downloadContext_, (new DefaultBtProgressInfoFile(downloadContext_,
pieceStorage_, pieceStorage_,
option_.get())); option_.get()));
@ -712,7 +715,8 @@ void RequestGroup::removeDefunctControlFile
} }
} }
void RequestGroup::loadAndOpenFile(const BtProgressInfoFileHandle& progressInfoFile) void RequestGroup::loadAndOpenFile
(const SharedHandle<BtProgressInfoFile>& progressInfoFile)
{ {
try { try {
if(!isPreLocalFileCheckEnabled()) { if(!isPreLocalFileCheckEnabled()) {
@ -1135,7 +1139,8 @@ void RequestGroup::setPieceStorage(const PieceStorageHandle& pieceStorage)
pieceStorage_ = pieceStorage; pieceStorage_ = pieceStorage;
} }
void RequestGroup::setProgressInfoFile(const BtProgressInfoFileHandle& progressInfoFile) void RequestGroup::setProgressInfoFile
(const SharedHandle<BtProgressInfoFile>& progressInfoFile)
{ {
progressInfoFile_ = progressInfoFile; progressInfoFile_ = progressInfoFile;
} }