github
/
aria2
mirror of https://github.com/aria2/aria2
1
0
Fork 0
Code Issues Releases Wiki Activity

2010-03-02 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 

Reserved vector elements based on profiler results.
	* src/DefaultBtInteractive.cc
	* src/DefaultBtProgressInfoFile.cc
pull/1/head
Tatsuhiro Tsujikawa 2010-03-01 16:13:42 +00:00
parent 72e475dfde
commit 18ea756a74
3 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@ -1,3 +1,9 @@
2010-03-02 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Reserved vector elements based on profiler results.
* src/DefaultBtInteractive.cc
* src/DefaultBtProgressInfoFile.cc
2010-03-01 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net> 2010-03-01 Tatsuhiro Tsujikawa <t-tujikawa@users.sourceforge.net>
Avoid to calculate end() iterator in each loop. std::deque is Avoid to calculate end() iterator in each loop. std::deque is

3
src/DefaultBtInteractive.cc
View File

@ -328,6 +328,7 @@ void DefaultBtInteractive::fillPiece(size_t maxMissingBlock) {
if(peer->peerChoking()) { if(peer->peerChoking()) {
if(peer->isFastExtensionEnabled()) { if(peer->isFastExtensionEnabled()) {
std::vector<size_t> excludedIndexes; std::vector<size_t> excludedIndexes;
excludedIndexes.reserve(btRequestFactory->countTargetPiece());
btRequestFactory->getTargetPieceIndexes(excludedIndexes); btRequestFactory->getTargetPieceIndexes(excludedIndexes);
while(numMissingBlock < maxMissingBlock) { while(numMissingBlock < maxMissingBlock) {
SharedHandle<Piece> piece = SharedHandle<Piece> piece =
@ -343,6 +344,7 @@ void DefaultBtInteractive::fillPiece(size_t maxMissingBlock) {
} }
} else { } else {
std::vector<size_t> excludedIndexes; std::vector<size_t> excludedIndexes;
excludedIndexes.reserve(btRequestFactory->countTargetPiece());
btRequestFactory->getTargetPieceIndexes(excludedIndexes); btRequestFactory->getTargetPieceIndexes(excludedIndexes);
while(numMissingBlock < maxMissingBlock) { while(numMissingBlock < maxMissingBlock) {
SharedHandle<Piece> piece = SharedHandle<Piece> piece =
@ -366,6 +368,7 @@ void DefaultBtInteractive::addRequests() {
0 : _maxOutstandingRequest-dispatcher->countOutstandingRequest(); 0 : _maxOutstandingRequest-dispatcher->countOutstandingRequest();
if(reqNumToCreate > 0) { if(reqNumToCreate > 0) {
std::vector<SharedHandle<BtMessage> > requests; std::vector<SharedHandle<BtMessage> > requests;
requests.reserve(reqNumToCreate);
if(_pieceStorage->isEndGame()) { if(_pieceStorage->isEndGame()) {
btRequestFactory->createRequestMessagesOnEndGame(requests,reqNumToCreate); btRequestFactory->createRequestMessagesOnEndGame(requests,reqNumToCreate);
} else { } else {

2
src/DefaultBtProgressInfoFile.cc
View File

@ -180,6 +180,7 @@ void DefaultBtProgressInfoFile::save()
o.write(reinterpret_cast<const char*>(&numInFlightPieceNL), o.write(reinterpret_cast<const char*>(&numInFlightPieceNL),
sizeof(numInFlightPieceNL)); sizeof(numInFlightPieceNL));
std::vector<SharedHandle<Piece> > inFlightPieces; std::vector<SharedHandle<Piece> > inFlightPieces;
inFlightPieces.reserve(_pieceStorage->countInFlightPiece());
_pieceStorage->getInFlightPieces(inFlightPieces); _pieceStorage->getInFlightPieces(inFlightPieces);
for(std::vector<SharedHandle<Piece> >::const_iterator itr = for(std::vector<SharedHandle<Piece> >::const_iterator itr =
inFlightPieces.begin(), eoi = inFlightPieces.end(); inFlightPieces.begin(), eoi = inFlightPieces.end();
@ -345,6 +346,7 @@ void DefaultBtProgressInfoFile::load()
numInFlightPiece = ntohl(numInFlightPiece); numInFlightPiece = ntohl(numInFlightPiece);
} }
std::vector<SharedHandle<Piece> > inFlightPieces; std::vector<SharedHandle<Piece> > inFlightPieces;
inFlightPieces.reserve(numInFlightPiece);
while(numInFlightPiece--) { while(numInFlightPiece--) {
uint32_t index; uint32_t index;
in.read(reinterpret_cast<char*>(&index), sizeof(index)); in.read(reinterpret_cast<char*>(&index), sizeof(index));