From 1372ac51ade17bc27126449bf29f99c6c2cf7703 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Sun, 14 Nov 2010 07:17:55 +0000 Subject: [PATCH] 2010-11-14 Tatsuhiro Tsujikawa Added .cc file for classes/structs that only provided by header file. Defined non-POD classes' ctor, dtor in .cc file. Moved implementation code in header file to .cc file for major classes/strucsts. --- ChangeLog | 7 + src/AbstractCommand.cc | 39 +- src/AbstractCommand.h | 45 +- src/AbstractProxyRequestCommand.cc | 7 - src/AbstractProxyResponseCommand.cc | 4 - src/AbstractSingleDiskAdaptor.cc | 4 +- src/ActivePeerConnectionCommand.cc | 4 - src/AdaptiveFileAllocationIterator.cc | 20 +- src/AdaptiveFileAllocationIterator.h | 14 +- src/AlphaNumberDecorator.cc | 82 +++ src/AlphaNumberDecorator.h | 43 +- src/AnnounceList.cc | 10 +- src/AnnounceList.h | 11 +- src/AnnounceTier.cc | 79 +++ src/AnnounceTier.h | 45 +- src/AuthConfig.cc | 17 + src/AuthConfig.h | 15 +- src/AutoSaveCommand.cc | 10 +- src/BitfieldMan.cc | 32 +- src/BitfieldMan.h | 32 +- src/BtAbortOutstandingRequestEvent.cc | 47 ++ src/BtAbortOutstandingRequestEvent.h | 7 +- src/BtAnnounce.h | 4 +- src/BtBitfieldMessageValidator.cc | 56 ++ src/BtBitfieldMessageValidator.h | 16 +- src/BtCheckIntegrityEntry.cc | 3 - src/BtDependency.cc | 1 + src/BtExtendedMessage.cc | 2 + src/BtExtendedMessage.h | 1 + src/BtFileAllocationEntry.cc | 4 +- src/BtHandshakeMessageValidator.cc | 76 +++ src/BtHandshakeMessageValidator.h | 34 +- src/BtInterestedMessage.cc | 2 + src/BtInterestedMessage.h | 1 + src/BtLeecherStateChoke.cc | 19 + src/BtLeecherStateChoke.h | 4 + src/BtNotInterestedMessage.cc | 2 + src/BtNotInterestedMessage.h | 1 + src/BtPieceMessageValidator.cc | 56 ++ src/BtPieceMessageValidator.h | 17 +- src/BtRegistry.cc | 51 ++ src/BtRegistry.h | 26 +- src/BtRuntime.cc | 61 ++ src/BtRuntime.h | 23 +- src/BtSeederStateChoke.cc | 23 + src/BtSeederStateChoke.h | 4 + src/BtSetup.cc | 7 +- src/BtStopDownloadCommand.cc | 2 - src/ByteArrayDiskWriter.cc | 11 +- src/ByteArrayDiskWriter.h | 10 +- src/CUIDCounter.cc | 51 ++ src/CUIDCounter.h | 16 +- src/CheckIntegrityCommand.cc | 3 - src/CheckIntegrityDispatcherCommand.cc | 3 - src/CheckIntegrityEntry.cc | 3 - src/Checksum.cc | 65 ++ src/Checksum.h | 28 +- src/ChecksumCheckIntegrityEntry.cc | 2 - src/ChunkChecksum.cc | 91 +++ src/ChunkChecksum.h | 48 +- src/Command.h | 1 - src/ConsoleStatCalc.cc | 32 +- src/ConsoleStatCalc.h | 25 +- src/ContextAttribute.h | 4 + src/Cookie.cc | 52 ++ src/Cookie.h | 24 +- src/CookieStorage.cc | 36 +- src/CookieStorage.h | 14 +- src/CreateRequestCommand.cc | 4 +- src/DHTAutoSaveCommand.cc | 4 - src/DHTBucketRefreshCommand.cc | 4 - src/DHTEntryPointNameResolveCommand.cc | 10 +- src/DHTGetPeersCommand.cc | 4 - src/DHTInteractionCommand.cc | 4 - src/DHTMessageTrackerEntry.cc | 7 + src/DHTMessageTrackerEntry.h | 7 +- src/DHTNode.cc | 7 + src/DHTNode.h | 11 +- src/DHTPeerAnnounceCommand.cc | 4 - src/DHTTokenUpdateCommand.cc | 4 - src/DNSCache.cc | 209 +++++++ src/DNSCache.h | 133 +---- src/DiskAdaptor.cc | 2 + src/DiskAdaptor.h | 2 +- src/DownloadCommand.cc | 3 +- src/DownloadCommand.h | 2 + src/DownloadContext.cc | 43 ++ src/DownloadContext.h | 41 +- src/DownloadEngine.cc | 32 +- src/DownloadEngine.h | 31 +- src/DownloadResult.cc | 46 ++ src/DownloadResult.h | 11 +- src/Exception.cc | 5 + src/Exception.h | 5 +- src/ExtensionMessageRegistry.cc | 78 +++ src/ExtensionMessageRegistry.h | 37 +- src/FeatureConfig.cc | 2 + src/FeatureConfig.h | 2 + src/File.cc | 12 +- src/File.h | 5 + src/FileAllocationCommand.cc | 2 - src/FileAllocationDispatcherCommand.cc | 3 - src/FileEntry.cc | 31 + src/FileEntry.h | 29 +- src/FillRequestGroupCommand.cc | 3 - src/FixedWidthNumberDecorator.cc | 55 ++ src/FixedWidthNumberDecorator.h | 14 +- src/FtpDownloadCommand.cc | 6 +- src/FtpFinishDownloadCommand.cc | 8 +- src/FtpFinishDownloadCommand.h | 1 + src/FtpInitiateConnectionCommand.cc | 5 - src/FtpNegotiationCommand.cc | 3 - src/FtpNegotiationCommand.h | 2 + src/FtpTunnelResponseCommand.cc | 1 - src/HandshakeExtensionMessage.cc | 1 + src/HaveEraseCommand.cc | 4 - src/HttpConnection.cc | 2 + src/HttpConnection.h | 1 + src/HttpDownloadCommand.cc | 4 - src/HttpHeader.cc | 3 + src/HttpHeader.h | 4 +- src/HttpInitiateConnectionCommand.cc | 6 +- src/HttpListenCommand.cc | 4 - src/HttpProxyRequestCommand.cc | 1 - src/HttpProxyResponseCommand.cc | 1 - src/HttpRequest.cc | 74 +++ src/HttpRequest.h | 74 +-- src/HttpRequestCommand.cc | 4 - src/HttpResponseCommand.cc | 2 - src/HttpServer.cc | 7 + src/HttpServer.h | 6 +- src/HttpServerBodyCommand.cc | 4 - src/HttpServerCommand.cc | 4 - src/HttpServerResponseCommand.cc | 4 - src/HttpSkipResponseCommand.cc | 4 - src/IndexBtMessageValidator.cc | 54 ++ src/IndexBtMessageValidator.h | 15 +- src/InitiateConnectionCommand.cc | 5 - src/InitiatorMSEHandshakeCommand.cc | 4 - src/LibgcryptARC4Context.cc | 84 +++ src/LibgcryptARC4Context.h | 44 +- src/LibgcryptARC4Decryptor.cc | 72 +++ src/LibgcryptARC4Decryptor.h | 30 +- src/LibgcryptARC4Encryptor.cc | 72 +++ src/LibgcryptARC4Encryptor.h | 27 +- src/LibgcryptDHKeyExchange.cc | 165 +++++ src/LibgcryptDHKeyExchange.h | 117 +--- src/LibsslARC4Context.cc | 91 +++ src/LibsslARC4Context.h | 47 +- src/LibsslARC4Decryptor.cc | 72 +++ src/LibsslARC4Decryptor.h | 27 +- src/LibsslARC4Encryptor.cc | 72 +++ src/LibsslARC4Encryptor.h | 27 +- src/LibsslDHKeyExchange.cc | 180 ++++++ src/LibsslDHKeyExchange.h | 133 +---- src/Logger.cc | 10 + src/Logger.h | 10 +- src/LpdDispatchMessageCommand.cc | 7 +- src/LpdDispatchMessageCommand.h | 2 + src/LpdMessage.cc | 47 ++ src/LpdMessage.h | 11 +- src/LpdMessageDispatcher.cc | 2 + src/LpdMessageDispatcher.h | 2 + src/LpdMessageReceiver.cc | 3 + src/LpdMessageReceiver.h | 2 + src/LpdReceiveMessageCommand.cc | 3 - src/Makefile.am | 78 +-- src/Makefile.in | 342 +++++++---- src/MetadataInfo.cc | 8 + src/MetadataInfo.h | 7 +- src/MetalinkEntry.cc | 10 + src/MetalinkEntry.h | 12 +- src/MetalinkMetaurl.cc | 2 + src/MetalinkMetaurl.h | 2 + src/MetalinkParserState.cc | 58 ++ src/MetalinkParserState.h | 5 + src/MetalinkParserStateMachine.cc | 2 + src/MetalinkParserStateMachine.h | 2 + src/MetalinkResource.cc | 8 +- src/MetalinkResource.h | 13 +- src/Metalinker.cc | 5 + src/Metalinker.h | 14 +- src/MultiDiskAdaptor.cc | 2 + src/MultiDiskAdaptor.h | 1 + src/NameMatchOptionHandler.cc | 91 +++ src/NameMatchOptionHandler.h | 48 +- src/Netrc.cc | 73 +++ src/Netrc.h | 54 +- src/NumberDecorator.h | 2 - src/Option.cc | 10 + src/Option.h | 10 +- src/OptionHandlerImpl.cc | 728 +++++++++++++++++++++++ src/OptionHandlerImpl.h | 620 +++---------------- src/OptionParser.cc | 3 + src/OptionParser.h | 2 +- src/PStringBuildVisitor.cc | 5 + src/PStringBuildVisitor.h | 2 + src/PStringNumLoop.cc | 70 +++ src/PStringNumLoop.h | 26 +- src/PStringSelect.cc | 68 +++ src/PStringSelect.h | 31 +- src/PeerAddrEntry.cc | 72 +++ src/PeerAddrEntry.h | 17 +- src/PeerConnection.cc | 7 + src/PeerConnection.h | 7 +- src/PeerInitiateConnectionCommand.cc | 5 - src/PeerInteractionCommand.cc | 3 - src/PeerListenCommand.cc | 4 - src/PeerReceiveHandshakeCommand.cc | 4 - src/PeerStat.cc | 133 +++++ src/PeerStat.h | 110 ++-- src/PieceStatMan.cc | 2 + src/PieceStatMan.h | 2 + src/ProgressAwareEntry.h | 4 +- src/Range.cc | 84 +++ src/Range.h | 35 +- src/RangeBtMessageValidator.cc | 60 ++ src/RangeBtMessageValidator.h | 21 +- src/ReceiverMSEHandshakeCommand.cc | 8 - src/Request.cc | 27 +- src/Request.h | 42 +- src/RequestGroupMan.cc | 3 + src/RequestGroupMan.h | 2 + src/SeedCheckCommand.cc | 5 - src/Segment.h | 1 - src/SegmentMan.cc | 6 + src/SegmentMan.h | 9 +- src/ShareRatioSeedCriteria.cc | 76 +++ src/ShareRatioSeedCriteria.h | 41 +- src/SocketBuffer.h | 4 + src/StreamFileAllocationEntry.cc | 2 + src/StreamFilter.cc | 2 + src/StreamFilter.h | 2 +- src/StringFormat.cc | 2 + src/StringFormat.h | 1 + src/TimeBasedCommand.cc | 5 - src/TimeSeedCriteria.cc | 54 ++ src/TimeSeedCriteria.h | 19 +- src/TimedHaltCommand.cc | 4 - src/TorrentAttribute.cc | 45 ++ src/TorrentAttribute.h | 13 +- src/TrackerWatcherCommand.cc | 4 - src/URIResult.cc | 7 +- src/URIResult.h | 2 + src/UTMetadataDataExtensionMessage.cc | 19 + src/UTMetadataDataExtensionMessage.h | 17 +- src/UTMetadataRequestExtensionMessage.cc | 13 + src/UTMetadataRequestExtensionMessage.h | 12 +- src/UnionSeedCriteria.cc | 81 +++ src/UnionSeedCriteria.h | 40 +- src/ValueBase.cc | 8 + src/ValueBase.h | 26 +- src/XML2SAXMetalinkProcessor.cc | 4 + src/XML2SAXMetalinkProcessor.h | 4 + src/Xml2XmlRpcRequestProcessor.cc | 4 + src/Xml2XmlRpcRequestProcessor.h | 4 + src/XmlRpcMethod.cc | 2 + src/XmlRpcMethod.h | 2 +- src/XmlRpcRequest.cc | 20 + src/XmlRpcRequest.h | 9 +- src/XmlRpcResponse.cc | 21 + src/XmlRpcResponse.h | 9 +- src/bittorrent_helper.cc | 1 + src/uri.cc | 36 ++ src/uri.h | 7 +- test/DownloadHelperTest.cc | 1 + test/LpdMessageReceiverTest.cc | 1 + test/Metalink2RequestGroupTest.cc | 1 + test/OptionHandlerTest.cc | 1 + test/SegmentManTest.cc | 2 + test/SessionSerializerTest.cc | 4 +- test/XmlRpcMethodTest.cc | 8 +- 272 files changed, 5418 insertions(+), 2483 deletions(-) create mode 100644 src/AlphaNumberDecorator.cc create mode 100644 src/AnnounceTier.cc create mode 100644 src/BtAbortOutstandingRequestEvent.cc create mode 100644 src/BtBitfieldMessageValidator.cc create mode 100644 src/BtHandshakeMessageValidator.cc create mode 100644 src/BtPieceMessageValidator.cc create mode 100644 src/BtRuntime.cc create mode 100644 src/CUIDCounter.cc create mode 100644 src/Checksum.cc create mode 100644 src/ChunkChecksum.cc create mode 100644 src/DNSCache.cc create mode 100644 src/DownloadResult.cc create mode 100644 src/ExtensionMessageRegistry.cc create mode 100644 src/FixedWidthNumberDecorator.cc create mode 100644 src/IndexBtMessageValidator.cc create mode 100644 src/LibgcryptARC4Context.cc create mode 100644 src/LibgcryptARC4Decryptor.cc create mode 100644 src/LibgcryptARC4Encryptor.cc create mode 100644 src/LibgcryptDHKeyExchange.cc create mode 100644 src/LibsslARC4Context.cc create mode 100644 src/LibsslARC4Decryptor.cc create mode 100644 src/LibsslARC4Encryptor.cc create mode 100644 src/LibsslDHKeyExchange.cc create mode 100644 src/LpdMessage.cc create mode 100644 src/MetalinkParserState.cc create mode 100644 src/NameMatchOptionHandler.cc create mode 100644 src/OptionHandlerImpl.cc create mode 100644 src/PStringNumLoop.cc create mode 100644 src/PStringSelect.cc create mode 100644 src/PeerAddrEntry.cc create mode 100644 src/PeerStat.cc create mode 100644 src/Range.cc create mode 100644 src/RangeBtMessageValidator.cc create mode 100644 src/ShareRatioSeedCriteria.cc create mode 100644 src/TimeSeedCriteria.cc create mode 100644 src/TorrentAttribute.cc create mode 100644 src/UnionSeedCriteria.cc diff --git a/ChangeLog b/ChangeLog index 395e71bb..9b21a117 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2010-11-14 Tatsuhiro Tsujikawa + + Added .cc file for classes/structs that only provided by header + file. Defined non-POD classes' ctor, dtor in .cc file. Moved + implementation code in header file to .cc file for major + classes/strucsts. + 2010-11-12 Tatsuhiro Tsujikawa Removed SharedHandle::isNull(). Instead we added operator* and diff --git a/src/AbstractCommand.cc b/src/AbstractCommand.cc index aad57e5a..a35d7e25 100644 --- a/src/AbstractCommand.cc +++ b/src/AbstractCommand.cc @@ -49,9 +49,6 @@ #include "CreateRequestCommand.h" #include "InitiateConnectionCommandFactory.h" #include "SleepCommand.h" -#ifdef ENABLE_ASYNC_DNS -#include "AsyncNameResolver.h" -#endif // ENABLE_ASYNC_DNS #include "StreamCheckIntegrityEntry.h" #include "PieceStorage.h" #include "Socket.h" @@ -66,9 +63,11 @@ #include "DownloadContext.h" #include "wallclock.h" #include "NameResolver.h" -#include "ServerStatMan.h" -#include "FileAllocationEntry.h" #include "uri.h" +#include "FileEntry.h" +#ifdef ENABLE_ASYNC_DNS +#include "AsyncNameResolver.h" +#endif // ENABLE_ASYNC_DNS #ifdef ENABLE_MESSAGE_DIGEST # include "ChecksumCheckIntegrityEntry.h" #endif // ENABLE_MESSAGE_DIGEST @@ -861,4 +860,34 @@ size_t AbstractCommand::calculateMinSplitSize() const } } +void AbstractCommand::setRequest(const SharedHandle& request) +{ + req_ = request; +} + +void AbstractCommand::setFileEntry(const SharedHandle& fileEntry) +{ + fileEntry_ = fileEntry; +} + +void AbstractCommand::setSocket(const SharedHandle& s) +{ + socket_ = s; +} + +const SharedHandle& AbstractCommand::getDownloadContext() const +{ + return requestGroup_->getDownloadContext(); +} + +const SharedHandle& AbstractCommand::getSegmentMan() const +{ + return requestGroup_->getSegmentMan(); +} + +const SharedHandle& AbstractCommand::getPieceStorage() const +{ + return requestGroup_->getPieceStorage(); +} + } // namespace aria2 diff --git a/src/AbstractCommand.h b/src/AbstractCommand.h index cd8b2c7c..687738b9 100644 --- a/src/AbstractCommand.h +++ b/src/AbstractCommand.h @@ -36,17 +36,24 @@ #define D_ABSTRACT_COMMAND_H #include "Command.h" + +#include +#include + #include "SharedHandle.h" #include "TimerA2.h" -#include "FileEntry.h" -#include "RequestGroup.h" namespace aria2 { +class FileEntry; +class RequestGroup; +class CheckIntegrityEntry; +class DownloadContext; +class SegmentMan; +class PieceStorage; class Request; class DownloadEngine; class Segment; -class Exception; class SocketCore; class Option; #ifdef ENABLE_ASYNC_DNS @@ -98,20 +105,14 @@ protected: return req_; } - void setRequest(const SharedHandle& request) - { - req_ = request; - } + void setRequest(const SharedHandle& request); const SharedHandle& getFileEntry() const { return fileEntry_; } - void setFileEntry(const SharedHandle& fileEntry) - { - fileEntry_ = fileEntry; - } + void setFileEntry(const SharedHandle& fileEntry); DownloadEngine* getDownloadEngine() const { @@ -123,10 +124,7 @@ protected: return socket_; } - void setSocket(const SharedHandle& s) - { - socket_ = s; - } + void setSocket(const SharedHandle& s); void createSocket(); @@ -213,20 +211,9 @@ protected: const SharedHandle