Reddit Secret and App ID Validation Fixed (#528)

apprise/plugins/NotifyReddit.py

@@ -161,14 +161,14 @@ class NotifyReddit(NotifyBase):
             'type': 'string',
             'private': True,
             'required': True,
-            'regex': (r'^[a-z0-9-]+$', 'i'),
+            'regex': (r'^[a-z0-9_-]+$', 'i'),
         },
         'app_secret': {
             'name': _('Application Secret'),
             'type': 'string',
             'private': True,
             'required': True,
-            'regex': (r'^[a-z0-9-]+$', 'i'),
+            'regex': (r'^[a-z0-9_-]+$', 'i'),
         },
         'target_subreddit': {
             'name': _('Target Subreddit'),

test/test_plugin_reddit.py

@@ -54,12 +54,12 @@ apprise_url_tests = (
         # No app secret
         'instance': TypeError,
     }),
-    ('reddit://user:password@app_id/appsecret/apprise', {
+    ('reddit://user:password@app%id/appsecret/apprise', {
-        # No invalid app_id (has underscore)
+        # No invalid app_id (has percent)
         'instance': TypeError,
     }),
-    ('reddit://user:password@app-id/app_secret/apprise', {
+    ('reddit://user:password@app%id/app_secret/apprise', {
-        # No invalid app_secret (has underscore)
+        # No invalid app_secret (has percent)
         'instance': TypeError,
     }),
     ('reddit://user:password@app-id/app-secret/apprise?kind=invalid', {