From 14d2c030c0922a0f8c7075534dc47a92158f9071 Mon Sep 17 00:00:00 2001 From: Ron <43244104+rons4@users.noreply.github.com> Date: Fri, 1 Aug 2025 23:12:04 +0200 Subject: [PATCH] Update PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 58 +++++++++++++++++++++++++++++--- 1 file changed, 53 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4083c2e3..e8089b74 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,28 +1,72 @@ ## Description: **Related issue (if applicable):** # - + * [ ] apprise/plugins/.py -* [ ] KEYWORDS +* [ ] pypackage.toml update `keywords` section to identify our new service - add new service into this file (alphabetically). * [ ] README.md - add entry for new service to table (as a quick reference) * [ ] packaging/redhat/python-apprise.spec - add new service into the `%global common_description` + -- END OF NEW PLUGIN SECTION - REMOVE ABOVE SECION IF NOT A NEW PLUGIN --> + ## Checklist * [ ] The code change is tested and works locally. * [ ] There is no commented out code in this PR. -* [ ] No lint errors (use `flake8`) -* [ ] 100% test coverage +* [ ] No lint errors (use `tox -e lint` and even `tox -e format` to autofix what it can) +* [ ] Test coverage added (use `tox -e minimal`) ## Testing + it would be really helpful to define this here --> Anyone can help test this source code as follows: ```bash # Create a virtual environment to work in as follows: @@ -41,4 +85,8 @@ pip install git+https://github.com/caronc/apprise.git@ apprise -t "Test Title" -b "Test Message" \ +# If you have cloned the branch and have tox available to you +# the following can also allow you to test: +tox -e apprise -- -t "Test Title" -b "Test Message" \ + ```