From ee6d489bf479cd7e7f1048a5116d7bcfe129fac1 Mon Sep 17 00:00:00 2001
From: tangjinzhou <415800467@qq.com>
Date: Thu, 17 Mar 2022 21:53:14 +0800
Subject: [PATCH] fix: formItem error repeat show, close #5349

---
 components/form/FormItem.tsx         | 29 +++++++++++++++++++---------
 components/form/FormItemInput.tsx    |  5 ++---
 components/form/utils/useDebounce.ts | 18 +++++++++++++++++
 3 files changed, 40 insertions(+), 12 deletions(-)
 create mode 100644 components/form/utils/useDebounce.ts

diff --git a/components/form/FormItem.tsx b/components/form/FormItem.tsx
index a0d673ba6..9ba4d4310 100644
--- a/components/form/FormItem.tsx
+++ b/components/form/FormItem.tsx
@@ -34,6 +34,7 @@ import FormItemLabel from './FormItemLabel';
 import FormItemInput from './FormItemInput';
 import type { ValidationRule } from './Form';
 import { useProvideFormItemContext } from './FormItemContext';
+import useDebounce from './utils/useDebounce';
 
 const ValidateStatuses = tuple('success', 'warning', 'error', 'validating', '');
 export type ValidateStatus = typeof ValidateStatuses[number];
@@ -368,15 +369,24 @@ export default defineComponent({
     onBeforeUnmount(() => {
       formContext.removeField(eventKey);
     });
+    const debounceErrors = useDebounce(errors);
+    const mergedValidateStatus = computed(() => {
+      if (props.validateStatus !== undefined) {
+        return props.validateStatus;
+      } else if (debounceErrors.value.length) {
+        return 'error';
+      }
+      return validateState.value;
+    });
     const itemClassName = computed(() => ({
       [`${prefixCls.value}-item`]: true,
 
       // Status
-      [`${prefixCls.value}-item-has-feedback`]: validateState.value && props.hasFeedback,
-      [`${prefixCls.value}-item-has-success`]: validateState.value === 'success',
-      [`${prefixCls.value}-item-has-warning`]: validateState.value === 'warning',
-      [`${prefixCls.value}-item-has-error`]: validateState.value === 'error',
-      [`${prefixCls.value}-item-is-validating`]: validateState.value === 'validating',
+      [`${prefixCls.value}-item-has-feedback`]: mergedValidateStatus.value && props.hasFeedback,
+      [`${prefixCls.value}-item-has-success`]: mergedValidateStatus.value === 'success',
+      [`${prefixCls.value}-item-has-warning`]: mergedValidateStatus.value === 'warning',
+      [`${prefixCls.value}-item-has-error`]: mergedValidateStatus.value === 'error',
+      [`${prefixCls.value}-item-is-validating`]: mergedValidateStatus.value === 'validating',
       [`${prefixCls.value}-item-hidden`]: props.hidden,
     }));
     return () => {
@@ -387,7 +397,7 @@ export default defineComponent({
           {...attrs}
           class={[
             itemClassName.value,
-            (help !== undefined && help !== null) || errors.value.length
+            (help !== undefined && help !== null) || debounceErrors.value.length
               ? `${prefixCls.value}-item-with-help`
               : '',
             attrs.class,
@@ -409,10 +419,11 @@ export default defineComponent({
                 {/* Input Group */}
                 <FormItemInput
                   {...props}
-                  errors={help !== undefined && help !== null ? toArray(help) : errors.value}
+                  errors={
+                    help !== undefined && help !== null ? toArray(help) : debounceErrors.value
+                  }
                   prefixCls={prefixCls.value}
-                  status={validateState.value}
-                  validateStatus={validateState.value}
+                  status={mergedValidateStatus.value}
                   ref={inputRef}
                   help={help}
                   extra={props.extra ?? slots.extra?.()}
diff --git a/components/form/FormItemInput.tsx b/components/form/FormItemInput.tsx
index 580a72f81..630fbec63 100644
--- a/components/form/FormItemInput.tsx
+++ b/components/form/FormItemInput.tsx
@@ -40,7 +40,6 @@ const FormItemInput = defineComponent({
     'prefixCls',
     'errors',
     'hasFeedback',
-    'validateStatus',
     'onDomErrorVisibleChange',
     'wrapperCol',
     'help',
@@ -68,7 +67,7 @@ const FormItemInput = defineComponent({
         help = slots.help?.(),
         errors = slots.errors?.(),
         hasFeedback,
-        validateStatus,
+        status,
         extra = slots.extra?.(),
       } = props;
       const baseClassName = `${prefixCls}-item`;
@@ -79,7 +78,7 @@ const FormItemInput = defineComponent({
       const className = classNames(`${baseClassName}-control`, mergedWrapperCol.class);
 
       // Should provides additional icon if `hasFeedback`
-      const IconNode = validateStatus && iconMap[validateStatus];
+      const IconNode = status && iconMap[status];
 
       return (
         <Col
diff --git a/components/form/utils/useDebounce.ts b/components/form/utils/useDebounce.ts
new file mode 100644
index 000000000..9c0c2adc3
--- /dev/null
+++ b/components/form/utils/useDebounce.ts
@@ -0,0 +1,18 @@
+import type { Ref } from 'vue';
+import { shallowRef, watchEffect } from 'vue';
+
+export default function useDebounce<T>(value: Ref<T[]>): Ref<T[]> {
+  const cacheValue = shallowRef(value.value.slice());
+  let timeout: any = null;
+  watchEffect(() => {
+    clearTimeout(timeout);
+    timeout = setTimeout(
+      () => {
+        cacheValue.value = value.value;
+      },
+      value.value.length ? 0 : 10,
+    );
+  });
+
+  return cacheValue;
+}