github
/
ant-design-vue
mirror of https://github.com/vueComponent/ant-design-vue
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: rowSelection trigger visible warning #4885 

close #4885
pull/4882/head
tangjinzhou 2021-11-20 16:06:56 +08:00
parent 84b9ac5904
commit 3e05460d09
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
components/table/hooks/useSelection.tsx
View File

@ -10,7 +10,7 @@ import devWarning from '../../vc-util/devWarning';
import useMergedState from '../../_util/hooks/useMergedState'; import useMergedState from '../../_util/hooks/useMergedState';
import useState from '../../_util/hooks/useState'; import useState from '../../_util/hooks/useState';
import type { Ref } from 'vue'; import type { Ref } from 'vue';
import { computed, shallowRef, watchEffect } from 'vue'; import { computed, shallowRef } from 'vue';
import type { CheckboxProps } from '../../checkbox'; import type { CheckboxProps } from '../../checkbox';
import Checkbox from '../../checkbox'; import Checkbox from '../../checkbox';
import Dropdown from '../../dropdown'; import Dropdown from '../../dropdown';
@ -167,12 +167,14 @@ export default function useSelection<RecordType>(
// Save last selected key to enable range selection // Save last selected key to enable range selection
const [lastSelectedKey, setLastSelectedKey] = useState<Key | null>(null); const [lastSelectedKey, setLastSelectedKey] = useState<Key | null>(null);
// Reset if rowSelection reset // // Reset if rowSelection reset
watchEffect(() => { // we use computed to reset, donot need setMergedSelectedKeys again like react
if (!rowSelectionRef.value) { // https://github.com/vueComponent/ant-design-vue/issues/4885
setMergedSelectedKeys([]); // watchEffect(() => {
} // if (!rowSelectionRef.value) {
}); // setMergedSelectedKeys([]);
// }
// });
const setSelectedKeys = (keys: Key[]) => { const setSelectedKeys = (keys: Key[]) => {
let availableKeys: Key[]; let availableKeys: Key[];