From 3aedf48eaf37666618ed02bcb2fae38c406d812a Mon Sep 17 00:00:00 2001
From: tangjinzhou <415800467@qq.com>
Date: Tue, 10 May 2022 15:48:14 +0800
Subject: [PATCH] feat: Breadcrumb accessibility improvements

---
 components/breadcrumb/Breadcrumb.tsx     |  6 +++++-
 components/breadcrumb/BreadcrumbItem.tsx | 12 ++++++------
 components/breadcrumb/style/index.less   | 12 ++++++++++--
 3 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/components/breadcrumb/Breadcrumb.tsx b/components/breadcrumb/Breadcrumb.tsx
index cbb49077d..40844ab50 100644
--- a/components/breadcrumb/Breadcrumb.tsx
+++ b/components/breadcrumb/Breadcrumb.tsx
@@ -152,7 +152,11 @@ export default defineComponent({
         [prefixCls.value]: true,
         [`${prefixCls.value}-rtl`]: direction.value === 'rtl',
       };
-      return <div class={breadcrumbClassName}>{crumbs}</div>;
+      return (
+        <nav class={breadcrumbClassName}>
+          <ol>{crumbs}</ol>
+        </nav>
+      );
     };
   },
 });
diff --git a/components/breadcrumb/BreadcrumbItem.tsx b/components/breadcrumb/BreadcrumbItem.tsx
index a1ce51757..5ef07f855 100644
--- a/components/breadcrumb/BreadcrumbItem.tsx
+++ b/components/breadcrumb/BreadcrumbItem.tsx
@@ -2,7 +2,7 @@ import type { ExtractPropTypes, PropType } from 'vue';
 import { defineComponent } from 'vue';
 import PropTypes from '../_util/vue-types';
 import { getPropsSlot } from '../_util/props-util';
-import DropDown from '../dropdown/dropdown';
+import Dropdown from '../dropdown/dropdown';
 import DownOutlined from '@ant-design/icons-vue/DownOutlined';
 import useConfigInject from '../_util/hooks/useConfigInject';
 import type { MouseEventHandler } from '../_util/EventInterface';
@@ -27,18 +27,18 @@ export default defineComponent({
     const { prefixCls } = useConfigInject('breadcrumb', props);
     /**
      * if overlay is have
-     * Wrap a DropDown
+     * Wrap a Dropdown
      */
     const renderBreadcrumbNode = (breadcrumbItem: JSX.Element, prefixCls: string) => {
       const overlay = getPropsSlot(slots, props, 'overlay');
       if (overlay) {
         return (
-          <DropDown overlay={overlay} placement="bottom">
+          <Dropdown overlay={overlay} placement="bottom">
             <span class={`${prefixCls}-overlay-link`}>
               {breadcrumbItem}
               <DownOutlined />
             </span>
-          </DropDown>
+          </Dropdown>
         );
       }
       return breadcrumbItem;
@@ -66,10 +66,10 @@ export default defineComponent({
       link = renderBreadcrumbNode(link, prefixCls.value);
       if (children) {
         return (
-          <span class={cls} style={style}>
+          <li class={cls} style={style}>
             {link}
             {separator && <span class={`${prefixCls.value}-separator`}>{separator}</span>}
-          </span>
+          </li>
         );
       }
       return null;
diff --git a/components/breadcrumb/style/index.less b/components/breadcrumb/style/index.less
index ca29afb3a..79dee8aec 100644
--- a/components/breadcrumb/style/index.less
+++ b/components/breadcrumb/style/index.less
@@ -13,6 +13,14 @@
     font-size: @breadcrumb-icon-font-size;
   }
 
+  ol {
+    display: flex;
+    flex-wrap: wrap;
+    margin: 0;
+    padding: 0;
+    list-style: none;
+  }
+
   a {
     color: @breadcrumb-link-color;
     transition: color 0.3s;
@@ -22,7 +30,7 @@
     }
   }
 
-  & > span:last-child {
+  li:last-child {
     color: @breadcrumb-last-item-color;
 
     a {
@@ -30,7 +38,7 @@
     }
   }
 
-  & > span:last-child &-separator {
+  li:last-child &-separator {
     display: none;
   }